[RESOLVED] sql and loop help

kterry

hello, have 3 tables in my database. IN_MASTER, IN_CATEGORIES, IN_ASSOCIATIONS.

I need to post a name and description to IN_MASTER, select the row, set the row ID in a variable, then post it along with the category ID into IN_ASSOCIATIONS all in the same script. I don't know what i am doing wrong. Here is a snipit of my code.

	if($in_name && $in_desc && $is_it){
		$sql1 = "INSERT INTO in_master (ingredient, description) VALUES ('$in_name', '$in_desc')";

		if(@mysql_query($sql1)){
		echo 'success!<br />';
		} else {
		echo 'an error occured ' . mysql_error();
	  	}

	$sql2 = "SELECT in_id FROM in_master WHERE ingredient = '$in_name'";

		$result = mysql_query($sql2);
		$num = mysql_numrows($result);
		while ($num == 1){
		$id = mysql_result($result, "in_id");
	    ++$num;
		}

	$sql3 = "INSERT INTO in_associations (in_id, ca_id) VALUES ('$id', '$is_it')";

		if(@mysql_query($sql)){
		echo 'success!<br />';
		} else {
		echo 'an error occured ' . mysql_error();
	  	}

SpecialFX

Well, a few points:

Why are you suppressing the errors from mysql_query() ? (preluding that function with '@' causes the error to not be shown if there is one.) That might give insight if something is going wrong.

$num = mysql_numrows($result);

should read

$num = mysql_num_rows($result);

What are you trying to do with your While loop? because $num can only ever equal 1, well once, because you increment it in the loop. Why not use an if statement then?
In my experience, incrementing is generally done after the variable as in $num++; although it can be done the way you have it.
You never close the final '}' of the beginning if statement.

Hope that helps!

kterry

Hey, that helps a lot. i just started PHP 2 days ago(cousin needs a quick web app), so it ain't bad.

I didn't show the closing curly brace cause that's only part of the code, i should have put it in there :-P

so the if statement should look like this...

if ($num == 1){
            $id = mysql_result($result, "in_id");
            $num = " ";
            }

right?

kterry

Fixed it. I rewrote the script considering I am now at work and the other script is at home.

	if ($ingredient && $description && $is_it){

	$sql1 = "INSERT INTO in_master (ingredient, description) VALUES ('$ingredient', '$description')";

        if (mysql_query($sql1)){
        echo 'success!<br />';
        } else {
        echo 'an error occured ' . mysql_error();
          }

    $sql2 = "SELECT in_id FROM in_master WHERE ingredient = '$ingredient'";

        $result = mysql_query($sql2);
        $num = mysql_num_rows($result);
        if ($num == 1){
        $id = mysql_result($result, "in_id");
        $num++;
        echo 'success!<br />';
        }

    $sql3 = "INSERT INTO in_associations (in_id, ic_id) VALUES ('$id', '$is_it')";

        if(@mysql_query($sql3)){
        echo 'success!<br />';
        } else {
        echo 'an error occured ' . mysql_error();
        }
 } else {
     echo 'Please go back and fill out the entire form.';
 }

I still need to add the row check on the first query so I don't double post.

Thanks for the help, man.