[RESOLVED] beginner using form php/mysql

btumpak

cant seem to get this to post to my db, please help! thanks...

form:

<form name="form1" method="post" action="process.php">
<table width="450" border="0">
<tr>
<td width="121">Last Name: </td>
<td width="217"><input name="lastname" type="text" id="lastname" size="20"></td>
</tr>
<tr>
<td width="121">Email Address: </td>
<td width="217"><input name="email" type="text" id="email" size="20"></td>
</tr>
<tr>
<td>ID Number: </td>
<td><input name="id" type="text" id="id" size="20" maxlength="9"></td>
</tr>
<tr>
<td>Site: </td>
<td> <select name="site" size="4" multiple><option value="nyc">New York City<option value="flo">Florence<option value="lon">London<option value="par">Paris</select></td>
</tr>

<tr>
  <td height="35" colspan="2"><div align="center">
    <input type="submit" name="Submit" value="Submit">
  </div></td>
</tr>

</table>
</form>

process.php:

<?php

// Pick up the form data and assign it to variables
$lastname = $POST['lastName'];
$email = $POST['email'];
$id = $POST['id'];
$site = $POST['site'];

// Open database connection
$conn = mysql_pconnect('location', 'user','password') or die(mysql_error());
mysql_select_db('databasename', $conn) or die(mysql_error());

// Insert data
mysql_query = "INSERT INTO 'tablename' (lastName, email, id, site);
VALUES ('$lastName', '$email', '$id', '$site')";
or die("mysql_error());

// Close connection
mysql_close($conn);

// Redirect
header("Location: thankyou.html");

jeepin81

loose the ";" in your query

<?php

// Pick up the form data and assign it to variables
$lastname = $_POST['lastName'];
$email = $_POST['email'];
$id = $_POST['id'];
$site = $_POST['site'];


// Open database connection
$conn = mysql_pconnect('location', 'user','password') or die(mysql_error());
mysql_select_db('databasename', $conn) or die(mysql_error());


// Insert data
mysql_query = "INSERT INTO 'tablename' (lastName, email, id, site) 
VALUES ('$lastName', '$email', '$id', '$site')"; 
or die("mysql_error());


// Close connection
mysql_close($conn);


// Redirect
header("Location: thankyou.html");


?>

give that a shot.

btumpak

thanks - didnt work though - still just sits on the process.php page. Would it have anything to do with pulling from the form (especially the site variable)?

jeepin81

try getting rid of your single quotes

<?php 

// Pick up the form data and assign it to variables 
$lastname = $_POST[lastName]; 
$email = $_POST[email]; 
$id = $_POST[id]; 
$site = $_POST[site]; 


// Open database connection 
$conn = mysql_pconnect('location', 'user','password') or die(mysql_error()); 
mysql_select_db('databasename', $conn) or die(mysql_error()); 


// Insert data 
mysql_query = "INSERT INTO tablename (lastName, email, id, site) 
VALUES ('$lastName', '$email', '$id', '$site')"; 
or die("mysql_error()); 


// Close connection 
mysql_close($conn); 


// Redirect 
header("Location: thankyou.html"); 


?>

see if that helps
j

bradgrafelman

If you'll look at jeepin's above post, you'll note that there are still errors in the script.

This is why you should always use the [PHP][/PHP] bbocde tags when posting code as they make your code much easier to read and analyze.

The problem you're having is not a missing " but rather an extraneous one - get rid of the quote in the or die() statement.

Also note that unless you really know the implications, you probably shouldn't be using [man]mysql_pconnect/man (especially since you're disconnecting at the end of the script).

You should also verify that the $POST variables exist before you attempt to use them. Also, $POST[lastName is not the proper method of referencing an item in an array; you should instead be using $_POST['lastName'] since "lastName" is a string and not a constant.

Finally, your script is vulnerable to SQL injection attacks. You should never place user-supplied data directly into a query. Instead, sanitize all user input with a function such as [man]mysql_real_escape_string/man first.

Durendal

i just noticed im not sure if its case sensitive but if so the name of lastname sent through the POST function is lastname and when your retrieving it in process.php you call $_POST['lastName'] so again if its case sensitive you probably wont be pulling that one through

btumpak

thanks for the help - I have made all suggestions and still have not been able to get data to post. After submitting the form - the process.php just loads and sits there.

I will work on mysql_real_escape_string()