need help with Pagination problem

Rizzler

hello, this code http://nopaste.php-quake.net/9687 it's a tag system and on the bottom of the page there is a "next" to shift page if there is more then 30 images in total for the tag a user pressed. if i however have the tag "tags.php?=games" and press "next" it becomes "tags.php?pagenum=2" and everyting becomes messed up, do anyone know why? and could help me some this problem? :/ i cant get my head around it.

edit: managed to get it working by changing the code bellow, but when i now press "next" it will reload the page on page 1 all the time and not go to 2 or 3 "/tags.php?pagenum=2&tag=" <-- resault i get in the browser, no tag :/

<?	
    echo " --Page $pagenum of $last-- <p>";

if ($pagenum == 1)
{
}
else
{
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=1&amp;tag={$_GET['tag']}'> <<-First</a> ";
echo " ";
$previous = $pagenum-1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous&amp;tag={$_GET['tag']}'> <-Previous</a> ";
}

//just a spacer
echo " ---- ";

if ($pagenum == $last)
{
}
else {
$next = $pagenum+1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next&amp;tag={$_GET['tag']}'>Next -></a> ";
echo " ";
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last&amp;tag={$_GET['tag']}'>Last ->></a> ";
}
?>

YAOMK

Try not using short tags to define your php code. Your problem is that you are not initializing the variable tag in your query string:

f i however have the tag "tags.php?=games" and press "next" it becomes "tags.php?pagenum=2"

this is because you should define your query string as:

tags.php?tag=games

Rizzler

YAOMK wrote:
Try not using short tags to define your php code. Your problem is that you are not initializing the variable tag in your query string:

this is because you should define your query string as:
tags.php?tag=games

and how can i do this ? :/

YAOMK

well how are your users getting to this page in your site? you could either post to it from the previous page using method="GET" in your <form> html tag or you could append it in the link that takes users to this page.

Rizzler

YAOMK wrote:
well how are your users getting to this page in your site? you could either post to it from the previous page using method="GET" in your <form> html tag or you could append it in the link that takes users to this page.

if you check here, http://filefrog.net/new.php?s=300 you will se several images with tags, press a tag and that's how users get there.

YAOMK

Nice site, your query string is retaining your tag now. The issue is that it is reloading the same content after the $pagenum is incremented, it looks like you need to account for $pagenum in your code to load the appropriate content not just the appropriate links as your script already does that.

Rizzler

YAOMK wrote:
Nice site, your query string is retaining your tag now. The issue is that it is reloading the same content after the $pagenum is incremented, it looks like you need to account for $pagenum in your code to load the appropriate content not just the appropriate links as your script already does that.

do you think you could help me do this? my head get's totaly blank :/

YAOMK

I don't have access to the rest of your script, but where you are echoing your html content, you need to have a condition based on $pagenum:

if ($_GET['pagenum']==2)
{
//get and display content for page 2
}

Rizzler

YAOMK wrote:
I don't have access to the rest of your script, but where you are echoing your html content, you need to have a condition based on $pagenum:
if ($_GET['pagenum']==2)
{
//get and display content for page 2
}

i changed the code bellow a bit now, but dont know if i did it right. if you now go to http://filefrog.net/tags.php?tag=games and press next it keeps the tag in browser while changing pagenum, but im still stuck at page 1 🙁

<?php

$con = mysql_connect("localhost","asd","das") OR die('Could not connect: ' . mysql_error());
mysql_select_db("asd", $con);

//This checks to see if there is a page number. If not, it will set it to page 1
if (!(isset($pagenum)))
{
$pagenum = 1;
}

$result = mysql_query("
    SELECT *
    FROM `images` 
    WHERE `tags`
    LIKE '%" . mysql_real_escape_string($_GET['tag']) . "%'
    ORDER BY views
    $max
")
OR die(mysql_error());
$rows = mysql_num_rows($result); 

//This is the number of results displayed per page
$page_rows = 30; 

$last = ceil($rows/$page_rows); 

if ($pagenum < 1)
{
$pagenum = 1;
}
elseif ($pagenum > $last)
{
$pagenum = $last;
} 

$max = 'limit ' .($pagenum - 1) * $page_rows .',' .$page_rows;

while($row = mysql_fetch_array($result))
{

echo '<div style="float:left;width:25%"><a href="http://filefrog.net/show.php/' .$row['id'].'_' .$row['name'].'"><img src="http://www.filefrog.net/out.php/t' .$row['id'].'_' .$row['name'].'"></a></div>'; 
echo "<br>\n";

}   

?>
<div style="clear:both"></div>
<?  

echo " --Page $pagenum of $last-- <p>";

if ($pagenum == 1)
{
}
else
{
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=1&amp;tag={$_GET['tag']}'> <<-First</a> ";
echo " ";
$previous = $pagenum-1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous&amp;tag={$_GET['tag']}'> <-Previous</a> ";
}

//just a spacer
echo " ---- ";

if ($pagenum == $last)
{
}
else {
$next = $pagenum+1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next&amp;tag={$_GET['tag']}'>Next -></a> ";
echo " ";
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last&amp;tag={$_GET['tag']}'>Last ->></a> ";
}
?>

YAOMK

If you look closely at the url, more specifically the query string, you will see pagenum updates to 2. It seems like your script makes use or register globals, is this the case?

Rizzler

YAOMK wrote:
If you look closely at the url, more specifically the query string, you will see pagenum updates to 2. It seems like your script makes use or register globals, is this the case?

yes, and i guess this is wrong ? 🙁

YAOMK

Yes, you should update your script not to use register globals, and turn it off in php.ini. It is really not hard to modify your code, just initialize $pagenum and $tag to the corresponding values contained in the super global $GET: $GET['pagenum'] and $_GET['tag'].

Visit the Register Globals section of the Php manual to learn more on the subject.

Now the main issue you have is that you are running your query:

$result = mysql_query("
    SELECT *
    FROM `images`
    WHERE `tags`
    LIKE '%" . mysql_real_escape_string($_GET['tag']) . "%'
    ORDER BY views
    $max
")
OR die(mysql_error());

before you define $max:

$max = 'limit ' .($pagenum - 1) * $page_rows .',' .$page_rows;

Note how $max is dependent on the value of $page_rows, that means that it needs to be defined before it can be used.

It doesn't really make sense to run the query everytime you hit a page to load the entire content over and over again, it'd be easier to pass it as an array in a hidden field from page to page.

YAOMK

Hope the above helps, if anything else comes up, don't hesitate to post.