Help with Update Script

[newbie_boston]

Trying to use an update script so I can edit some things in my database:

Have the following code below. I get the "Unable to select database" message and cannot figure out why...

Note: the "include" - dbinfo.inc.php includes the following code:

<?
$username="root";
$password="";
$database="samplephr";
?> 

Update Script:

<?
include("dbinfo.inc.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($samplephr) or die("Unable to select database");
$query="SELECT * FROM patient WHERE Patient_ID='$Patient_ID'";
$result=mysql_query($query);
$num=mysql_numrows($result); 
mysql_close();

$query=" SELECT * FROM patient WHERE Patient_ID='$Patient_ID'";
$result=mysql_query($query);
$num=mysql_numrows($result);
mysql_close();

$i=0;
while ($i < $num) {
$Patient_First_Name=mysql_result($result,$i,"Patient_First_Name");
$Patient_Last_Name=mysql_result($result,$i,"Patient_Last_Name");
$Patient_Prim_Phone=mysql_result($result,$i,"Patient_Prim_Phone");
$Patient_email=mysql_result($result,$i,"Patient_email");
$Patient_DOB=mysql_result($result,$i,"Patient_DOB");
$Patient_Height=mysql_result($result,$i,"Patient_Height");
$Patient_Weight=mysql_result($result,$i,"Patient_Weight");

?>

<form action="updated.php" method="post">
<input type="hidden" name="ud_Patient_ID" value="<echo $Patient_ID;>">
First Name: <input type="text" name="ud_Patient_First_Name" value="<echo $Patient_First_Name;>"><br>
Last Name: <input type="text" name="ud_Patient_Last_Name" value="<echo $Patient_Last_Name;>"><br>
Primary Number: <input type="text" name="ud_Patient_Prim_Phone" value="<echo $Patient_Prim_Phone;>"><br>
Email: <input type="text" name="ud_Patient_email" value="<echo $Patient_email;>"><br>
DOB: <input type="text" name="ud_Patient_DOB" value="<echo $Patient_DOB;>"><br>
Patient Height: <input type="text" name="ud_Patient_Height" value="<echo $Patient_Height;>"><br>
Patient_Weight: <input type="text" name="ud_Patient_Weight" value="<echo $Patient_Weight;>"><br>
<input type="Submit" value="Update">
</form>

<?
++$i;
}
?>

Thanks for any help!

[rsmith]

newbie_boston wrote:

@mysql_select_db($samplephr) or die("Unable to select database");

You need to put @mysql_select_db($database) or die("Unable to select database");

You tried to put the value you assigned to $database inside your include file as the variable.

[newbie_boston]

Great. That worked - stupid error on my part. Thank you.

Now I get a blank screen when I thought I would get my form...am I missing something?

[rsmith]

newbie_boston wrote:

Great. That worked - stupid error on my part. Thank you.

Now I get a blank screen when I thought I would get my form...am I missing something?

If I understand what you're trying to do you are trying to select all the entries in the db and build a table to list them.

<?

$query = "SELECT * FROM patient";
$result = mysql_query($query);
$num = mysql_num_rows($result); 
$patient = mysql_fetch_assoc($result);
?>

Now build the first row of the table. Note I only created one table element, up to you to do the rest.

<table align="center" border="1" width="900" cellpadding="1" cellspacing="1">
  <tr>
    <td valign="middle">
      Patient Name
    </td>
  </tr>

Now generate each row with php:

<?
while($num > 0){
     echo "<tr>";
     echo "<td>".$patient['Patient_First_Name']."</td>"; //repeat this line as necessary for each td element replacing the parameter of the array as necessary.
     echo "</td>";
    }
?>

Now close the table after the while loop

</table>

I'm at work right now and can't test for sure but it should work. Hope this helps point you in the right direction!

[newbie_boston]

Thank you.

Actually, I was hoping to list the values from the database within the form so the user can update his/her information.

BUT I was hoping to list them as well so your information is a HUGE help. Thanks a lot!

[rsmith]

No problem. If you want to allow the editing you'll need to create an edit link. I do this on my sites all the time to allow editing profiles. Here's an example snippet that i would input into another td element as the last td in the row:

<?
     echo "<td><a href=patientEdit.php?patientID=".$patient['Patient_ID'].">Edit</a></td>";
?>

This way you pass the ID to a new script called patientEdit.php. The first line on the script would be:

<?
     patientID = $_POST['patientID'];
?>

Then you would construct a query to pull the information for the specified patientID and fill in the form values with the data extracted from the db that pertains to the patientID.

[newbie_boston]

Ok so I have the following code (think i am confusing myself more than I need to...)

I have a menu with a "Update" link. The user clicks this link and comes to a prompt asking for their Patient ID. They type it in and click "Update". After that I have the following code called "update.php"

I am trying to get the info from the database linked to the Patient ID to appear. All I can get is the table with "Patient Name" to appear on the webpage:

Thanks again.

<html>
<head>
<body>
<?
include("dbinfo.inc.php"); 
mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die("Unable to select database");
$query="SELECT * FROM patient WHERE Patient_ID='$Patient_ID'";
$result=mysql_query($query);
$num=mysql_numrows($result); 
$patient = mysql_fetch_assoc($result);
mysql_close();
?>
<table align="center" border="1" width="900" cellpadding="1" cellspacing="1">
  <tr>
    <td valign="middle">
      Patient Name
    </td>
  </tr>
<? 
while($num > 0){ 
     echo "<tr>"; 
     echo "<td>".$patient['Patient_First_Name']."</td>"; //repeat this line as necessary for each td element replacing the parameter of the array as necessary. 
     echo "</td>"; 
} 
?> 
</table>
</body>
</head>
</html>

[rsmith]

Okay well then you need to tell the script what to use as the information to store in the variable $PatientID. So what method are you using to pass the PatientID to your update.php script? In other words, what form method do you have defined for the form in which the user enters the id of the patient to update?

Should be something like (very basic form):

<form action="update.php" method="post">
  <input type="text" name="Patient_ID">
  <input type="submit" name="submit" value="Submit">
</form>

Now you should tell update.php to pull the Patient_ID from the url passed to it when the user clicks on the submit button. Put all this above your <html> tag btw.

<?
    include("dbinfo.inc.php");

 $Patient_ID = $_POST['Patient_ID'];

 //This should be your query 

      mysql_connect(localhost,$username,$password); 
      @mysql_select_db($database) or die("Unable to Connect to Database");
      $query = "SELECT * FROM patient WHERE Patient_ID=".$Patient_ID."";
      $result = mysql_query($query);
      $num = mysql_num_rows($result);
      $patient = mysql_fetch_assoc($result);
?>

This should help better. Also keep in mind that if this is the update page you'll want to have a form outputted that has the values of the db fill in the values of the form so that the user can update the entries. Like the following:

<form action="updateSave.php" method="POST">
  <table align="center" border="1" cellpadding="1" cellspacing="1" width="900">
    <tr>
      <td>Patient Name</td>
    </tr>

<?
     $Patient_First_Name = $patient['Patient_First_Name'];

 while($num > 0){
      echo "<tr>";
      echo "<td><input type='text' name='Patient_First_Name' value='".$Patient_First_Name."'></td>";
      echo "</tr>";
  }
?>

Close the table.

</table>

Hope this helps!

[newbie_boston]

It does, thank you - starting to make sense.

Just because I have not seen these before I got the following errors:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in C:\xampp\htdocs\update.php on line 12

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in C:\xampp\htdocs\update.php on line 13

[rsmith]

Nice call on Xampp. I love that all-in-one environment. Please post your current update.php script so I can see the exact line.

[newbie_boston]

Yes, XAMMP is great. Seeing as I am tackling a project for my M.S. degree a semester before my database backed website class - it has helped out a lot.

Code below - thanks again.

<? 
include("dbinfo.inc.php"); 

$Patient_ID = $_POST['Patient_ID']; 

//This should be your query 

mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die("Unable to Connect to Database"); 
$query="SELECT * FROM patient WHERE Patient_ID=".$Patient_ID.""; 
$result=mysql_query($query); 
$num=mysql_num_rows($result); 
$patient=mysql_fetch_assoc($result); 
?>
<html>
<head>
<body>
<form action="updateSave.php" method="POST">
<table align="center" border="1" width="900" cellpadding="1" cellspacing="1">
  <tr>
    <td valign="middle">
      Patient Name
    </td>
  </tr>
<? 
     $Patient_First_Name = $patient['Patient_First_Name']; 

 while($num > 0){ 
      echo "<tr>"; 
      echo "<td><input type='text' name='Patient_First_Name' value='".$Patient_First_Name."'></td>"; 
      echo "</tr>"; 
  } 
?>
</table>
</body>
</head>
</html>

[rsmith]

Copy the following code and set the $query line to this:

$query = "SELECT * FROM patient WHERE Patient_ID = '".$Patient_ID."'";

Notice that .$Patient_ID is enclosed first in a single quote (') then a double quote (") and ends in double-single-double ("'")

[newbie_boston]

So I did that and when I entered the Patient ID on the form and the php script was called - it didnt load (took forever and IE eventually had to be shut down - froze).

[rsmith]

Okay, well, post the form used to submit the ID for update, what's the structure of the "Patient" table?

[newbie_boston]

Here is the form:

<META HTTP-EQUIV="Content-Type" CONTENT="text/html">
<html>
<body bgcolor="F3F3FF">
<link rel="stylesheet" type="text/css"href="style.css" />
<head>
<h2 align="center"><a name="home"><FONT FACE="Arial" SIZE="5">Personal Health Record Version 1.0</font></a></h2>
<h4 align="center"><a href="phrmenu.html">Back to PHR Menu</a>
<FORM ACTION="update.php" METHOD="POST">

<TABLE CLASS="MYTABLE">
<CAPTION CLASS="MYTABLE"><h3>Existing User - Enter Patient ID<h3></CAPTION>
<THEAD>
<TR CLASS="MYTABLE">
<TH CLASS="MYTABLE">Patient ID: <input type=text name="Patient_ID"> Form: First Initial, Middle Initial and Last initial, DOB (no &quot;/&quot😉 and Sex</TH>
<TH CLASS="MYTABLE"><input type="submit" value="Update Record" name="Update"></TH>
</TR>
</THEAD>
</TBODY>
</TABLE>
<BR>
<BR>
<TABLE CLASS="MYTABLE">
<CAPTION CLASS="MYTABLE"><h3>Exit PHR<h3></CAPTION>
<THEAD>
<TR CLASS="MYTABLE">
<TH CLASS="MYTABLE"><h4><a href="javascript:self.close()">Close</a>
</TR>
</THEAD>
</TBODY>
</TABLE>
<BR>
<BR>
</form>
</body>
</html>

Here is the database structure:

Patient_ID varchar(20)

Patient_First_Name text

Patient_Middle_Name text

Patient_Last_Name text

Patient_DOB date

Patient_Sex char(1)

Patient_Street_Address1 varchar(50)

Patient_Street_Address2 varchar(50)

Patient_City varchar(15)

Patient_State varchar(2)

Patient_Zip varchar(5)

Patient_email varchar(30)

Patient_Prim_Phone varchar(10)

Patient_Blood_Type varchar(3)

Patient_Language varchar(10)

Patient_Height varchar(3)

Patient_Weight varchar(3)

Ins_Provider_ID varchar(15)

Ins_Policy_Number varchar(20)

Ins_Policy_Holder varchar(25)

PCP_ID varchar(15)

[rsmith]

Well first off...

<input type=text name="Patient_ID">

Needs to be...

<input type="text" name="Patient_ID">

Common mistake, but if you put the values of attributes in quotes, you have to make sure you do it for each one otherwise you run into stupid parse errors and it can be finicky. See if that could be the problem. And for future posts, please make sure you utlizie the code and /code for all non-php code and the php /php tags for all php related code. It makes life a lot easier on us trying to help 🙂

[newbie_boston]

Sorry bout that - will do from now on. I changed that form and all other forms to "text" is there - still hung in IE

[rsmith]

Post the entire update.php script too. Thanks

[newbie_boston]

HTML Form:

<META HTTP-EQUIV="Content-Type" CONTENT="text/html">
<html>
<body bgcolor="F3F3FF">
<link rel="stylesheet" type="text/css"href="style.css" />
<head>
<h2 align="center"><a name="home"><FONT FACE="Arial" SIZE="5">Personal Health Record Version 1.0</font></a></h2>
<h4 align="center"><a href="phrmenu.html">Back to PHR Menu</a>
<FORM ACTION="update.php" METHOD="POST">

<TABLE CLASS="MYTABLE">
<CAPTION CLASS="MYTABLE"><h3>Existing User - Enter Patient ID<h3></CAPTION>
<THEAD>
<TR CLASS="MYTABLE">
<TH CLASS="MYTABLE">Patient ID: <input type=text name="Patient_ID"> Form: First Initial, Middle Initial and Last initial, DOB (no &quot;/&quot and Sex</TH>
<TH CLASS="MYTABLE"><input type="submit" value="Update Record" name="Update"></TH>
</TR>
</THEAD>
</TBODY>
</TABLE>
<BR>
<BR>
<TABLE CLASS="MYTABLE">
<CAPTION CLASS="MYTABLE"><h3>Exit PHR<h3></CAPTION>
<THEAD>
<TR CLASS="MYTABLE">
<TH CLASS="MYTABLE"><h4><a href="javascript:self.close()">Close</a>
</TR>
</THEAD>
</TBODY>
</TABLE>
<BR>
<BR>
</form> 
</body>
</html>

SQL Table:

Patient_ID varchar(20)
Patient_First_Name text
Patient_Middle_Name text
Patient_Last_Name text
Patient_DOB date
Patient_Sex char(1)
Patient_Street_Address1 varchar(50)
Patient_Street_Address2 varchar(50)
Patient_City varchar(15)
Patient_State varchar(2)
Patient_Zip varchar(5)
Patient_email varchar(30)
Patient_Prim_Phone varchar(10)
Patient_Blood_Type varchar(3)
Patient_Language varchar(10)
Patient_Height varchar(3)
Patient_Weight varchar(3)
Ins_Provider_ID varchar(15)
Ins_Policy_Number varchar(20)
Ins_Policy_Holder varchar(25)
PCP_ID varchar(15)

Update PHP:

<? 
include("dbinfo.inc.php"); 

$Patient_ID = $_POST['Patient_ID']; 

//This should be your query 

mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die("Unable to Connect to Database"); 
$query = "SELECT * FROM patient WHERE Patient_ID = '".$Patient_ID."'";
$result=mysql_query($query); 
$num=mysql_num_rows($result); 
$patient=mysql_fetch_assoc($result); 
?>
<html>
<head>
<body>
<form action="updateSave.php" method="POST">
<table align="center" border="1" width="900" cellpadding="1" cellspacing="1">
  <tr>
    <td valign="middle">
      Patient Name
    </td>
  </tr>
<? 
     $Patient_First_Name = $patient['Patient_First_Name']; 

 while($num > 0){ 
      echo "<tr>"; 
      echo "<td><input type='text' name='Patient_First_Name' value='".$Patient_First_Name."'></td>"; 
      echo "</tr>"; 
  } 
?>
</table>
</body>
</head>
</html>

[rsmith]

Just out of curiosity try this:

<?
     $Patient_First_Name = $patient['Patient_First_Name'];

 while($num > 0){
      echo "<tr>";
      echo "<td><input type=text name=Patient_First_Name value=".$Patient_First_Name."></td>";
      echo "</tr>";
  }
?> 

I removed the single quotes from around the parameters.