logic issue

[madmansd]

can some one help the first query is working but not the second the actual queries are fine but the logic is off please help

<?php #accountdetails.php

// Check if the form has been submitted.
if (isset($_POST['submitted'])) 
{
 require_once ('mysql_connect.php'); // Connect to the db.

                           // Create a function for escaping the data.
    					   function escape_data ($data) {
						   global $dbc; // Need the connection.
						   if (ini_get('magic_quotes_gpc')) {
						   $data = stripslashes($data);
						   }
						   return mysql_real_escape_string(trim($data), $dbc);
						   } // End of function.

						   $errors = array(); // Initialize error array.

						   // Check for a Policy Number
						   if (empty($_POST['policy_id'])) {
						   $errors[] = '<font color="red"> * You forgot to enter your username</font>';
						   } else {
						   $u = escape_data($_POST['policy_id']);
						   }
			   				// Check for insurance classfication
							if (empty($_POST['insclass'])) {

							$id = ($_POST['insclass']);
							} else {
							$g = escape_data($_POST['insclass']);
							}







						if (empty($errors)){
				 							$id = ($_POST['insclass']);

									 				if ($id == 1){
												         $query = "SELECT ins_class, policy_start_date, policy_renewal_date , valuation , vehicle_name, model, eng_no,  chassis_no, reg_no, 															 classification,  premium FROM vehicle_ins WHERE vehicle_ins.policy_id = '$u' ";

															      $result = @mysql_query($query);

															              if (mysql_affected_rows() > 0)
															               {
																                if ($row = mysql_fetch_array($result))
																				       {
																						echo '<table width="100%" border="0">
																   						     	<tr>
																								<td>Coverage</td>
																								<td> ' . $row['ins_class'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Policy Start Date</td>
																								<td bgcolor="">' . $row['policy_start_date'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Valuation</td>
																								<td bgcolor="">' . $row['valuation'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Policy Renewal date &nbsp;</td>
																								<td>' . $row['policy_renewal_date'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Vehicle name</td>
																								<td>' . $row['vehicle_name'] .'&nbsp;&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Model</td>
																								<td>' . $row['model'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Type</td>
																								<td>' . $row['classification'] .'&nbsp;</td>
																							    </tr>
																							 	<tr>
																								<td>Engine number</td>
																								<td>' . $row['eng_no'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Chassis number </td>
																								<td>' . $row['chassis_no'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>License number</td>
																								<td>' . $row['reg_no'] .'&nbsp;</td>
																							    </tr>
																							    <tr>
																								<td>Premium</td>
																								<td>' . $row['premium'] .'&nbsp;</td>
																							    </tr>
																							    </table></br></br></br></br>';

																			echo '<a href="http://localhost/getquote/editvehicle1.php"><img src="edit.gif" alt="edit" border="0"/></a>';

												                            }	
												                                 mysql_free_result ($result); // Free up the resources.	
									                        }else {
										                    // If it did not run OK.
															echo 'The selected vehicle insurance policy does not exist in our records';


															}  if ($id == 2)
															{
  $query = "SELECT ins_type, policy_id, policy_start_date, policy_renewal_date, property_value, prop_add, prop_add1, prop_add2, premium FROM home_ins WHERE home_ins.policy_id = '$u'";

															$result = @mysql_query($query);

															if (mysql_affected_rows() > 0)
															{
																if ($row = mysql_fetch_array($result))
																				{
																						echo '<table width="100%" border="0">

																							<tr>
																							<td>Insurance code </td>
																							<td bgcolor="">' . $row['ins_type'] .'&nbsp;</td>
																						  </tr>
																						   <tr>
																							<td>Policy number</td>
																							<td> ' . $row['policy_id'] .'&nbsp;</td>
																						  </tr>

																						  <tr>
																							<td>Policy Start Date</td>
																							<td bgcolor="">' . $row['policy_start_date'] .'&nbsp;</td>
																						  </tr>
																						  <tr>
																							<td>Policy Renewal date &nbsp;</td>
																							<td>' . $row['policy_renewal_date'] .'&nbsp;</td>
																						  </tr>
																						  <tr>
																							<td>Property value</td>
																							<td>' . $row['property_value'] .'&nbsp;&nbsp;</td>
																						  </tr>
																						  <tr>
																							<td>Address</td>
																							<td>' . $row['prop_add'] .'&nbsp;</td>
																						  </tr>
																						  <tr>
																							<td>Address</td>
																							<td>' . $row['prop_add1'] .'&nbsp;</td>
																						  </tr>


																						  <tr>
																							<td>Address</td>
																							<td>' . $row['prop_add2'] .'&nbsp;</td>
																						  </tr>

																						<tr>
																							<td>Premium</td>
																							<td>' . $row['premium'] .'&nbsp;</td>
																						  </tr>




																							</table></br></br></br></br>';

															echo '<a href="http://localhost/getquote/editproperty.php"><img src="edit.gif" alt="edit" border="0"/></a>';

												                                  }	
												                                 mysql_free_result ($result); // Free up the resources.	
									                        }else{
										                    // If it did not run OK.
															echo 'The selected property insurance policy does not exist in our records';


															}






															}											




											}					

								}
						}



			   ?>
        <form action="accountdetails.php" method="post">
          <table width="100%" border="0">
            <tr>
              <td width="25%">Policy number:&nbsp;</td>
              <td width="75%"><input type="text" name="policy_id" id="policy_id" size="15" maxlength="60" value="<?php if (isset($_POST['policy_id'])) echo $_POST['policy_id']; ?>" />
                &nbsp;</td>
            </tr>
            <tr>
              <td>Insurance classification:&nbsp;</td>
              <td><select name="insclass" id="insclass"  size="1">
                  <option value="1">Motor Insurance</option>
                  <option value="2">Property Insurance</option>
                  <option value="3">Medical Insurance</option>
                </select>
                &nbsp; </td>
            </tr>
          </table>
          </br>
          </br>
          <input type="image" name="submit" value="submit" src="submit.gif" alt="submit" />
          <br />
          <input type="hidden" name="submitted" value="TRUE" />
        </form>

[bradgrafelman]

Couple of things:

if (empty($_POST['insclass'])) {

                            $id = ($_POST['insclass']);

If you just established that $_POST['insclass'] is empty (possibly not even set), why would you attempt to use it as a value for a variable?

Also, if $_POST['insclass'] is defined, $id won't be.

You also have the if($id == 2) if() statement inside of the if($id == 1) statement, which obviously makes no sense at all.

I think you need to remove a lot of the extra spacing (one tab is plenty for indenting!) and follow your if() statements. Remove the HTML (which, in my opinion, shouldn't even be mixed with the PHP code) so it's easier to follow.

I would also recommend a decent editor; I, for example, use Notepad2 which allows me to click on an opening { or [ and the editor will show me where the matching } or ] is (if there is one - if not, it'll use a different color so that I know something doesn't match up).

Also, you have some redundant if() statements. For example, this:

$result = @mysql_query($query);

			if (mysql_affected_rows() > 0)
			 {
						if ($row = mysql_fetch_array($result))
									 {

could be reduced to this:

$result = @mysql_query($query);
if ($result && $row = mysql_fetch_array($result)) {

EDIT: Small MySQL optimization tip; since you're only expecting 1 row to be returned at most, you could add a 'LIMIT 1' clause onto the end of your queries.

[Weedpacket]

It's also <br />, not </br>.

This looks like two (supposed to be three?) different pages glommed together and separated by IDs. It looks to me like it would benefit from being split into separate files, with appropriate files being included as needed when appropriate. If nothing else, it would simplify the code on each page and make it easier to debug.

bradgrafelman wrote:

Also, if $_POST['insclass'] is defined, $id won't be.

On the other hand, $g will be defined, even though it's never used.