[RESOLVED] fopen (r+) problem

[oldnewbie]

Can anyone give me a pointer please, I'm new at this but keen to learn:

I am converting text to html from an uploaded file, applying some CSS then writing the html to the top of an Existing file which is called as an include on a web page.

Code is:

<?php
$source = "plain.txt";
$raw = file($source) or die("Cannot read file");
$slug = array_shift($raw);
$byline = array_shift($raw);
$data = join('', $raw);
$html = nl2br(htmlspecialchars($data));
$html = preg_replace('/\s\s+/', ' ', $html);

$output .= "<div class='newentry'>";
$output .= "<div class='slug'>$slug</div>";
$output .= "<div class='byline'>$byline</div>";
$output .= "<div class='text'>$html</div>";
$output .="</div>";

$handle = fopen("reports.php", "r+");
$filename = 'reports.php';
$somecontent = "$output";

if (is_writable($filename)) {

if (!$handle = fopen($filename, 'r+')) {
     echo "Cannot open file ($filename)";
     exit;
}

if (fwrite($handle, $somecontent) === FALSE) {
    echo "Cannot write to file ($filename)";
    exit;
}

echo "Success, wrote to file ($filename)";

fclose($handle);

} else {
echo "The file $filename is not writable";
}
?>

This all works Except it overwrites what is already in the reports.php file instead of placing new html at top which the r+ mode says should be happening.

I dare say the code is the most inelegant you've seen so if anyone cares to help with problem and suggest, neater more efficient execution, I'd be very grateful.

Thanks in advance.

[rsmith]

Use w not r+. W means write only, beginning of file.

[oldnewbie]

Thanks RSmith but 'w' will delete everything that is in my file reports.php (the problem I am trying to overcome). r+ should write to top of existing, w writes to top and chops all else.

[rsmith]

What if you specify the full path the to the file instead of just the file name? I would write it like this:

<?
	$source = "plain.txt";
	$raw = file($source) or die("Cannot read file");
	$slug = array_shift($raw);
	$byline = array_shift($raw);
	$data = join('', $raw);
	$html = nl2br(htmlspecialchars($data));
	$html = preg_replace('/\s\s+/', ' ', $html);

$output = "<div class='newentry'><div class='slug'>$slug</div><div class='byline'>$byline</div><div class='text'>$html</div></div>";

$handle = fopen("reports.php", "r+");
$filename = "reports.php";
$somecontent = $output;

if(!$handle){
	echo "Cannot open file: $filename";
	exit;
}else{
	if(is_writable($filename)){
		fwrite($handle, $somecontent);
		echo "Successfully wrote to file: $filename";
	}else{
		echo "Unable to write to file: $filename":
	}
}

fclose($handle);
?>

For Future Reference, make sure you enclose any code you post in the php /php or the code /code tags. Makes it easier on us trying to help you.

[oldnewbie]

Thanks again but the files all lay in the root at the moment so are the full path (unless you mean absolute path url et al?)

[rsmith]

Nope, not the absolute path. Did you try using my above example?

[oldnewbie]

Thanks again rsmith - I think our posts have crossed. I tried something similar and have just tried this but with same result. Struggling with your _POST version but will keep at it. Wonder if it might be better to accomplish this in two processes? First convert txt and save output to a new file. Then go for the openreadcopy reports.php write new write old?

Apologies for not using the CODE tags previously.

[rsmith]

Might I ask why you are doing the array_shift()? What exactly is in the contents of your source .txt file? In all theory the code I posted above SHOULD work. Just for giggles what if you change the r+ to x+ and specify a new filename instead of reports.php set the filename as test.txt but don't physically create the file. x+ will create it, then change it back to r+ and see if it appends to the test.txt file.

[oldnewbie]

Hi rsmith - the array_shift enables me to apply the CSS to that line.

Thanks to your help and others on different forums I have sold the problem completely.

The solution is:

<?php

$source = "plain.txt"; 
$raw = file($source) or die("Cannot read file"); 
$slug = array_shift($raw); 
$byline = array_shift($raw); 
$data = join('', $raw); 
$html = htmlspecialchars($data); 
$html = preg_replace('/\n\n/', '<br /><br />', $html); //This preserves paragraph breaks
$html = preg_replace('/\n/', '', $html); 
$html = preg_replace('/\s\s+/', ' ', $html); 

$output .= "<div class='newentry'>"; 
$output .= "<div class='slug'>$slug</div>"; 
$output .= "<div class='byline'>$byline</div>"; 
$output .= "<p>$html</p>"; 
$output .="</div>"; 


$reportfile = "reports.php";
$fh = fopen($reportfile , 'r');  //opens reports.php for reading
$news = $output;   //gets the new data

if (!file_exists("reports.php")) touch("reports.php");

$fcontent = fread($fh, filesize("reports.php")); //copies all data from reports.php

$towrite = "$fcontent";

$fh2 = fopen('reports.php','w+'); //opens file to be written to

fwrite($fh2,$news); //adds new data to file
fwrite($fh2,$towrite); //adds old content to file
fclose($fh); //closes file
fclose($fh2); //closes file

?>