Warning-Noob Question (empty & isset)

DefunctExodus

Yes i am a noob 🙁

Perhaps i am just nothing thinking straight but i have having some issues currently, What i am trying to do is check to see if a variable has been set (posted from a previous page)

If it empty i need to doa mysql insert, However if it has been set i need to to do a select and store it in a variable untill later on in the form.

I am sure i completley screwed this up but like i said i am a noob 🙁 Laugh if you must.

Here is what i am using.

if (empty($OldID)) {

mysql_query("
	INSERT INTO table SET
	fieldName = '". $Another Variable."'
	",$dbConnection);

} else {

if (isset ($OldID)) {

mysql_query("
	SELECT field FROM table
	WHERE secondfield='".$OldID."',
	AND Timestampe field='".0000-00-00 00:00:00."'",$dbConnection);


}

I am sure i have messed up some of the code also i do not know how to query against a time stamp that has no date set in it yet.

homer09001


if (isset ($OldID)) {

mysql_query("
	SELECT field FROM table
	WHERE secondfield='".$OldID."',
	AND Timestampe field='".0000-00-00 00:00:00."'",$dbConnection);
}
else
{

mysql_query("
	INSERT INTO table SET
	fieldName = '". $Another Variable."'
	",$dbConnection);

}

that should work a charm

DefunctExodus

For some reaosn i am still having problems, It just will not insert anythign at all now.

Here is all my code for this script.

Any help would be appretiated.

$templateName = 'test';
$templateOwner = '';
$OldID = $_REQUEST["group_id"];
$groupName ='TestGroup';

mysql_query("
	INSERT INTO table SET
	feild = '" . $variable . "',
	feild = '" . $variable . "'
", $dbConnection);


$Template_id = mysql_insert_id($dbConnection);

foreach ( $UI_CoolData as $i_header => $header ){


mysql_query("
	INSERT INTO table SET
	field = '" . $variable['TEXT'] . "',
	field = ' " . $variable. "'
", $dbConnection);


$cat_id = mysql_insert_id($dbConnection);


mysql_query("
	INSERT INTO table SET
	field = '" . $variable. "',
	field = '" . $variable. "'
");


foreach ( $header['QUESTIONS'] as $i_question => $question ){


	mysql_query("
		INSERT INTO table SET
		field= '" . $variable['TEXT'] . "',
		field = '" . $variable['TYPE'] . "',
		field = ' " . $variable['VALUE'] . "',
		field = '" . $variable. "'
	", $dbConnection);


	$ques_id = mysql_insert_id($dbConnection);


	mysql_query("
		INSERT INTO tableSET
		field = '" . $variable. "',
		field = '" . $variable. "'
	");

}

}


mysql_close($dbConnection);


<html>
	<body>
		The data was saved on database.
	</body>
</html>

bpat1434

You should be using isset() prior to empty() 😉 So:

if(!isset($OldID))
{
    // Not set, do an INSERT query
}
elseif(empty($OldID))
{
    // Empty, do an INSERT query
}
else
{
    // Set and not empty, so do a SELECT
}

Now, for your second set of code: Where do you define $variable and it's value? $variable is never defined to have a value, so you're inserting blank values every time. And if $variable is an array, then most of the fields you set are going to have "Array" as their value.

DefunctExodus

Oh oops sorry just for this pose i replaced the actuall variables with $variable.

Without the portion that i am trying to add it works fine. But as soon as i add it in (Perhaps i am messing up when i put the code in? ) It stops working all toghter.

Here is what i am using

$variable is just a place holder for this post.

$templateName = 'test'; 
$templateOwner = ''; 
$OldID =  '2';           

$groupName ='Test';



if(!isset($OldID)) 
{ 
mysql_query(" 
    SELECT field FROM table 
    WHERE field='".$variable."', 
    AND eff_end ='".0000-00-00 00:00:00."'",$dbConnection); 

} 
elseif(empty($OldID)) 
{ 
mysql_query(" 
    INSERT INTO table SET 
    field = '". $variable."' 
    ",$dbConnection); 

}
} 
else 
{

mysql_query(" 
    INSERT INTO table SET 
    feild = '" . $variable . "', 
    feild = '" . $variable . "' 
", $dbConnection); 


$Template_id = mysql_insert_id($dbConnection); 

foreach ( $UI_CoolData as $i_header => $header ){ 


mysql_query(" 
    INSERT INTO table SET 
    field = '" . $variable['TEXT'] . "', 
    field = ' " . $variable. "' 
", $dbConnection); 


$cat_id = mysql_insert_id($dbConnection); 


mysql_query(" 
    INSERT INTO table SET 
    field = '" . $variable. "', 
    field = '" . $variable. "' 
"); 


foreach ( $header['QUESTIONS'] as $i_question => $question ){ 


    mysql_query(" 
        INSERT INTO table SET 
        field= '" . $variable['TEXT'] . "', 
        field = '" . $variable['TYPE'] . "', 
        field = ' " . $variable['VALUE'] . "', 
        field = '" . $variable. "' 
    ", $dbConnection); 


    $ques_id = mysql_insert_id($dbConnection); 


    mysql_query(" 
        INSERT INTO tableSET 
        field = '" . $variable. "', 
        field = '" . $variable. "' 
    "); 

} 

} 


mysql_close($dbConnection); 


<html> 
    <body> 
        The data was saved on database. 
    </body> 
</html>

bpat1434

Okay, while $variable may be a placeholder, show us the real code. What you think is insignificant might actually be a problem you don't know you have 😉

Now, is the above code the real code? If so where does $UI_Cooldata come from?

Also, for each mysql_query() call, you should be catching errors with "or die(mysql_error())" following the mysql_query call:

mysql_query($query) or die(mysql_error());

DefunctExodus

<?php
require_once('cq.xmlparse.ui.php');



$objParser = new UI_CollParser();
$UI_CoolData = $objParser->parseFormToArray($_POST['UI_CoolParameters']);


$dbConnection = mysql_connect('localhost', 'user', 'pass');
mysql_select_db('stats', $dbConnection);


$templateName = 'test';
$templateOwner = 'number';

//$OldID =  '2';              

$groupName ='TestGroup';

if(isset($OldID)) { 
	echo "isset";
	mysql_query(" 
		SELECT template_id FROM cq_group_template 
		WHERE group_id='".$OldID."', 
		AND eff_end ='0000-00-00 00:00:00'",$dbConnection); 
} 
elseif(empty($OldID)) { 
	echo "empty";
	mysql_query(" 
		INSERT INTO cq_group SET 
		group_name = '". $groupName."' 
		",$dbConnection); 
} 
else{
	echo "else";	
	mysql_query("
		INSERT INTO cq_template SET
		template_name = '" . $templateName . "',
		template_owner = '" . $templateOwner . "'
	", $dbConnection);

}
$Template_id = mysql_insert_id($dbConnection);

foreach ( $UI_CoolData as $i_header => $header ){


mysql_query("
	INSERT INTO cq_cat_id SET
	cat_name = '" . $header['TEXT'] . "',
	cat_order = ' " . $i_header . "'
", $dbConnection);


$cat_id = mysql_insert_id($dbConnection);


mysql_query("
	INSERT INTO cq_template_id SET
	template_id = '" . $Template_id . "',
	cat_id = '" . $cat_id . "'
");


foreach ( $header['QUESTIONS'] as $i_question => $question ){


	mysql_query("
		INSERT INTO cq_ques_id SET
		ques_text = '" . $question['TEXT'] . "',
		ques_type = '" . $question['TYPE'] . "',
		ques_value = ' " . $question['VALUE'] . "',
		ques_order = '" . $i_question . "'
	", $dbConnection);


	$ques_id = mysql_insert_id($dbConnection);


	mysql_query("
		INSERT INTO cq_cat_ques SET
		cat_id = '" . $cat_id . "',
		ques_id = '" . $ques_id . "'
	");

}

}

mysql_close($dbConnection);

?>
<html>
	<body>
		The data was saved on database.
	</body>
</html>

DefunctExodus

Okay i am an idiot, I have figured out my problems for the most part.

The only issue i am having is this one.

if(isset($OldID)) { 
	echo "isset";
	mysql_query(" 
		SELECT template_id FROM cq_group_template 
		WHERE group_id='".$OldID."', 
		AND eff_end ='0000-00-00 00:00:00'",$dbConnection);




}

For some reason if the variable is set the script chokes. Which i can probaly work out however i need to add an UPDATE into thise part, Where it will update the eff_end to the current time where templat_id=template_id

How would i do this? I am really new to most of this and the time stamp part i have no idea about :/

bpat1434

if(isset($OldID))
{
    $query = "SELECT template_id
               FROM `cq_group_template`
               WHERE group_id='{$OldID}'
                 AND eff_end='0000-00-00 00:00:00'";
    $result = mysql_query($query) or die('MySQL Error: ' . mysql_error());
    while($row = mysql_fetch_array($result))
    {
        $query = "UPDATE `cq_group_template`
                  SET `eff_end` = NOW()
                  WHERE `template_id`=  '" . $row['template_id'] . "'";
        $result = mysql_query($query);
        if(!$result) { echo 'Failed updating template_id: ' . $row['template_id']; }
    }
}

Hope that helps...

DefunctExodus

Well that did it, I did not know that NOW() would do that.

Once again thank you for fixing my problem lol. You are awsome.. At least this time i figured out most of it lol.