[RESOLVED] hilight search results asp to php

[JBWebWorks]

i am new to php, moving from asp.
i need some help to convert asp code i have used for highlighting search results.

this is the asp code -

<%

Function HilightResults(sDataValue, sSearchString)
HilightResults = Replace(UCase(sDataValue), UCase(sSearchString), "<span style='color:red;'>" & UCase(sSearchString) & "</span>")
End Function

%>

<td><%=HilightResults((WADALABEL1.Fields.Item("Item_number").Value), Request("S_Item_number"))%></td>

thanks for your help
Jim Balthrop
JBWebWorks.com

[sfullman]

gotta admit php has more issues with case sensitivity here, this is one way

function HilightResults($sDataValue, $sSearchString){
preg_match_all('/'.$sDataValue.'/i', $sSearchString,$a);
if($a){
  for($i=0;$i<=count($a[0]);$i++){
     //these are exact strings, easy to replace
     $sSearchString=str_replace($a[0][$i],'<span style="color:red;">'.$a[0][$i].'</span>', $sSearchString);
  }
  return $sSearchString;
}else{
  return $sSearchString;
}
}

This is working with regular expressions (see php.net docs), and certain characters need to be escaped or will blow out the preg_match_all function.
If you have php5, look at the function str_ireplace

I used to program ASP and usually php could do things faster, here's one exception ;-)

Samuel

[JBWebWorks]

thanks Samuel

the function seems to work

but i get a fatal error on calling the function

trying this code to call the function

<?=HilightResults(($row_WADApr_parts['mfg_name'].$Value), Request("S_mfg_name")) ?>

[sfullman]

you'll need to read up on regular expressions. That may take some work to understand. Also looking at your code, are you thinking .$Value is component of

$row_WADApr_parts['mfg_name']

kind of like javascript? like this?

var x=document.getElementById('somefield').value;

PHP doesnt' work that way, maybe you mean

$row_WADApr_parts['mfg_name']

or

$row_WADApr_parts['mfg_name']['subelementkey']

but in any case you must make sure and escape with a backslash "at least" these characters:

. [ ] ( ) / * + and probably a few more

Welcome to PHP and once you get used to $ and ; and {} characters all over the place, you'll find it's a lot easier to identify variables and start and end of commands and I think PHP has mor functions to work with.

Samuel
Samuel

[Weedpacket]

The code sfullman wrote contains a bug: if $sDataValue appears three times with the same case in the search string, it
will be highlighted as

<span style="color:red;"><span style="color:red;"><span style="color:red;">...</span></span></span>

in all three places.

If you're using regular expressions, you might as well use them for the replacement as well as the search.

function HilightResults($sDataValue, $sSearchString)
{
	return preg_replace('/'.preg_quote($sDataValue).'/i',
		'<span style="color:red">$0</span>',
		$sSearchString);
}

And since it appears from the original code that the highlighted string should be uppercased as well:

function HighlightResults_transform($match)
{
	return '<span style="color:red">'.strtoupper($match[0]).'</span>';
}
function HilightResults($sDataValue, $sSearchString)
{
	return preg_replace_callback('/'.preg_quote($sDataValue).'/',
		'HighlightResults_transform',
		$sSearchString);
}

Or, better yet,

function HilightResults($sDataValue, $sSearchString)
{
	return preg_replace(
		'/'.preg_quote($sDataValue).'/i',
		'<span style="color:red; text-transform:uppercase;">$0</span>',
		$sSearchString);
}

Which, since there isn't any need to uppercase the matched string any more, there isn't actually any need for regular expressions:

function HilightResults($sDataValue, $sSearchString)
{
	return str_ireplace(
		$sDataValue,
		'<span style="color:red; text-transform:uppercase;">'.$sDataValue.'</span>',
		$sSearchString);
}

[JBWebWorks]

//i now have the following code

//function code
<?php

function highlightResults($dataValue, $searchString) {str_replace(strtoupper($dataValue), strtoupper($searchString), '<span style="color:red;">'.strtoupper($searchString).'</span>');
}
?>

//call the function code (i have 3 search text boxes and the results has 4 columns)
//i am only testing 1 column call function code

        <td class="WADAResultsTableCell"><?php echo highlightResults($row_WADApr_parts['mfg_name'].$Value),$_GET['S_mfg_name']; ?></td>

//when the search executes the results page posts the correct columns and the correct rows but i get this error posted in every row under the 'mfg_name' column

Warning: Missing argument 2 for highlightResults(), called in C:\wamp\www\bellchemicalservice\pr_parts_Results.php on line 377 and defined in C:\wamp\www\bellchemicalservice\pr_parts_Results.php on line 6

thanks for your help

[Weedpacket]

Like the error message says, the function is expecting two arguments, but it's not getting the second one.

....$Value),$_GET['S_mfg_name']

should be

....$Value, $_GET['S_mfg_name'])

And you might have the order back to front. str_replace() takes the string being searched for as it's first argument, the replacement string as its second, and the string to be search as its third. It's been so many years since I've had to deal with VBScript I forget what order its function uses.

[JBWebWorks]

thanks for your help

still not quite right - here is what i have now

//function code
<?php
function highlightResults($sDataValue, $sSearchString) {
return str_replace(strtoupper($sDataValue), strtoupper($sSearchString), '<span style="color:red;">'.strtoupper($sSearchString).'</span>');
}
?>

//call function highlightResults
<td class="WADAResultsTableCell"><?php echo highlightResults($row_WADpr_part["mfg_name"],stripslashes ($_GET["S_mfg_name"])); ?>

It now returns the input of the search text field highlighted in red, but it does not return all of the data in the 'mfg_name' column.
and when you search with any of the other search text fields, the return for column 'mfg_name' is '-1'

you can see this at
http://www.bellchemicalservice.com/homepage/service_searchparts.php
advance is the name of a manufacturer, so put in 'adva' in the MANUFACTURER box and see the return (i want it to return 'ADVANCE' in the manufacturer column with 'ADVA' highlighted in red).
do a new search and put in 'buffer' in the MACHINE TYPE box and see the '-1' return in the manufacturer column.

[Weedpacket]

As I've already said:

Weedpacket wrote:

And you might have the order back to front. str_replace() takes the string being searched for as it's first argument, the replacement string as its second, and the string to be search as its third. It's been so many years since I've had to deal with VBScript I forget what order its function uses.

I guess that teaches me (not for the first time) the hazards of saying two things in one post.

[JBWebWorks]

thanks for your help; it pointed me in the right direction

here is what i ended up with that works

<?php
//used this as the function

function highlightResults($dataValue, $searchString) {
return strtoupper(preg_replace("/$searchString/i", '<span
style="color:red;">'.strtoupper($searchString).'</span>', $dataValue));
}

//and this is the call function
<?php echo highlightResults($row_WADpr_part["mfg_name"], 
stripslashes($_GET["S_mfg_name"])); ?>

i have multiple search text boxes so i have additional call function lines and change the ($_GET["to match the search box name"]

the search results highlight the searchstring in red and CAPS and puts all datavalue in CAPS