Script works in PHP4 not in PHP5 - Variable problems

Waves

I've been looking around for this problem for a while...I'm stumped.
I have a small script which is working on my PHP4 server but the variables don't pass on the PHP5 installation.

On the PHP5 installation I do have Global Variables turned on.

Both installs are PHP running on IIS6 Win 2K3

The output portion of the script is:

echo " Now Playing: $text[6]";?>

Displays to:
Now Playing: $text[6] ";?>

Here's some of my phpInfo

realpath_cache_ttl 120 120
register_argc_argv On On
register_globals On On
register_long_arrays On On
report_memleaks On On
report_zend_debug On On

Is there something in the PHP.ini file which I need to turn on to pass this variable?
Any help would be appeciated.
S

bradgrafelman

Waves wrote:
On the PHP5 installation I do have Global Variables turned on.

Which is a very bad thing; you should disable it immediately.

The proper way to fix your script is to use the superglobal arrays (ex. $POST, $GET, etc.) instead of relying on register_globals which was long ago deprecated due to possible security exploits.

Waves

Thanks
This server isn't exposed to the internet yet I'll turn all that back off before I do.

Could you give me an idea as to what the syntax would look like in for the following line with that change?

From This:
echo " Now Playing: $text[6]";?>

To perhaps this?
echo " Now Playing: $_POST [$text[6]]";?>

THanks

bradgrafelman

Well I'd have to see your form, but all you do is use the name of the form element as the array index of $_POST.

I don't know where the [6] is coming from - did you create an array of elements (e.g. by appending '[]' to the end of their name in the HTML code)? If so, then you can treat that element as an array in PHP, ex. $_POST['text'][6].

Waves

This isn't my script, its something which I got from another site which provides it for free.
I've hack and slashed it into my site code to provide now playing info for an online radio station.
I only know enough PHP to dangerous.
Any assistance you can provide will be appreciated.
Here's the code in its entirety.

<?
$open = fsockopen("127.0.0.1","8000");
if ($open) {
fputs($open,"GET /7.html HTTP/1.1\nUser-Agent:Mozilla\n\n");
$read = fread($open,1000);
$text = explode("content-type:text/html",$read);
$text = explode(",",$text[1]);
} else { $er="Connection Refused!"; }
?>
</div>
<?
if ($text[1]==1) { $state = "Up"; } else { $state = "Down"; }
if ($er) { echo $er; exit; }
echo "
Now Playing: $text[6]";
?>
So...
$open = fsockopen("127.0.0.1","8000");

then changes to
$_GET['open'] = fsockopen("127.0.0.1","8000");
Or am I totally off here?
Thanks for the help.

bradgrafelman

Ah, it's not a form at all. You can read up on the superglobals on the manual page [man]variables.predefined[/man].

What you're doing here is retrieving a page from a URL and then parsing it for data. A much easier way to do this would be:

<?php
$text = explode(',', file_get_contents('http://localhost:8000/7.html');

Note that I used the full '<?php' tag - short tags have long ago been deprecated and are disabled by default. I've also utilized the [man]file_get_contents/man function instead of the lengthy fsockopen/fputs/fread process.

Waves

Thanks for your help you've pointed me in the right direction and I'll do some more reading.
I'll keep ya posted.
Cheers