Alternating row colors problem

webweever

I have this code:

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$sql="SELECT * FROM $tbl_name ORDER BY cat ASC";
$result=mysql_query($sql);

$count=mysql_num_rows($result);

?>
<table width="500" border="0" cellspacing="0" cellpadding="0" align="center">
<tr>
<td><form name="form1" method="post" action="">
<table width="500" border="1" cellpadding="2" cellspacing="0" bgcolor="#CCCCCC" align="center">
<tr>
<td bgcolor="#FFFFFF" width="30"><font face='verdana'><font size='2'><strong>Delete</strong></td>
<td bgcolor="#FFFFFF"><font face='verdana'><font size='2'><strong>URL</strong></td>
<td bgcolor="#FFFFFF" width="50"><font face='verdana'><font size='2'><strong>Category</strong></td>
</tr>
<?php
while($rows=mysql_fetch_array($result)){
?>
<tr>
<td align="center" bgcolor="#FFFFFF" width="30"><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td>
<td bgcolor="#FFFFFF"><font face='verdana'><font size='1'><a target="_blank" href="<?php echo $rows['url']; ?>"><?php echo $rows['name']; ?></a> 
<td bgcolor="#FFFFFF" width="50"><font face='verdana'><font size='1'><? echo $rows['cat']; ?></td>
</td>
</tr>
<?php
}
?>
<tr>
<td colspan="5" align="center" bgcolor="#FFFFFF"><input name="delete" type="submit" id="delete" value="Delete"></td>
</tr>
<?
// Check if delete button active, start this 
if($delete){
for($i=0;$i<$count;$i++){
$del_id = $checkbox[$i];
$sql = "DELETE FROM $tbl_name WHERE id='$del_id'";
$result = mysql_query($sql);
}

// if successful redirect to delete_multiple.php 
if($result){
echo "<meta http-equiv=\"refresh\" content=\"0;URL=index.php\">";
}
}
mysql_close();
?>

I'm trying to integrate this code that alternates the colors:

<?php

// Displays alternate table row colors
function row_color($i){
$bg1 = "#cccccc"; // color one 
$bg2 = "#ffffff"; // color two

if ( $i%2 ) {
return $bg1;
} else {
return $bg2;
}
}

//DB connection 
$connection = mysql_connect("localhost","userName","password"); 
$db = mysql_select_db("databaseName"); 

$sql = "select * from tbl_name"; // Database Query 
$result = mysql_query("$sql"); // Database Query result

// Starts the table
echo "<table bgcolor=#FFFFFF border=0 cellpadding=1 cellspacing=1>\n";

// Create the contents of the table.
for( $i = 0; $i < $row = mysql_fetch_array($result); $i++){
echo "<TR>\n"
."<TD bgcolor=".row_color($i).">".$row["name"]."</TD>\n"
."<TD bgcolor=".row_color($i).">".$row["url"]."</TD>\n"
."<TD bgcolor=".row_color($i).">".$row["cat"]."</TD>\n" 
."</TR>";
}
echo "</TABLE>"
?>

I've tried every way but the right way to do this apparently. The alternating code works I just can't figure out how to get it in my other file. Can some help please?

roscor

  <?
$i=0;

while ($row = mysql_fetch_array($result)) {
if($i % 2)
{
$bg_color = '#FFFFFF';
}
else
{
$bg_color = '#EEEEEE';
}


$whatever = $row["whatever"];
$soever = $row["soever"];
?>

<td><? echo "<td width='50%' align='center' bgcolor=$bg_color><font face='Verdana' size='2' color='#000000'>$whatever"; ?></td>
  <td><? echo "<td width='50%' bgcolor=$bg_color align='center'><font face='Verdana' size='2' color='#000000'>$soever</td>"; ?></td>

<?
$i++;
}


echo "</table>";

?>

you had your background colours in html you needed to echo them out using PHP

webweever

I could not get the code above to work. I played around with it and tried this:

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$sql="SELECT * FROM $tbl_name ORDER BY cat ASC";
$result=mysql_query($sql);

$count=mysql_num_rows($result);

?>
<table width="500" border="0" cellspacing="0" cellpadding="0" align="center">
<tr>
<td><form name="form1" method="post" action="">
<table width="500" border="1" cellpadding="2" cellspacing="0" bgcolor="#CCCCCC" align="center">
<tr>
<td bgcolor="#FFFFFF" width="30"><font face='verdana'><font size='2'><strong>Delete</strong></td>
<td bgcolor="#FFFFFF"><font face='verdana'><font size='2'><strong>URL</strong></td>
<td bgcolor="#FFFFFF" width="50"><font face='verdana'><font size='2'><strong>Category</strong></td>
</tr>
<?php
$i=0;

while($rows=mysql_fetch_array($result)){
if($i % 2)
{
$bg_color = '#FFFFFF';
}
else
{
$bg_color = '#EEEEEE';
}


$name = $row["name"];
$url = $row["url"];
$cat = $row["cat"];
?>
<tr>
<td align="center" bgcolor="#FFFFFF" width="30" bgcolor="$bg_color"><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td>
<td bgcolor="#FFFFFF"><font face='verdana' bgcolor="$bg_color"><font size='1'><a target="_blank" href="<?php echo $rows['url']; ?>"><?php echo $rows['name']; ?></a> 
<td bgcolor="#FFFFFF" width="50"><font face='verdana' bgcolor="$bg_color"><font size='1'><? echo $rows['cat']; ?></td>
</td>
</tr>

<?
$i++;
}


echo "</table>";

?>
<?php
//}
?>
<tr>
<td colspan="5" align="center" bgcolor="#FFFFFF"><input name="delete" type="submit" id="delete" value="Delete"></td>
</tr>
<?
// Check if delete button active, start this 
if($delete){
for($i=0;$i<$count;$i++){
$del_id = $checkbox[$i];
$sql = "DELETE FROM $tbl_name WHERE id='$del_id'";
$result = mysql_query($sql);
}

// if successful redirect to delete_multiple.php 
if($result){
echo "<meta http-equiv=\"refresh\" content=\"0;URL=index.php\">";
}
}
mysql_close();
?>

That didnt work either, any ideas?

webweever

Can anyone help with this? I'm about to dropkick this computer.

Weedpacket

Use CSS to do your styling.

Not only has the <font> element and bgcolor= attribute (ditto for align= and width=) been deprecated for a decade now, <font> never even had a bgcolor= attribute.

pdominguez

the problem is your if statement

if($i % 2)

replace in your code: if($i % 2) by this if($i % 2 == 0) and it will work

you are saying the following:

if variable i divided by 2 and it returns a remainder, any number 'cause you didnt specify then do the first color. the value of i can be anything odd or even and it will still give a remeinder and it will go to the first number.

what you ARE TRIYING TO DO IS THE FOLLOWING:

if variable i divided by 2 returns a '0' then if is odd picks the second color instead of the first

replace in your code: if($i % 2) by this if($i % 2 == 0) and it will work

suntra

You actually need fewer lines to do that... my method is the following...

$intC = 0;
$arrColors    = array('ff0000', '00ff00');
while(condition) { // condition should be in italic...
    $strColor = '#' . $arrColors[$intC++ % 2] . '<br />';
}