[RESOLVED] Reposting a GET Variable

rawky1976

Hello all, I'm having a problem with the code below. The variable recno is getting its contents from a GET on a previous page. Everything works fine except this is a 'Confirm Delete' page. So when the form is submitted the page reloads and of course the data isn't GET'd anymore and the variable is empty so the DELETE doesn't actually delete anything.

I've overcome this with the elseif (isset($_POST.... so that recno is populated on reload. I've used a hidden field in the form that contains the value of recno.

Is my syntax incorrect or is my whole idea wrong?

<?php
include 'library/config.php';
include 'library/opendb.php';

// check if rec no is set or not...
if (isset($_GET['recno'])) 
{
//$recno = (int) $_GET['recno'];
$recno = $_GET['recno'];			         

} elseif (isset($_POST['recno'])){
  $recno = $_POST['recno'];
}

// from here you are trying to delete the record...

if (isset($_POST['submitted']))
{
$query = "DELETE FROM knowledgebase.document WHERE document_id='$recno'";
$result = mysql_query($query) or die(mysql_error());
echo 'The record was sucessfully removed';
include ('./library/cpfooter.html');
exit();
}

//query 
$query_sel = "select * from document WHERE document_id = '$recno'"; 
$result_sel = mysql_query($query_sel) or die(mysql_error()); 

// if result found
if ($result_sel) 
{
$r = mysql_fetch_array($result_sel);
$dn = $r['document_name'];
} 


?>

<form action="confirmdelete.php" method="post">
<fieldset><legend>Confirm Record Deletion</legend>
<p>Are you sure you wish to remove the record for the document: -<br />
<?php echo "$dn"; ?><br /><br />
<input type="submit" value="Yes Delete Record"><input type="hidden" name="submitted" value="TRUE" /><input type="hidden" name="recno" value="$recno">
</fieldset>
</form>

cahva

Yes you have couple of errors there.. First edit the deletion bit to this:

if (isset($_POST['submitted']) && !empty($_POST['recno']))
{
	$recno = mysql_real_escape_string($_POST['recno']);
	$query = "DELETE FROM knowledgebase.document WHERE document_id='$recno'";
	mysql_query($query);
	echo 'The record was sucessfully removed';
	include ('./library/cpfooter.html');
	exit();
}

You can move that bit right after the first includes.

You dont need the elseif here because you dont use the $POST['recno'] variable anymore(its used now in that last one). Just:

if (isset($_GET['recno'])) 
{
    $recno = intval($_GET['recno']); // you can use the intval here
}

Fix this next line. You have forgotten to actually print the $recno:

<input type="submit" value="Yes Delete Record"><input type="hidden" name="submitted" value="TRUE" /><input type="hidden" name="recno" value="<?php echo $recno ?>">

rawky1976

You are the man! (or woman)!!

Thank you, it's been driving me mad.

cahva

Im more like a ladies man 😉