Foreach loop error

[SFDonovan]

I have a page displaying around 103 records. Each record is a student record that contains a unique ID called SOMS_KEY. I am adding a grade for each student.

The form where I can enter in all grades:

$studentYearlist = $db->sql_query("SELECT * FROM atlas_tl_students WHERE Class_Year = $Course_Year");
while ($row = $db->sql_fetchrow($studentYearlist)) {
		$SOMS_KEY = $row['SOMS_KEY'];
		$Name_First = $row['Name_First'];
		$Name_Last = $row['Name_Last'];	

	if (!$studentYearlist) {
	echo("<p>Error performing query: " . mysql_error() . "</p>");
	exit();   
	}	

  //<!-- BEGIN Student Row -->"
   echo "<tr><td align=\"center\">$SOMS_KEY</td>"  

  . " <td align=\"left\">$Name_First $Name_Last</td>"
  . " <td><input type='text' name='add_irat_gr[]' size='3' maxlength='3'></td>"  

  . "</tr>";  

  }
  //-- END Student Row -->" 

The very last record I pull with this query is SOMS_KEY = 407

I action for this form sends to to a page to insert all these values. The problem is the value 407 is being entered for all 100 records I have. However each student has their own unique SOMS_KEY.

Here is the code I have to INSERT:

$add_irat_gr_value= $_POST['add_irat_gr'];
$SOMS_KEY = $_POST['SOMS_KEY'];
$Session_ID = $_POST['Session_ID'];
$grade_type = 'IRAT'; 

//Go get the academic year value from config table	
	$GetYear = $db->sql_fetchrow($db->sql_query("SELECT Academic_Year from ".$prefix."_tl_config"));
if (!$GetYear) {
echo("<p>Error performing query: " . mysql_error() . "</p>");
		exit();   

		}	
$Academic_Year = $GetYear['Academic_Year']; 


/* Do the for each statement */

foreach ($add_irat_gr_value as $add_irat_gr) {

$sql = "INSERT INTO ".$prefix."_tl_session_grades (SOMS_KEY, Session_ID, grade, grade_type, Academic_Year)". "VALUES ('$SOMS_KEY','$Session_ID','$add_irat_gr','$grade_type', '$Academic_Year')";
if (!$sql) {echo("<p>Error performing query: " . mysql_error() . "</p>");}
	$result = $db->sql_query($sql);	              

    }

Where have I gone wrong? I just can't see it.

I have the text box as an array. Is this correct?

type='text' name='add_irat_gr[]'

This value needs to pair up with each individual SOMS_KEY for each student.

[PartDigital]

If you're trying to get two Values in your form it's best to use two different form elements.

For instance,

  //<!-- BEGIN Student Row -->"
   echo "<tr><td align=\"center\">$SOMS_KEY</td>";

  echo" <td align=\"left\">$Name_First $Name_Last</td>";

  //You put your first name (setting it as an array is correct)
   //I added the value attribute to display the name (I'm not sure if this is what you were looking for.
  echo "<td><input type='text' name='add_irat_gr[]' value = '$Name_First' size='3' maxlength='3'></td>";  

//I then added a hidden field element to hold your id
echo "<input type = 'hidden' name = 'SOMS_key[]' value = '$SOMS_key' />";

echo "</tr>";  

  //-- END Student Row -->" 

so any time you access the post['SOMS_key'] variable is should grab the appropriate id.
take note however that $_POST['SOMS_key'] is an array so you will have to loop through it to get the id.

ex:

for($i=0; $i<count($_POST['SOMS_key']); $i++)
{
    $the_id_you_want = $_POST['SOMS_key'][$i]; 
}

same applies for the name

for($i=0; $i<count($_POS['add_irat_gr']); $i++)
{
    $the_id_you_want = $_POST['add_irat_gr'][$i]; 
}

hope this was helpful

[matto]

$SOMS_KEY = $_POST['SOMS_KEY']; 

where does SOMS_KEY appear in your form? it can't come from there.

furthermore you are iterating using foreach over the add_irat_gr array (that part is correct). but if you do this, you can't iterate over SOMS_KEY at the same time, even if it were in the POST array.

option 1:
you pack the SOMS_KEY into the add_irat_gr

...<input type='text' name='add_irat_gr[".$SOMS_KEY."]' size='3' maxlength='3'>...

then you iterate like this:

foreach ($add_irat_gr_value as $soms_key => $add_irat_gr)

... and you got your soms_key because it was handed over as the array element's key

option 2:
you hand over a hidden input

...<input type='hidden' name='soms_keys[]' value='".$SOMS_KEY."' />...

in analogy to the add_irat_gr[]

then you iterate using a counter

$i=0;
while(isset($_REQUEST['add_irat_gr'][$i]))
{
// address the add_irat_gr value with $_REQUEST['add_irat_gr'][$i]
// address the soms_key value with $_REQUEST['soms_keys'][$i]

$i++;
}

the first alternative is somewhat cleaner.

[SFDonovan]

Outstanding help guys! I agree option one looks cleaner.

I don't quite understand this:

 <input type='text' name='add_irat_gr[".$SOMS_KEY."]' size='3' maxlength='3'> 

I don't want them able to input anything for the SOMS_KEY on the form as this is pulled from the database.

Should this be some sort of hidden field?

[bradgrafelman]

What exactly is this SOMS_KEY? If it's supposed to be a unique number for each row, it sounds like it should be an AUTO_INCREMENT column with a PRIMARY UNIQUE key, in which case you don't even need to worry about it at all - leave it out of your INSERT queries.

[SFDonovan]

It is unique but not auto-incremented as I pull it from the main system being built for the Medical School. It is the primary key for all grades assigned to a student.