[RESOLVED] Trying to redirect with several variables included

[billteale]

Hi all,

I am still struggling through learning php, and I would really appreciate any pointers on how to get this page to redirect.

This is the full page (no headers or anything else are included). I am sure it is something simple, but I can't get it to work, I keep getting an "unexpected T_ECHO" in the redirect line.

I know that I shouldn't be using a relative url, but there is a reason for that, this page is destined to be on a dynamic cd rather than online (using the Outsite-In software).

<?php $GET[P1SQ]; ?>
<?php $GET[P2SQ]; ?>
<?php
$ran1 = Rand (1,6);
$square = $GET[P2SQ] + $ran1;
?>
<?php
function randomDriver() {
// taken from internet to get random text placing
$drivers = array(
0 => 'free',
1 => 'snake',
2 => 'ladder',
3 => 'question',
4 => 'question',
5 => 'question',
6 => 'question',
7 => 'question',
8 => 'question',
9 => 'ladder',
10 => 'ladder',
11 => 'snake',
12 => 'snake',
13 => 'free',
14 => 'free',
15 => 'free',
16 => 'free',
17 => 'question',
18 => 'question',
19 => 'question',
20 => 'question',
21 => 'snake',
22 => 'ladder',
23 => 'free',
24 => 'free');
srand ((double) microtime() * 1000000);
$random_number = rand(0,count($drivers)-1);
$driver = ($drivers[$random_number]);
return $driver;
// end extracted script
?>
<?php
header('location: P2.php?ROLL=' echo $ran1 '&P2SQ=' echo $square '&P1SQ=' echo $GET[P1SQ] '&TYPE=' echo $driver);
?>

[rsmith]

<?
     header("location: P2.php?ROLL=".$ran1."&P2SQ=".$square."&P1SQ=".$_GET[P1SQ]."&TYPE=".$driver."");
?>

[bradgrafelman]

As you can see from rsmith's code snippet, you don't need [man]echo/man. Echo is used to output data to the user, whereas all you're trying to do is join several different strings together. This is called concatenation and is done with a period as shown above.

Also, if you have many variables to pass, you could also consider using a session to store data from page to page.

[billteale]

Thank you! I really appreciate the help!

I am getting a different error now, after I made the change suggested, I know it is something I did wrong, but I am not sure what! Here is the code as is stands, the error I am getting is

Parse error: parse error, unexpected $ in /hsphere/local/home/jdixon/pressakey.net/snakes/p2roll.php on line 44

(line 44 is the final line, so I presume I havenot finished something off properly)

<?php $GET[P1SQ]; ?>
<?php $GET[P2SQ]; ?>
<?php
$ran1 = Rand (1,6);
$square = $GET[P2SQ] + $ran1;
?>
<?php
function randomDriver() {
// taken from internet to get random text placing
$drivers = array(
0 => 'free',
1 => 'snake',
2 => 'ladder',
3 => 'question',
4 => 'question',
5 => 'question',
6 => 'question',
7 => 'question',
8 => 'question',
9 => 'ladder',
10 => 'ladder',
11 => 'snake',
12 => 'snake',
13 => 'free',
14 => 'free',
15 => 'free',
16 => 'free',
17 => 'question',
18 => 'question',
19 => 'question',
20 => 'question',
21 => 'snake',
22 => 'ladder',
23 => 'free',
24 => 'free');
srand ((double) microtime() * 1000000);
$random_number = rand(0,count($drivers)-1);
$driver = ($drivers[$random_number]);
return $driver;
// end extracted script
?>
<?
header("location: P2.php?ROLL=".$ran1."&P2SQ=".$square."&P1SQ=".$GET[P1SQ]."&TYPE=".$driver."");
?>

I looked into session variables, and I am still learning about them. This script is the bones of a chutes and ladders game I am working on for two people, and the variables change after every turn, a session variable is more of a static site wide variable yes?

Once again, thanks for your help!

[rsmith]

First off you don't need to open and close your <?php ?> tags so often -- you had opened a new call before you're function declaration but never closed it and instead opened another set to do the header redirect. Secondly, please use the builtin php and code tags to highlight the syntax and formatting of your scripts (helps us out while we try to help you). Your code should be this:

<?php 

 $_GET[P1SQ];
 $_GET[P2SQ];

 $ran1 = Rand (1,6);
 $square = $_GET[P2SQ] + $ran1;

function randomDriver() {
// taken from internet to get random text placing
$drivers = array(
0 => 'free',
1 => 'snake',
2 => 'ladder',
3 => 'question',
4 => 'question',
5 => 'question',
6 => 'question',
7 => 'question',
8 => 'question',
9 => 'ladder',
10 => 'ladder',
11 => 'snake',
12 => 'snake',
13 => 'free',
14 => 'free',
15 => 'free',
16 => 'free',
17 => 'question',
18 => 'question',
19 => 'question',
20 => 'question',
21 => 'snake',
22 => 'ladder',
23 => 'free',
24 => 'free');
srand ((double) microtime() * 1000000);
$random_number = rand(0,count($drivers)-1);
$driver = ($drivers[$random_number]);
return $driver;
// end extracted script

header("location: P2.php?ROLL=".$ran1."&P2SQ=".$square."&P1SQ=".$_GET[P1SQ]."&TYPE=".$driver."");

?>

[bradgrafelman]

Also note that this:

<?php $_GET[P1SQ]; ?>
<?php $_GET[P2SQ]; ?>

does absolutely nothing, except generate error messages due to improper syntax. Array indeces, in your case, are strings. Strings are delimited by either single or double quotes. Without any quotes, you're telling PHP that your array index is a [man]constant[/man], which causes error messages.

Using srand is unnecessary and should be removed. In fact, you could condense this:

srand ((double) microtime() * 1000000);
$random_number = rand(0,count($drivers)-1);
$driver = ($drivers[$random_number]);
return $driver;

to this:

return $drivers[rand(0,count($drivers)-1];

Also, note that there is still a missing '}' in the code snippet rsmith posted above; you didn't close the function declaration.

[rsmith]

Ah good catch brad. I missed that one.

[billteale]

Thanks rsmith and brad - this has been tremendously helpful, and I have learnt a lot!

I have implemented everything you guys have suggested, and it works perfectly.

you guys are great!

Bill.

[billteale]

Hi guys,

I am am=lmost there, I have just one more related question. my apologies if I should have put it in a new thread.

I want to add a piece of coding that will check the value one of the variables I pass from page to page (namely P1SQ). If the variable has gone to zero or below, then i want to set it to the value of 1, and continue to load the current page. If the value is 50 or higher, I want it to move to a different page (winner.php).

Would I do this using if and else?

This is what I came up with, but of course I have come up short, smiles!

<?php
$GET['P1SQ'];
$GET['P2SQ'];

// If P1SQ = zero or less
if ( $_GET['P1SQ'] <= 0) {

	$_GET['P1SQ'] = 1

// If P1SQ = 50 or more
elseif ( $_GET['P1SQ'] => 50) {

	header("location: p1winner.php");

}
}
?>

Thanks for any asistance you can give me!

[bradgrafelman]

You're only doing two things wrong: 1) the closing '}' for the first if() statement goes before the elseif() part, and 2) the "greater than or equal to" operator is >=, not =>.

[billteale]

Thanks to everyone who has helped me with this, I have really learnt a lot, and this forum really rocks! smiles!

I have a beta version of the game online if anybody would like to try it and comment (no inidex or winners page at time of writing, or pretty graphics for the sighted users, just the basic bare guts of the game).

Also, as an aside, for those who might be interested, the techies at real networks told me that they knew of no way of writing a .ram file (that's the text file that controls a streamed audio source) on the fly. I've learnt through this experiment that it is actually possible, and works really well, using php.

http://pressakey.net/snakes/p1.php?P2SQ=1&P1SQ=1

Once again, thanks for your help! I will set the message to resolved after I post this.

Bill.