disappearing variables trauma!

ginadas

Hi all,

I was hoping someone coulding she a bit of light on some strangely disappearing variables!
I am using php to recieved and process uploaded files into local folders for a dynamic gallery site. the picture information & categorisation, i intend to store in a mysql database and i'm using flex from my front end - which will process xml generated by php to sort out various albums.

my first approach was to try and create seperate folders for each album upload. here is the script:

<?php

mkdir("program_code/" . $REQUEST['albumname'] . "/");
$target_path = "root/program_code/" . $REQUEST['albumname'];
//$target_path = $target_path
$target_path = $target_path . "/";
$target_path = $target_path . basename( $_FILES['Filedata']['name']);

move_uploaded_file($_FILES['Filedata']['tmp_name'], $target_path);

the $_REQUEST['username'] passes in successfully my problem is - the files save in the program_code/ directory, not the newly created directory from the albumname variable - it's like php chooses to ignore it. i understand move_uploaded_file on windows acts on the root directory, so i tried putting in a literal path like root/program_code/pics whilst passing in pics as a request parameter - surely enough, the folder is created and images upload to the pic directory - php just refusess to see it or process it in time when passed in as a reuest parameter for the move_uploaded_file method

so i tried a different approach - creating unique hashed filenames for each uploaded file and storing the names into a newly created mysql table which takes the albumname request parameter as it's name. here is the code:

<?php

include("config.inc.php");

$uploaddir = "images/";
$file = $_FILES['Filedata'];
$name = sha1_file($file['tmp_name']);
$pathInfo = pathinfo($file['name']);
$name .= '.'.$pathInfo['extension'];

move_uploaded_file($file['tmp_name'], $uploaddir.$name);

$q = <<<CREATE
create table $_REQUEST[username](
photo_id bigint(20) unsigned NOT NULL auto_increment,
photo_filename varchar(80),
photo_category bigint(20) unsigned NOT NULL default '0',
PRIMARY KEY (photo_id),
KEY photo_id (photo_id)
) TYPE=MyISAM;
CREATE;
mysql_query($q);

$nam = sha1_file($file['tmp_name']);

$p = <<<CREATE
insert into $_REQUEST[username] (photo_filename) values ("$name");
CREATE;

mysql_query($p);
?>

the files save with long and unique filenames (eg image8b6f73f2b35b997af7633116bf8f46ab026e0c8d.jpg) - but when i pass the name variable into mysql - it merely saves as "." - it's wildly infuriating! because i know the variable is there but it simply will not carry thought/transmit into the mysql table!

so i'm truly stuck now...! if any of you php gurus can help out with what i'm sure is embarrasingly obvious i'd be so thankful, needless to say, i've clumsily googled this to death to no avail

cheers,

gina

ps - my config is using WAMP server on a win xp machine

mark_kccs

Hi Ginadas

Have you checked the file permissions of your newly created folder? A quick test would be to add this line after mkdir;

mkdir("program_code/" . $REQUEST['albumname'] . "/");
chmod("program_code/" . $REQUEST['albumname'] . "/", 0777);

and see if this works, if so you need to set these. DO NOT leave the file with these permissions as it is wide open!

Hope this helps

ginadas

hi mark,

cheers for the reply but i'm afraid i already tried that, and just retried for posterity, and the darn files are still saving on the program_code directory - it's as if the $_REQUEST['username'] disappears and doesnt concatenate - but i know its there because the directory i create with it goes ahead and gets created

any ideas? do i need to look at my php.ini settings??

mark_kccs

I have just tried the following and all worked fine, so give this a try.

<?php
if (isset($_POST['Submit']) && ($_POST['Submit'] == "Submit")) {
$album_id = "test";
mkdir("pics/" . $album_id);
$target_path = "pics/" . $album_id . "/" . basename( $_FILES['file']['name']);
move_uploaded_file($_FILES['file']['tmp_name'], $target_path);
}
?>

<html>
<head>
</head>
<body>
<form action="add_dir.php" method="post" enctype="multipart/form-data" name="form1">
<input type="file" name="file">
<input type="submit" name="Submit" value="Submit">
</form>
</body>
</html>

ginadas

hey mark,

thanks for writing and testing some code for me, thats very kind, however, my issue is that i want to pass in a value through the request variable, and it is that bit that is getting lost - if i include the name as a string in the code it is okay - but i want the functionality of being able to create and name a folder and upload images into it - and its getting the images into the created folder (which creates fine using the request variable) - that i'm having the problem with, the request vaiable doesnt seem to read when i use it to create my target path

can one not access the request variable again? does it get cleared or something?

thanks fr your help 🙂

mark_kccs

Try

echo $var = $_REQUEST['albumname'];
exit(); // if need

and see what you get. I prefer to use $GET or $POST of which the later is better as this is not passed in the URL. Again I assume your form is correct on the sending page?

rsmith

Yeah I wouldn't use $_REQUEST for security reasons.