[RESOLVED] define within while

Desbrina

I have this code for setting how many images appear per line. Its fine for the first set out, but any after it stay the same

$i = 0;  

		while ($row = mysql_fetch_array($sql1)) {
		if (($row['type'] == "puzzle") and $row['amount'] == 15)
   			define('CARDS_PER_ROW', 3);
		elseif ($row['amount'] == 5 || $row['amount'] == 10 || $row['amount'] == 15 || $row['amount'] == 20 || $row['amount'] == 25)
   			define('CARDS_PER_ROW', 5);
		elseif ($row['amount'] == 4)
   			define('CARDS_PER_ROW', 4);		
			echo "<img src=\"{$row['url']}\" alt=\"{$row['alttext']}\" /> " ; 
			if (++$i % CARDS_PER_ROW == 0)
       		echo '<br />';
		}
	}

Take for example this page
http://www.darknesswithin.com.ru/users/user.php?user=Obi-Wan
Layout 1 appears fine, since theres 4 cards, but quigon doesn't. Theres 20 cards so it should be 5 per row

I'm not sure why its doing this, can anyone help

NogDog

You cannot change the value of a constant once it is defined. (That is why it's called a "constant"). You will need to use variables instead of constants if you want the values to vary with each loop iteration.

Desbrina

thanks, i've now got another problem, for some reason when switching from 4 to 5 per row, i end up with 4, 1 ,5

this is the new code

		while ($row = mysql_fetch_array($sql1)) {
		if (($row['type'] == "puzzle") and $row['amount'] == 15)
   			$perrow = 3;
		elseif ($row['amount'] == 5 || $row['amount'] == 10 || $row['amount'] == 15 || $row['amount'] == 20 || $row['amount'] == 25)
   			$perrow = 5;
		elseif ($row['amount'] == 4)
   			$perrow = 4;
			echo "<img src=\"{$row['url']}\" alt=\"{$row['alttext']}\" /> " ; 
			print $perrow;
			if (++$i % $perrow == 0)
       		echo '<br />';
		}

laserlight

I am not sure why you wrote the code the way you did, but a simple way of doing it (generalising without accounting for $row['type']) would be:

for ($i = 1; $row = mysql_fetch_array($sql1); ++$i) {
    echo '<img src="' . htmlspecialchars($row['url'])
       . '" alt="' . htmlspecialchars($row['alttext']) . '" />';

if ($i % 4 == 0) {
    echo '<br />';
}
}

The idea is that when $i is divisible by 4, it is time to go to the next row so you print a break. You can incorporate your check for $row['type'], of course, but it looked like you were listing such specific checks that perhaps you did not realise how the generalisation could work.

Desbrina

they way i did it is because the amount in the row isn't always the same, sometimes its 4, sometimes its 5/10, if its 15 and a puzzle then it needs to be 3

i think i actually have it working (wont say will, as i'm sure something else somewhere will stop working)