[RESOLVED] Simple PHP authentication

rey00002

I'm very new to PHP and coding in general and am having trouble getting authentication to work with two different sites. This leads me to believe something is wrong with php.ini?

My first site is from godaddy.com
I have linux hosting.
php.ini is automatically included at the / directory
here it is:

register_globals = off
allow_url_fopen = off

expose_php = Off
max_input_time = 60
variables_order = "EGPCS"
extension_dir = ./
upload_tmp_dir = /tmp
precision = 12
SMTP = relay-hosting.secureserver.net
url_rewriter.tags = "a=href,area=href,frame=src,input=src,form=,fieldset="

[Zend]
zend_extension=/usr/local/zo/ZendExtensionManager.so
zend_extension=/usr/local/zo/4_3/ZendOptimizer.so

The second site is my person one
php.ini is pretty long but
sessions are enabled. I can post it here if needed.

Both sites use a simple script that I found here:
http://www.yourcodes.com/free-php-login-script.php#phploginscript

The actual code is here:

<?
//Change 123pass below to your password of choice
$key = '123pass';

if (!isset($pass)){
echo "You must enter a password to view this page.";
?>
<form name="form1" method="post" action="<? $_SERVER[PHP_SELF]; ?>">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}


if ($pass == ''){
echo "You must enter a password to view this page.";
?>
<form name="form1" method="post" action="<? $_SERVER[PHP_SELF]; ?>">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}

//replace 123pass below with the password of your choice
if ($pass !== $key){
echo "Password incorect try again.";
?>
<form name="form1" method="post" action="<? $_SERVER[PHP_SELF]; ?>">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}

?>

Put your protected information here!

The problem is that when I enter the password nothing happens
and it just resets it self. Anything to do with _SERVER[PHP_SELF]?

Please help. These sites are for good causes.
Thanks

bradmasterx

//replace 123pass below with the password of your choice
if ($pass !== $key){

it should be

//replace 123pass below with the password of your choice
if ($pass != $key){

rey00002

Still no change. Does the same thing..... 🙁

Weedpacket

<? $_SERVER[PHP_SELF]; ?>

You need to actually echo $_SERVER['PHP_SELF'] (and note the quotes). It's also better to use "<?php" instead of just "<?".

<?php echo $_SERVER['PHP_SELF']?>

And $pass almost certainly needs to be $_POST['pass'].

rey00002

With the new code i get this error:

Parse error: parse error, unexpected T_STRING in /home/content/r/e/y/rey00002/html/pass.php on line 36

The code now looks like this with the change you recommeded:

<?
//Change 123pass below to your password of choice
$key = '123pass';

if (!isset($pass)){
echo "You must enter a password to view this page.";
?>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?>">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}


if ($pass == ''){
echo "You must enter a password to view this page.";
?>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?>">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}

//replace 123pass below with the password of your choice
if ($pass != $key){
echo "Password incorect try again.";
?>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?">
  Password:
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Login">
</form>
<?
die;
}

?>

Put your protected information here!

bradgrafelman

When posting PHP code, please use the board's [PHP][/PHP] bbcode tags as they make your code much easier to read. You should go back and edit your posts now to include these tags.

Weedpacket

There are still a number of places where you're using <? instead of <?php.

bradgrafelman wrote:
You should go back and edit your posts now to include these tags.

Yes; if you do this your error would become obvious (hint: it's on line 36).

bradgrafelman

In addition, you are also using $pass instead of $_POST['pass'] as recommend above. In fact, if $pass works, I would recommend looking into disabling register_globals on your server (and testing each of your scripts to see which ones need to be updated).

rey00002

I made the changes of

<? to <?php
$pass to $_POST['pass']
PHP block 🙂

However I still have the error:

Parse error: parse error, unexpected T_STRING in xxx/pass.php on line 36

Sorry for this confusion.

Here is my updated code:

<?php

//Change 123pass below to your password of choice

$key = '123pass';



if (!isset($_POST['pass'])){

echo "You must enter a password to view this page.";

?>

<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?>">

  Password:

  <input type="text" name="pass">

  <input type="submit" name="Submit" value="Login">

</form>

<?php

die;

}





if ($_POST['pass'] == ''){

echo "You must enter a password to view this page.";

?>

<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?>">

  Password:

  <input type="text" name="pass">

  <input type="submit" name="Submit" value="Login">

</form>

<?php

die;

}



//replace 123pass below with the password of your choice

if ($_POST['pass'] != $key){

echo "Password incorect try again.";

?>

<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?">

  Password:

  <input type="text" name="pass">

  <input type="submit" name="Submit" value="Login">

</form>

<?php

die;

}



?>



Put your protected information here!

bradgrafelman

Okay, now look at your post now that you've used the bbcode tags. Look towards the end (around line 36, for example). Notice where the color-coding goes haywire? That's where you've mistyped/forgotten something (namely a '>' character to close the PHP code block).

rey00002

That was it! That got it thank you!
Interesting that the original script I got is quite a bit different than my working one.
On their website:

http://www.yourcodes.com/free-php-login-script.php#phploginscript

They have a working example, however the code that you download is different:

<? instead of <?php
$pass instead of $_POST['pass']

<form name="form1" method="post" action="<? $_SERVER[PHP_SELF]; ?>">
          instead of 
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']?>">

Lots of errors.... Guess I cant really trust that site. 🙁

Anyways, I will mark this as resolved.

Thanks again.