Delete pages not working

doctortim

I am creating my two pages for removing records (articles) from my blog databases. These pages are delete.php and confirm_delete.php

I can't really find why the code is getting rid of them from the database.

Here is my php code in the confirm delete page...

<?php
include_once("include/connect_sql.inc.php");

$thisArticle_id = $_POST['article_id'];
$sql = "SELECT * FROM blogprofessional
			WHERE article_id = '".$thisArticle_id."'";
$result = mysql_query($sql);
$numberOfRows = mysql_num_rows($result);

if ($numberOfRows==0) {  

echo 'Sorry. No records found !!';
}
else if ($numberOfRows>0) {

$i=0;
$article_id = mysql_result($result,$i,"article_id");
$issue_no = mysql_result($result,$i,"issue_no");
$issue_date = mysql_result($result,$i,"issue_date");
$focus = mysql_result($result,$i,"focus");
$toc = mysql_result($result,$i,"toc");
$article = mysql_result($result,$i,"article");
  }
?>

and the confirm delete button/form is as follows:

<tr><form name="customersEnterForm" method="POST" action="pro_blog_delete.php">
          <td width="609"><input type="hidden" name="thisArticle_idField" value="<? echo $thisArticle_id; ?>" /></td>
          <td width="215"><input type="submit" name="submitConfirmDeleteCustomersForm" value="Delete from Blog Archive" /></td>
          <td width="85"><input type="button" name="cancel" value="Back" onclick="javascript:history.back();" /></td></form>
        </tr>

now finally when the button is clicked and redirection to the delete page occurs this is the code that should process:

<?php
include_once("include/connect_sql.inc.php");

// Retreiving Form Elements from Form
$thisArticle_id = addslashes($_POST['thisArticle_idField']);


$sql = "DELETE FROM blogprofessional
			WHERE article_id = '$thisArticle_id'";
$result = mysql_query($sql);

?>

When I check in phpmyadmin the record has not been deleted.

Please help, thank you very much.

jeepin81

you're not telling it to delete anything:

<?php 
include_once("include/connect_sql.inc.php"); 

// Retreiving Form Elements from Form 
$thisArticle_id = addslashes($_POST['thisArticle_idField']); 


$sql = "DELETE FROM blogprofessional 
            WHERE article_id = '$thisArticle_id'"; 
$result = mysql_query($sql); 

?>

try telling it something to delete:

<?php 
include_once("include/connect_sql.inc.php"); 

// Retreiving Form Elements from Form 
$thisArticle_id = addslashes($_POST['thisArticle_idField']); 


$sql = "DELETE comment, artical, topics, FROM blogprofessional 
            WHERE article_id = '$thisArticle_id'"; 
$result = mysql_query($sql); 

?>

hope that helps
j

bradgrafelman

jeepin81 wrote:
try telling it something to delete:

You might want to read the MySQL manual on DELETE syntax as you'll find that yours is invalid and doctortim's was actually valid.

doctortim: First thing I would suggest is to not use short tags at all, as this may be the culprit (did you view the source of the HTML page and verify that the ID was being outputted correctly?).

If that doesn't fix it, try debugging the DELETE query like so:

$sql = "DELETE comment, artical, topics, FROM blogprofessional
            WHERE article_id = '$thisArticle_id'";
$result = mysql_query($sql);

echo "Delete query: $sql<hr>Rows affected: " . mysql_affected_rows();

doctortim

Ok I have fixed the short tag, but still not deleting.

Then I looked at the page source and found this for my confirm delete form:

<tr>
<form name="customersEnterForm" method="POST" action="pro_blog_delete.php">
          <td width="609"><input type="hidden" name="thisArticle_idField" value="" /></td>
          <td width="215"><input type="submit" name="submitConfirmDeleteCustomersForm" value="Delete from Blog Archive" /></td>
          <td width="85"><input type="button" name="cancel" value="Back" onclick="javascript:history.back();" /></td>
</form>
</tr>

The value is not getting the article id echoed into it. Once again, the php to insert the article id is follows

<tr>
<form name="customersEnterForm" method="POST" action="pro_blog_delete.php">
          <td width="609"><input type="hidden" name="thisArticle_idField" value="<?php echo $article_id; ?>" /></td>
          <td width="215"><input type="submit" name="submitConfirmDeleteCustomersForm" value="Delete from Blog Archive" /></td>
          <td width="85"><input type="button" name="cancel" value="Back" onclick="javascript:history.back();" /></td>
</form>
</tr>

I am also getting the "Sorry,no records found" message from the top part of my confirm delete page, which once again comes from this code:

<?php
include_once("include/connect_sql.inc.php");

$thisArticle_id = $_POST['article_id'];
$sql = "SELECT * FROM blogprofessional
			WHERE article_id = '".$thisArticle_id."'";
$result = mysql_query($sql);
$numberOfRows = mysql_num_rows($result);

if ($numberOfRows==0) {  

echo 'Sorry. No records found !!';
}
else if ($numberOfRows>0) {

$i=0;
$article_id = mysql_result($result,$i,"article_id");
$issue_no = mysql_result($result,$i,"issue_no");
$issue_date = mysql_result($result,$i,"issue_date");
$focus = mysql_result($result,$i,"focus");
$toc = mysql_result($result,$i,"toc");
$article = mysql_result($result,$i,"article");
  }
?>

Im stumped

doctortim

By the way this is the results of the error for the delete query brad suggested

Delete query: DELETE FROM blogprofessional WHERE article_id = ''Rows affected: 0

therefore the variable $thisArticle_id is not getting its value

// Retreiving Form Elements from Form
$thisArticle_id = addslashes($_POST['thisArticle_idField']);

The argument for post is from 'name' in the confirm delete button.

Though still doesn't appear to explain why the "no records" message appears on the confirm delete page.

bradgrafelman

Can you show us the code that is generating the HTML for the form? The problem is obvious; the ID is never placed in the hidden form field, thus the next script can't build the SQL query because it was never passed the ID.

doctortim

hi brad

its the code at the top of my third to last reply