Need to zip contents of directory, only zips ONE file, not the entire array :(

[kthibeault1965]

I have been struggling with the following task, which seems rather easy.

The problem is that the zip file only contains ONE file, not ALL the files in the directory. Can anyone offer some suggestions? Cheers

	$start_dir = 'upload/jpgrename/';

function listFilesInDir($start_dir)
        {
        // returns an array of files in $start_dir (not recursive)
        $files = array();
        $dir = opendir($start_dir);
        while(($myfile = readdir($dir)) !== false)
                {
                if($myfile != '.' && $myfile != '..' && !is_file($myfile)  )
                        {
                        $files[] = $myfile;
			}
                }
        closedir($dir);
        return $files;
	}

$dir = 'upload/jpgrename/';  // sets the directory to scan
include ('Zip.php');        // inludes the zip.php class
$jpglist = listFilesInDir($dir);  // calls the function listFilesDir
foreach($jpglist as $key => $fileName)   // loops through the directory
        {
        echo "<a href='{$dir}/{$fileName}'>{$fileName}</a><br />";    // displays file list as links
	}

// following statements create a zip file with only ONE file in the directory, not the entire ARRAY
$s = dir($path);   // sets path, opens the directory
$obj = new Archive_Zip('test.zip'); // declares name of zip file to create	
$jpglist = listFilesInDir($dir);
	foreach($jpglist as $key => $fileName)
	{
	$jpglist = "upload/jpgrename/".$fileName;
	}
// echos back the successful creation of zip - but only zips one file
	if ($obj->create($jpglist)) {
			echo 'Created successfully!';
			} else {
			echo 'Error in file creation';
		}
	$s->close();  // closes the directory

[bpat1434]

I see one issue from the top. You want to zip multiple files, yet the function "listFilesInDir" will only list directories since you have this check:

!is_file($myfile)

Remove the "!" and that should list files.

Secondly, your "list" that you're trying to add gets overwritten each time you loop. So in the foreach loop here:

foreach($jpglist as $key=>$fileName)

You just take that name and put it as the string $jpglist and don't do anything with it in that loop. Then, once it's done, you create the zip.

To fix this, move the code:

if(obj->create($jpglist))

and it's supporting code into the foreach() loop. So you'd have something like:

foreach($jpglist as $key=$fileName)
{
    $jpglist = "upload/jpgrename/".$fileName;

if($obj->create($jpglist))
    echo 'Successfully added: ' . $jpglist;
else
    echo 'Error in file creation.  Trying to add: '  . $jpglist;
}

Hope that helps.

[kthibeault1965]

THANK you for your insight.... very much. I removed the ! and moved the other code as suggested into the foreach loop, but am now getting no files at all in the zip file.

btw I left the original syntax of the echo message below, commented out... just for comparison. th

	$start_dir = 'upload/jpgrename/';

function listFilesInDir($start_dir)
        {
        // returns an array of files in $start_dir (not recursive)
        $files = array();
        $dir = opendir($start_dir);
        while(($myfile = readdir($dir)) !== false)
                {
                if($myfile != '.' && $myfile != '..' && is_file($myfile)  )
                        {
                        $files[] = $myfile;
			}
                }
        closedir($dir);
        return $files;
	}

$dir = 'upload/jpgrename/';  // sets the directory to scan
include ('Zip.php');        // inludes the zip.php class
$jpglist = listFilesInDir($dir);  // calls the function listFilesDir
foreach($jpglist as $key => $fileName)   // loops through the directory
        {
        echo "<a href='{$dir}/{$fileName}'>{$fileName}</a><br />";    // displays file list as links
	}

// following statements create a zip file with only ONE file in the directory, not the entire ARRAY
$s = dir($path);   // sets path, opens the directory
$obj = new Archive_Zip('test.zip'); // declares name of zip file to create	
$jpglist = listFilesInDir($dir);
	foreach($jpglist as $key => $fileName)
	{
		$jpglist = "upload/jpgrename/".$fileName; 

if($obj->create($jpglist)) 
    echo 'Successfully added: ' . $jpglist; 
else 
    echo 'Error in file creation.  Trying to add: '  . $jpglist; 
			}
// echos back the successful creation of zip - but only zips one file
/*	
if ($obj->create($jpglist)) {
			echo 'Created successfully!';
			} else {
			echo 'Error in file creation';
		}
*/

	$s->close();  // closes the directory

[bpat1434]

Try doing a quick var_dump() of the $jpglist variable before the foreach. Make sure that it's populated with what you want.

[kthibeault1965]

I get the following
array(0) { }

so, I looks like my array is empty...

[bpat1434]

try prepending the path to the $myFile variable in the function.

is_file($start_dir . $myfile)

[kthibeault1965]

I re-added the ! to the to in the in function just before

is_file($myfile)

so it now looks like this:

!is_file($myfile)

and now get a list of files (linked) as before - just to display, then below that I now get:

array(1025) { [0]=> string(20) "tbp20049473_v7_l.jpg" [1]=> string(20) "tbp20049473_v8_l.jpg"

and so on, so I looks like the array is now getting successfully populated.

Now last step is to pull this array into the statement that creates the zip file.

this code only grabs the LAST item in the array, and creates a zip file of Just that last one, not the entire array somehow.

[kthibeault1965]

if $jpglist is already successfully populated, i wonder if I really need a FOREACH loop at this point.

I have tried commenting out the following, and the zip file created is empty - no good obviously

$jpglist = "upload/jpgrename/".$fileName; 

[bpat1434]

did you put the $obj->create() code inside the foreach loop?

[kthibeault1965]

I tried the following - and still am getting the single jpg in the result zip file, it is grabbing the last of the array

$start_dir = 'upload/jpgrename/';

function listFilesInDir($start_dir)
        {
        // returns an array of files in $start_dir (not recursive)
        $files = array();
        $dir = opendir($start_dir);
        while(($myfile = readdir($dir)) !== false)
                {
                if($myfile != '.' && $myfile != '..' && !is_file($myfile)  )
                        {
                        $files[] = $myfile;
			}
                }
        closedir($dir);
        return $files;
	}

$dir = 'upload/jpgrename/';  // sets the directory to scan
include ('Zip.php');        // inludes the zip.php class
$jpglist = listFilesInDir($dir);  // calls the function listFilesDir
foreach($jpglist as $key => $fileName)   // loops through the directory
        {
        echo "<a href='{$dir}/{$fileName}'>{$fileName}</a><br />";    // displays file list as links
	}

// following statements create a zip file with only ONE file in the directory, not the entire ARRAY
$s = dir($path);   // sets path, opens the directory
$obj = new Archive_Zip('test.zip'); // declares name of zip file to create	
$jpglist = listFilesInDir($dir);
var_dump($jpglist);
	foreach($jpglist as $key => $fileName)
	{  
		$jpglist = "upload/jpgrename/".$fileName; 
		$obj->create($jpglist) ;
	}
   // if($obj->create($jpglist)) 
     //   echo 'Successfully added: ' . $jpglist; 
     //		else 
     //   echo 'Error in file creation.  Trying to add: '  . $jpglist; 

[kthibeault1965]

Okay... you were right to have the obj called inside the foreach loop...
the only thing I was doing wrong was callling the WRONG method of the function

instead of

$obj->create

I should have used

$obj->add

This way, i am adding a file to the zip archive for each file it finds instead of RE Creating the file each time.

Thanks for your help !!! Fixed and working code below

	$start_dir = 'upload/jpgrename/';

function listFilesInDir($start_dir)
        {
        // returns an array of files in $start_dir (not recursive)
        $files = array();
        $dir = opendir($start_dir);
        while(($myfile = readdir($dir)) !== false)
                {
                if($myfile != '.' && $myfile != '..' && !is_file($myfile)  )
                        {
                        $files[] = $myfile;
			}
                }
        closedir($dir);
        return $files;
	}

$dir = 'upload/jpgrename/';  // sets the directory to scan
include ('Zip.php');        // inludes the zip.php class
$jpglist = listFilesInDir($dir);  // calls the function listFilesDir
foreach($jpglist as $key => $fileName)   // loops through the directory
        {
        echo "<a href='{$dir}/{$fileName}'>{$fileName}</a><br />";    // displays file list as links
	}

// following statements create a zip file with only ONE file in the directory, not the entire ARRAY
$s = dir($path);   // sets path, opens the directory
$obj = new Archive_Zip('test.zip'); // declares name of zip file to create	
$jpglist = listFilesInDir($dir);

	foreach($jpglist as $key => $fileName)
	{  
		$jpglist = "upload/jpgrename/".$fileName.','; 
		$obj->add($jpglist) ;
	}

[bpat1434]

Ah... that's something that would have been helpful was what the zip class looked like 😉 But glad you got it solved.

Don't forget to mark this as resolved if it is.

[kthibeault1965]

how do you mark as resolved? can find button for that

[bpat1434]

Thread Tools --> Mark Resolved