Php Class not working? Was fine while it was procedural script...

Alex-Grim

This was just an included script, but i changed it to be oo, and now it's broken. If you take out all the code between the class definitaion, it doesn't stop page execution, but i've tried taking out sections of the code, and no matter what section i remove, it's not allowing the page to execute, so i don't know what it is, i can't see any errors. Here it is:

<?php
class UserVars{
$uagent = $_SERVER['HTTP_USER_AGENT'];

function time(){
	date_default_timezone_set('UTC');
	return date('Y-m-d H-i-s');
}

function agent(){
	return $uagent;
}

function browser(){
	if (ereg("MSIE",$uagent)) {
		$browser = "IE";
	} elseif (ereg( "Opera",$uagent)) {
		$browser = "Opera";
	} elseif(ereg("Firefox",$uagent)) {
		$browser = "Firefox";
	} elseif(ereg("Safari",$uagent)) {
		$browser = "Safari";
	} else {
		$browser= "other";
	}
	return $browser;
}

function os(){
	if (ereg("Win",$uagent)) {
		$os="Win";
	} else if (ereg("Mac",$uagent)) {
		$os="Mac";
	} else if (ereg("Linux",$uagent)) {
		$os="Linux";
	} else if (ereg("Unix",$uagent)) {
		$os="Unix";
	} else {
		$os="Other";
	}
	return $os;
}

funtion dist(){
	if (ereg("Fedora",$uagent)) {
		$distro="Fedora";
	} else if (ereg("Ubuntu",$uagent)) {
		$distro="Ubuntu";
	} else if (ereg("Debian",$uagent)) {
		$distro="Debian";
	} else if (ereg("FreeBSD",$uagent)) {
		$distro="FreeBSD";
	} else if(ereg("NT 4.0",$uagent)) {
		$distro="NT";
	} else if (ereg("NT 5.0",$uagent)) {
		$distro="2000";
	} else if (ereg("NT 5.1",$uagent)) {
		$distro="XP";
	} else if (ereg("NT 5.2",$uagent)) {
		$distro="XP";
	}else if (ereg("NT 6.0",$uagent)) {
		$distro="Vista";
	} else {
		$distro="Other";
	}
	return $distro;
}


function ip(){
	return $_SERVER['REMOTE_ADDR'];
}

function ip2(){
	if ($ip2 = getenv('HTTP_CLIENT_IP')) {}
		elseif ($ip2 = getenv('HTTP_X_FORWARDED_FOR')) {}
		elseif ($ip2 = getenv('HTTP_X_FORWARDED')) {}
		elseif ($ip2 = getenv('HTTP_FORWARDED_FOR')) {}
		elseif ($ip2 = getenv('HTTP_FORWARDED')) {}
		else {
		$ip2 = "0";
	}
	return $ip2;
}
}
?>

Thanx

Alex-Grim

I meant to add, this is the code that uses it. and yes, i know that half the lines are commented out, but it's still not executing:

<?php
	include_once("variables.php");
	include_once("../classes/MySql.php");

//$uvar = new UserVars();
$db = new MySql();
$con = $db->C();

$name = $_POST['name'];
$phone = $_POST['phone'];
$email = $_POST['email'];
$comment = $_POST['comment'];
$uri = str_replace("http://","",$_POST['uri']);
//echo $name . $br;
//echo $phone . $br;
//echo $email . $br;
//echo $comment . $br;
//echo $time . $br;
//echo $ip . $br;
//echo $ip2 . $br;
//echo $uvar->browser . $br;
//echo $uvar->agent . $br;
//echo $uvar->os . $br;
//echo $uvar->dist . $br;
echo $uri . $br;

//$q = $db->Q("Insert into Comments (name,phone,email,comment,uri,commentdate,ipaddy,ipforward,useragent,browser,distro,platform)values('$name','$phone','$email','$comment','$uri','$uvar->time','$uvar->ip','$uvar->ip2','$uvar->agent','$uvar->browser','$uvar->dist','$uvar->os')");
?>

Alex-Grim

Yes, as you can see, i'm calling the class file, but i'm not even using it yet, and it's still killing the page.

Alex-Grim

Simply calling the page to be included is where it's being stopped. I have commented out where i tired to instantiate it and use it, to see if merely including it would kill the page, and as you can see, it does, so the error must be in the class file...

Even THIS kills it:
<?php
include_once("variables.php");
?>

NogDog

Well, to start with, your UserVars class does not compile. Perhaps you need to turn on all error reporting while developing your code?

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL | E_STRICT);
// ...rest of script...

Here's a version that compiles, with my changes commented. You'll still need to test it and see if it actually does what you want:

<?php
class UserVars{
   // need 'var' keyword here. Also, cannot assign a default value
   // that is a variable
   var $uagent;

   // constructor:
   // moved assignment of $uagent here
   function UserVars()
   {
      $this->uagent = $_SERVER['HTTP_USER_AGENT'];
   }

function time(){
	date_default_timezone_set('UTC');
	return date('Y-m-d H-i-s');
}

function agent(){
	return $uagent;
}

function browser(){
	if (ereg("MSIE",$uagent)) {
		$browser = "IE";
	} elseif (ereg( "Opera",$uagent)) {
		$browser = "Opera";
	} elseif(ereg("Firefox",$uagent)) {
		$browser = "Firefox";
	} elseif(ereg("Safari",$uagent)) {
		$browser = "Safari";
	} else {
		$browser= "other";
	}
	return $browser;
}

function os(){
	if (ereg("Win",$uagent)) {
		$os="Win";
	} else if (ereg("Mac",$uagent)) {
		$os="Mac";
	} else if (ereg("Linux",$uagent)) {
		$os="Linux";
	} else if (ereg("Unix",$uagent)) {
		$os="Unix";
	} else {
		$os="Other";
	}
	return $os;
}

   // fixed typo of 'funtion'
	function dist(){
		if (ereg("Fedora",$uagent)) {
			$distro="Fedora";
		} else if (ereg("Ubuntu",$uagent)) {
			$distro="Ubuntu";
		} else if (ereg("Debian",$uagent)) {
			$distro="Debian";
		} else if (ereg("FreeBSD",$uagent)) {
			$distro="FreeBSD";
		} else if(ereg("NT 4.0",$uagent)) {
			$distro="NT";
		} else if (ereg("NT 5.0",$uagent)) {
			$distro="2000";
		} else if (ereg("NT 5.1",$uagent)) {
			$distro="XP";
		} else if (ereg("NT 5.2",$uagent)) {
			$distro="XP";
		}else if (ereg("NT 6.0",$uagent)) {
			$distro="Vista";
		} else {
			$distro="Other";
		}
		return $distro;
	}


function ip(){
	return $_SERVER['REMOTE_ADDR'];
}

function ip2(){
	if ($ip2 = getenv('HTTP_CLIENT_IP')) {}
		elseif ($ip2 = getenv('HTTP_X_FORWARDED_FOR')) {}
		elseif ($ip2 = getenv('HTTP_X_FORWARDED')) {}
		elseif ($ip2 = getenv('HTTP_FORWARDED_FOR')) {}
		elseif ($ip2 = getenv('HTTP_FORWARDED')) {}
		else {
		$ip2 = "0";
	}
	return $ip2;
}
}
?>

Alex-Grim

i can't turn on error reporting. i've tried:
http://www.phpfreaks.com/forums/index.php/topic,172044.msg762415.html#msg762415

I will try you code and see what i did wrong. I will also try your error reporting code too. Thanx,

Alex-Grim

Thanx, i can't believe i didn't catch that syntax error, especially when Gedit has SYNTAX HIGHTLIGHING. Sheeshe...

And i can also see my errors now! Thanx a million for that one.

Weedpacket

Just observing: you'll have further changes to make to your code before it will work. The shortest example is

 function agent(){
        return $uagent;
    }

I know this isn't Code Critique, but I'll also point out that those uses of [man]ereg[/man] would be better off using [man]strpos[/man] instead (see the notes on the ereg page, followed by those on the preg_match page cited therein, for why).