[RESOLVED] if statements

[shaneshack]

Having a problem with the following code:

<?php 
$ticketstatus = $row['status'];
$begin = strtotime($row['startdate']);
$now = time();
$subdiff = $now - $begin;
$difference = round($subdiff /60 /60 /24);
if($ticketstatus = "open"){
if($difference < 5){ echo "<p style='background:green;color:white'>".stripslashes($row['incidentno'])."</p>"; }	
if($difference >= 5){ echo "<p style='background:yellow'>".stripslashes($row['incidentno'])."</p>"; }
if($difference >= 10){ echo "<p style='background:red'>".stripslashes($row['incidentno'])."</p>"; }
}
else{ if($ticketstatus = "closed"){echo "<p style='background:white;color:silver'>".stripslashes($row['incidentno'])."</p>"; }}
?>

This code produces the following html:

<p style='background:green;color:white'>18</p><p style='background:white;color:silver'>18</p>

What I am attempting to do is color code our trouble tickets by how long they have been in an open status: less than 5 days = green, >= 5 days = yellow, >= 10 days equals red. Once a ticket is closed, I want the color to change to white with silver text color. $ticketstatus is pulled from a mysql database.

The green, yellow, red color codes are working perfectly. However, I am getting also getting the "closed" color code displayed on each record regardless if it is set to closed or open. Any help would be appreciated. I'm not getting any errors.

[laserlight]

You have two problems. The first is that you write:

if($ticketstatus = "open")

which is probably incorrect since it assigns "open" to $ticketstatus instead of comparing them. This then done again when you write:

else{ if($ticketstatus = "closed")

The next problem is with the code logic, which says:
if $difference < 5, do x
if $difference >= 5, do y
if $difference >= 10, do z

But if $difference is greater than or equal to 10, it is also greater than or equal to 5, so both y and z are done.

To correct these problems:

<?php 
$ticketstatus = $row['status'];
$begin = strtotime($row['startdate']);
$now = time();
$subdiff = $now - $begin;
$difference = round($subdiff /60 /60 /24);

$style = '';
if ($ticketstatus == 'open') {
    if ($difference < 5) {
        $style = 'background:green;color:white';
    } else if ($difference < 10) {
        $style = 'background:yellow';
    } else {
        $style = 'background:red';
    }
}
else {
    $style = 'background:white;color:silver';
}
echo "<p style='$style'>" . htmlspecialchars(stripslashes($row['incidentno'])) . "</p>";

?>

Instead of using stripslashes(), I recommend changing php.ini to turn magic_quotes_gpc to Off. I added the [man]htmlspecialchars/man as a precaution to avoid malicious code injection.

[shaneshack]

Thank you for the fast response. Your solution was effective - as I'm sure you knew it would be. One quick side question:

I have magic_quotes_gpc turned off. So I don't have to include stripslashes? Could you explain to me the malicous code injection thing you mentioned?

[laserlight]

I have magic_quotes_gpc turned off. So I don't have to include stripslashes?

Yes, and in fact you should not use stripslashes().

Could you explain to me the malicous code injection thing you mentioned?

It may be possible to insert malicious Javascript into the text stored in the database.