[RESOLVED] update failing for unknown reason

Desbrina

if(isset($_POST['Submit'])) {
			$bcolour = mysql_real_escape_string($_POST['bcolour']);
			$fcolour = mysql_real_escape_string($_POST['fcolour']);
			$sql = "UPDATE user_templates
			SET bcolour = '".$bcolour."',
			fcolour = '".$fcolour."'
			WHERE ID = ".$id."
			LIMIT 1" or die(mysql_error());
			$result = mysql_query($sql);
			print $sql;
		}

I'm using that query to update user settings but its not updating, for unknown reason. IF i print the sql it appears fine, and if i run it through phpmyadmin it always says theres no results

UPDATE user_templates SET bcolour = '000000', fcolour = 'FFFFFF' WHERE ID = 1 LIMIT 1

There is a record with ID 1

INSERT INTO `user_templates` VALUES(1, 0, 0);

1 is ID, the first 0 is bcolour and the second is fcolour

dotnotwhat

You have the 'or die(mysql_error());' in the wrong place. You're trying to add that at the end of a string assignment, not after the actual mysql_query function call.

Try:-

if(isset($_POST['Submit'])) {
            $bcolour = mysql_real_escape_string($_POST['bcolour']);
            $fcolour = mysql_real_escape_string($_POST['fcolour']);
            $sql = "UPDATE user_templates
            SET bcolour = '".$bcolour."',
            fcolour = '".$fcolour."'
            WHERE ID = ".$id."
            LIMIT 1";
            $result = mysql_query($sql) or die(mysql_error());
            print $sql;
}

Desbrina

it still doesn't error or update

dotnotwhat

If the query isn't working within phpMyAdmin, it leads me to think there's a problem somewhere with the way your referencing the table / field names. Are you sure your field names are as follows, including the case sensitivity:-

ID
bcolour
fcolour

What data types are you using for these?

Desbrina

this is the table

CREATE TABLE `user_templates` (
  `ID` int(11) NOT NULL auto_increment,
  `user` text NOT NULL,
  `code` text NOT NULL,
  `bcolour` text NOT NULL,
  `fcolour` text NOT NULL,
  PRIMARY KEY  (`ID`)
) TYPE=MyISAM  AUTO_INCREMENT=6 ;

dotnotwhat

Are you sure the row with ID = 1 actually exists?

INSERT INTO `user_templates` VALUES(1, 0, 0);

will error in MySQL as it's missing values for the additonal columns in your table.

Desbrina

that was only an example, i'm not trying to insert, just update, That was showing that there was an ID 1 existing

I think i may have solved it though. Dont know what happened but when i emptied the table and started again it worked