Looking for some help with errors

theodordoctor

I just transfered my blog from one hosting account to another and now I am stuck with some errors in my code that is throwing off my alignment.

I am hoping someone would be so kind to check out my code and help me find the error so i can get my site back up and sell my products. I have checked for spacing issues already and everything looks good there. I am blind while staring straight at this code. I'm sure it's an obvious fix, however, I can't see it.

I will post the errors i am getting and my site. If you can see it by looking at it let me know. www.sayno2odor.com

Thank you

Warning: Invalid argument supplied for foreach() in /homepages/12/d87456108/htdocs/website3/public_html/wp-content/plugins/sem-theme/sem-theme-captions.php on line 25

Warning: Cannot modify header information - headers already sent by (output started at /homepages/12/d87456108/htdocs/website3/public_html/wp-content/plugins/sem-theme/sem-theme-captions.php:25) in /homepages/12/d87456108/htdocs/website3/public_html/wp-login.php on line 9

laserlight

What is the code at and around line 25?

Things to look out for are:
1. Did you rely on register_globals being on? Good practice says it should be off, and perhaps your new host follows good practice.

Did you check your incoming variables with [man]isset[/man] or [man]empty[/man] before using them? Additionally, did you check that incoming arrays really are arrays with [man]is_array[/man]? Failure to do these could result in warnings such as what you saw being reported.

The other warnings are just a by-product of the first warning.

theodordoctor

Laserlight,

Thank you for replying so quickly. Here is the code.

<?php
#

class sem_theme_captions

class sem_theme_captions
{
#

Variables

var $params = array();


#
# Constructor
#

function sem_theme_captions()
{
	$params = get_settings('sem_theme_captions_params');

	if ( $params )
	{
		foreach ( $params as $key => $value )
		{
			$this->params[$key] = $value;
		}
	}
	else
	{
		update_option('sem_theme_captions_params', $this->params);
	}

	add_action('admin_menu', array(&$this, 'add2admin_menu'));
} # end sem_theme_captions()


#
# register()
#

function register($captions = null)
{
	$ret = array();

	if ( isset($captions) )
	{
		foreach ( $captions as $key => $caption )
		{
			if ( !isset($this->params[$key]) )
			{
				$this->params[$key] = $caption;
			}
			$ret[$key] = $this->params[$key];
		}
	}

	return $ret;
} # end register()


#
# add2admin_menu()
#

function add2admin_menu()
{
	add_options_page(
			__('Captions', 'sem-theme'),
			__('Captions', 'sem-theme'),
			8,
			str_replace("\\", "/", __FILE__),
			array(&$this, 'display_admin_page')
			);
} # end add2admin_menu()


#
# update()
#

function update()
{
	foreach ( $this->params as $key => $caption )
	{
		if ( isset($_POST['cap_' . $key]) )
		{
			$this->params[$key] =  stripslashes(str_replace(array("&", "<", ">", "\""), array("&amp;", "&lt;", "&gt;", "&quot;"), convert_chars($_POST['cap_' . $key])));
		}
	}

	update_option('sem_theme_captions_params', $this->params);

	$this->flush_cache();
}


#
# flush_cache()
#

function flush_cache()
{
	if ( is_writable(sem_cache_path) )
	{
		$cache_files = glob(sem_cache_path ."*");

		if ( $cache_files )
		{
			foreach ( $cache_files as $cache_file )
			{
				if ( is_file($cache_file) && is_writable($cache_file) )
				{
					unlink( $cache_file );
				}
			}
		}
	}
} # end flush_cache()


#
# display_admin_page
#

function display_admin_page()
{
	if ( isset($_POST['action'])
		&& ( $_POST['action'] == 'update_sem_theme_captions' )
		)
	{
		$this->update();

		echo "<div class=\"updated\">\n"
			. "<p>"
				. "<strong>"
				. __('Options saved.', 'sem-theme')
				. "</strong>"
			. "</p>\n"
			. "</div>\n";
	}

	# Display admin page

	echo "<div class=\"wrap\">\n"
		. "<h2>" . __('Theme Captions', 'sem-theme') . "</h2>\n"
		. "<form method=\"post\" action=\"\">\n"
		. "<input type=\"hidden\" name=\"action\" value=\"update_sem_theme_captions\" />\n";

	echo "<fieldset class=\"options\">\n"
		. "<legend>" . __('Theme Captions', 'sem-theme') . "</legend>\n";

	echo "<table>\n"
		. "<tr>\n"
		. "<th>" . __('Key', 'sem-theme') . "</th>\n"
		. "<th>" . __('Value', 'sem-theme') . "</th>\n"
		. "</tr>\n";

	ksort($this->params);
	foreach ( $this->params as $key => $value )
	{
		echo "<tr>\n"
			. "<th style=\"width: 33%;\" scope=\"row\"><label for=\"cap_" . $key . "\">" . $key . ":</label></th>\n"
			. "<td><input style=\"width: 100%;\" type=\"text\""
				. " id=\"cap_" . $key . "\" name=\"cap_" . $key . "\""
				. " value=\"" . stripslashes($value) . "\""
				. " />"
				. "</td>\n"
			. "</tr>\n";
	}

	echo "</table>\n";

	echo "</fieldset>\n";


	echo "<p class=\"submit\">"
		. "<input type=\"submit\""
			. " value=\"" . __('Update Options', 'sem-theme') . "\""
			. " />"
		. "</p>\n";

	echo "</form>"
		. "</div>\n";
} # end display_admin_page()

} # end sem_theme_captions

$sem_theme_captions =& new sem_theme_captions();

$sem_captions =& $sem_theme_captions->params;
?>

Horizon88

As always, laserlight makes good suggestions.

On the other side of the coin, you could put:
error_reporting(0);
at the top of all your scripts. >_>

theodordoctor

Great suggestions yes, but the answer I was looking for NO.
My reason for posting here was to have someone look at my code quick with a trained eye to let me know where my error is.

Once i got my site back up I can relax and dive into the debugging and testing of my scripts.

laserlight

My trained eye sees that it is impossible to tell what is the underlying problem since it lies with get_settings(), but get_settings() is only called (once) in the given code, and never defined.

Aside from that, kindly indent your code next time. For PHP code (like what you posted), use the php bbcode tags instead of the code bbcode tags.

There is, however, a possible "fix". Change:

if ( $params )
{
    foreach ( $params as $key => $value )
    {
        $this->params[$key] = $value;
    }
}
else
{
    update_option('sem_theme_captions_params', $this->params);
}

to:

if ( is_array( $params ) )
{
    foreach ( $params as $key => $value )
    {
        $this->params[$key] = $value;
    }
}
else
{
    update_option('sem_theme_captions_params', $this->params);
}

Whether this fix is correct or not depends on what the code is supposed to do, and what get_settings() is supposed to return given the circumstances.