Pagnation Links Not Working

MsDacia

Hello,

I want to know if anyone can review my pagination code, and tell me why it isn't working, and what I can do to fix it. The code is posted below, and the queries are all called through stored procedures at the beginning of the page (not included), and all of the variables have been set. The exact problem is the start and end variable within the links (i.e. 2, 3, 4, etc) are not increasing by the set limit variable. The back link is not going to the previous page. And if I click the page link more than once, the increments increase by 1. I hope I explained this well. Any help will be appreciated.

    //Pagination - Check for pages to display
	$rows = $result_max[0]['@v_max'];  

    if(empty($page)){ 
        $page = 1; 
    } 
    $limit_value = $page * $v_record_limit - ($v_record_limit);  

    if($rows == 0){ 
        echo 'Nothing to Display!'; 
    } 

//Pagination - Back/Previous Results
if($page != 1){  

        $page_prev = $page--; 
        echo '<li><a href="subcat_list.php?cat_id='.$v_cat_id.'&sort_by='.$v_sort_by.'&record_start='.$v_record_start.'&record_end='.$v_record_end.'" class="prevnext">&laquo; BACK</a></li>';  

    }else{ 
        echo '<li><a class="prevnext">&laquo; BACK</a></li>'; 
    } 

//Pagination - Split Page Results
$num_of_pages = ceil($rows / $v_record_limit);  
$new_start = ($v_record_start = ($v_record_end + 1));
$new_end = $v_record_end + ($limit_value + $v_record_limit);

for($i = 1; $i <= $num_of_pages; $i++){ 
    if($i == $page){ 
        echo '<span class="currentpage"> '.$i.'</span> '; 
    }else{
		echo '<li><a href="subcat_list.php?cat_id='.$v_cat_id.'&sort_by='.$v_sort_by.'&record_start='.$new_start.'&record_end='.$new_end.'">'.$i.'</a></li>'; 
    } 
} 
if(($rows % $v_record_limit) != 0){ 
    if($i == $page){ 
        echo ' '.$i.' '; 
    }else{ 
        echo '<li><a href="subcat_list.php?cat_id='.$v_cat_id.'&sort_by='.$v_sort_by.'&record_start='.$new_start.'&record_end='.$new_end.'">'.$i.'</a></li>'; 
    } 
} 

//Pagination - Next/Forward Results
if(($rows - ($v_record_limit * $page)) > 0){ 
    $page_next = $page++; 
    echo '<li><a href="subcat_list.php?cat_id='.$v_cat_id.'&sort_by='.$v_sort_by.'&record_start='.$new_start.'&record_end='.$new_end.'" class="prevnext">NEXT &raquo;</a></li>';  
}else{ 
    echo '<li><a class="prevnext">NEXT &raquo; </a></li>';  
}

bpat1434

THe variable $new_start doesn't increment during your for() loop... so if $new_start is always 25, or 50, then all your pages will be that.

MsDacia

OK. Thank you. Do you know how I can add the ellipsis to my code, so rather than having 1 2 3 4 5 6 7 8 9 10, etc. showing, I can have 1 2 3 ... 10 showing??

I appreciate the help. Sometimes, its the little or simplest things that throw me off.

bpat1434

To briefly go over it...

You have to define how many page links you want shown. So for this example, we'll use 5 ($display will equal 5). So you'll have 5 page links, plus the Previous & Next links. So it'll end up looking like:

« Previous 1 ... 8 [ 9 ] 10 ... 25 Next »

We first look to see if $current_page is within 3 of the last or first page. So in our example if $current_page is between 2 and 4 or 24 and 22, we just show the starting or ending 4. As well as the last page and Previous & Next links.

If it's not within the starting or ending 4 (as explained above) then we need to figure out the display. With this, we can now say that we'll show $display - 2 (for the first & last pages); this will be saved as $spread.

Now, if $spread is greater than 0, we take the spread, subtract 1 (for the current page) and then divide that by 2. That is the number before and after the current page we'll go to. We'll save this as $pad.

From here, we just need to loop through starting at $current_page - $pad, and going to $current_page + $pad.

Then just concatenate the beginning and ending as needed 😉

That's the basic outline of it. I don't have time to write the code for you to see, but this should really help you out.

MsDacia

I am sorry, but I am not getting it to work.

bpat1434

<?php

function paginate($last, $current, $href, $display=5)
{
	$span = $display-2; // Remove the first & last pages from display...
	$pad = floor(($span-1)/2); // Round down to make this "symmetrical"

// No matter what, we'll show the Previous & first page link:
if($current > 1)
	$content = '<a href="' . $href . '?page=' . ($current-1) . '">&laquo; Previous</a>';
else
	$content = '&laquo; Previous';

if($current == 1)
	$content .= ' <a href="' . $href . '?page=1" class="current">1</a>';
else
	$content .= ' <a href="' . $href . '?page=1" class="">1</a>';

# If the current page is in the first part
if($current >= 1 && $current <= $display)
{
	for($i=2; $i<=$span+1; $i++)
	{
		$class = ($current == $i) ? 'current' : '';

		$content .= ' <a href="' . $href . '?page=' . $i . '" class="' . $class . '">' . $i . '</a>';
	}

	// Ellipsis between span and last number.  i.e.: 15 ... 25 Next
	$content .= ' ...';
}
# If the current page is in the last part of the links
elseif($current <= $last && $current >= $last-($display-1))
{
	// Ellipsis between 1 and next number.  i.e.: 1 ... 10
	$content .= ' ...';

	for($i=($last-$span); $i<$last; $i++)
	{
		$class = ($current == $i) ? 'current' : '';

		$content .= ' <a href="' . $href . '?page=' . $i . '" class="' . $class . '">' . $i . '</a>';
	}
}
# Otherwise, just show the parts we need...
else
{
	// Ellipsis between 1 and next number.  i.e.: 1 ... 10
	$content .= ' ...';

	for($i=($current-$pad); $i<=($current+$pad); $i++)
	{
		$class = ($current == $i) ? 'current' : '';

		$content .= ' <a href="' . $href . '?page=' . $i . '" class="' . $class . '">' . $i . '</a>';
	}

	// Ellipsis between span and last number.  i.e.: 15 ... 25 Next
	$content .= ' ...';
}

// Show the last page...
if($last == $current)
	$content .= ' <a href="' . $href . '?page=' . $last . '" class="current">' . $last . '</a>';
else
	$content .= ' <a href="' . $href . '?page=' . $last . '">' . $last . '</a>';

// Show the Next link...
if($current < $last)
	$content .= ' <a href="' . $href . '?page=' . ($current+1) . '">Next &raquo;</a>';
else
	$content .= ' Next &raquo;';

// Return the link stuff...
return $content;
}

echo 'Current Page: 1 :: ' . paginate(25, 1, $_SERVER['PHP_SELF'], 11);
echo '<br /><br />';
echo 'Current Page: 12 :: ' . paginate(25, 12, $_SERVER['PHP_SELF'], 11);
echo '<br /><br />';
echo 'Current Page: 16 :: ' . paginate(25, 16, $_SERVER['PHP_SELF'], 11);

That function will output:

Current Page: 1 :: « Previous 1 2 3 4 5 6 7 8 9 10 ... 25 Next »

Current Page: 12 :: « Previous 1 ... 8 9 10 11 12 13 14 15 16 ... 25 Next »

Current Page: 16 :: « Previous 1 ... 16 17 18 19 20 21 22 23 24 25 Next »

Hope it helps.