[RESOLVED] Issue with 'foreach()' and arrays

[drunkencelt]

Hi,

I am working on extracting data from a form which updates a database table called 'race_admin'. I have assigned the data from the POST function to an array variable called $arr. I have then assigned the respective column names in my database table to another array variable called $carr.

I have then tried to combine the two using the 'foreach' function with 'and' to update the records in the DB table. As it will not work I've managed to debug the script which shows that the script does not like the 'and'.

I would welcome suggestions on how to get this to work or to achieve it using another method please.

Many thanks. 😕

My code:

<?php 
	$race_d = $_POST['race_date'];
	$open = $_POST['open_date'];
	$close = $_POST['close_d'];
	$fee = $_POST['fee'];
	$record = $_POST['record'];
	$fin_time = $_POST['finish_time'];
	$news = $_POST['news'];
	$start = $_POST['start_details'];
	$presentation = $_POST['presentation_details'];

$arr = array($race_d,$open,$close,$fee,$record,$fin_time,$news,$start,$presentation);

#foreach($arr as $result)
#{echo("<br /> $result");}

#connect to MySQL
$conn=@mysql_connect( "localhost", "jock", "bladerunner" )
	 	or die( "Err:Conn" );

#select the specified database
$rs = @mysql_select_db( "cheviot2000", $conn ) 
		or die( "Err:Db" );
#Assign column names to variable

$carr = array('race_date','open_date','close_date','entry_fee','cur_record','news','start_details','present_details','app_add','app_form','record_time');
echo("past stage");

#foreach($carr as $value)
#{echo("<br /> $value");}

foreach($carr as $value) and ($arr as $data)
	{
	mysql_query("update race_admin set $value = '$data' where id = 1", $conn ) or die("Query failed");
	}
#close connection to mysql
mysql_close();

echo("Complete");

?>

[NogDog]

I would recommend that you just create one array, with the key being the "$value" and the value being the "$data":

$arr = array('value1' => 'data one', 'value2' => 'data two');
foreach($arr as $value => $data)
{
   // ...
}

[drunkencelt]

Hi NogDog,

Many thanks for your reply. I've spent some time on this tonight after you pointed me in the right direction and I think I have almost got things to work.

With the following code, which I think is what you have suggested if my understanding is right, I get this result:

Key: $race_d Value: race_date
Key: $open Value: open_date
Key: $close Value: close_date
Key: $fee Value: entry_fee
Key: $record Value: cur_record
Key: $rec_time Value: record_time
Key: $news Value: news
Key: $start Value: start_details
Key: $presentation Value: present_details
Key: $application Value: app_add
Key: $form Value: app_form

I think it is treating the first argument of each element as a string instead of picking up the appropriate variable value from the POST assignations at the top of the page. When I remove the single quote marks the script will not run at all.

Can you suggest where I am going wrong?

Many thanks for your help.

My revised code:

<?php 
	$race_d = $_POST['race_date'];
	$open = $_POST['open_date'];
	$close = $_POST['close_d'];
	$fee = $_POST['fee'];
	$record = $_POST['record'];
	$rec_time = $_POST['record_time'];
	$news = $_POST['news'];
	$start = $_POST['start_details'];
	$presentation = $_POST['presentation_details'];
	$application = $_POST['app_add'];
	$form = $_POST['app_form'];

#connect to MySQL
$conn=@mysql_connect( "localhost", "jock", "bladerunner" )
	 	or die( "Err:Conn" );

#select the specified database
$rs = @mysql_select_db( "cheviot2000", $conn ) 
		or die( "Err:Db" );

#Process form information into array with key 
$arr = array('$race_d' => 'race_date','$open' => 'open_date','$close' => 'close_date','$fee' => 'entry_fee','$record' => 'cur_record','$rec_time' => 'record_time','$news' => 'news','$start' => 'start_details','$presentation' => 'present_details','$application' => 'app_add','$form' => 'app_form'); 

foreach($arr as $key => $value) 
	{
	echo ("Key: $key Value: $value<br />\n");
	#mysql_query("update race_admin set $value = '$data' where id = 1", $conn ) or die("Query failed");
	}
#close connection to mysql
mysql_close();

#echo("Complete");

?>

[NogDog]

If "race_d" is your key and "$race_d" is the associated value, then you need to transpose them in your array assignment:

$arr = array('race_d' => $race_d, <etc....>);

[drunkencelt]

Brilliant. Works a treat NogDog.

Thanks very much for your help AND I've learned some more PHP!