[RESOLVED] File Upload Problem Take 2

rsmith

Hey guys, same script as my last post "File Upload Problem". Now on my page I have it list all the information including the current photo that was uploaded using the original script. Problem is, now I need it to check and see if the user decides to change the photo it will upload the new image and update the path in the database. This part works great and I have it solid. The issue is that if the user doesn't change the picture and instead submits the form with a blank upload input, I get the error in my checking of "cannot upload file".

Here's the modified code:

				if($_POST['file'] != $listingPhoto){
					$target_path = "../propimages/listingPhotos/";

				$tmp_name = $_FILES['file']['tmp_name'];
				$name = $_FILES['file']['name'];
				if(!move_uploaded_file($tmp_name, "$target_path$name")){
					if(!is_writable($target_path)){
						echo "path not writable<br />";
					}
					echo "Could not upload the file<br />";
					echo "$target_path$name<br />";
					echo $target_path."<br />";
					exit();
				}else{
					$listingPhoto = "$target_path$name";
				}
				$listingPhoto = $listingPhoto;
			}

In this case $listingPhoto is passed as the path of the current image in a hidden field to the script. In essence what I'm trying to do is say that if the user doesn't provide a new picture to upload, then take the file passed from the hidden element and re-insert it into the db. I hope this makes sense. Like I said, the new photo update works great, I'm just stumped on how to tell it to use the hidden data (current photo path) if nothing is submitted for upload.

Much TIA!

ragedigital

If the user doesn't provide a photo, then why do anything - just skip the script.

rsmith

That's what it's supposed to do but I'm missing where to set that because the upload portion is just part of a much larger script that does error checking the queries, etc. Do I put the upload portion into another if statement saying if(!empty($_POST['file'])){}

rsmith

I think I've got it figured out. I need to see if the file size in the $FILES array is 0, if it is, i skip that part of the script. But how do I access an array element whose parent array is the value of a global array such as $FILES ? in essence, how do I directly access the size attribute in this print_r:

Array ( [file] => Array ( [name] => [type] => [tmp_name] => [error] => 4 [size] => 0 ) )

????

ragedigital

rsmith wrote:
if(!empty($_POST['file'])){}

I would just go with what you have here. If the POST'd variable is empty, then there's nothing to do.

As far as the array - are you loading multiple files at once?

rsmith

I thought that'd work too but it doesn't. I get my "cannot upload file" error. I'm trying to upload one file.

rsmith

I got it! Helps if you remember that you have to specify you're accessing the file in the $_FILES global array:

				if($_FILES['file']['size'] <= 0){ //this line was what was missing
					$listingPhoto = $_POST['listingPhoto'];
				}else{
						$target_path = "../propimages/listingPhotos/";

					$tmp_name = $_FILES['file']['tmp_name'];
					$name = $_FILES['file']['name'];
					if(!move_uploaded_file($tmp_name, "$target_path$name")){
						if(!is_writable($target_path)){
							echo "path not writable<br />";
						}
						echo "Could not upload the file<br />";
						echo "$target_path$name<br /><br />";
						echo $_FILES['array[size']."<br />";
						print_r($_FILES);
						exit();
					}else{
						$listingPhoto = "$target_path$name";
					}
				}