url query by $_GET or $_POST variable

[mikilugano]

Hello everyone, I have a question.
Which is the best solution to make a function that read the $_GET variable and create an url query?
My solution is the next...

foreach ($_GET as $variable => $value) {
  $conditions[] = "$variable=$value";
}
$urlquery = implode('&', $conditions);
$url = $_SERVER['PHP_SELF'] . '?' . $urlquery;

but I'm sure that it's not the best...

[benracer]

Well the main difference between them is if you want the end user to view the data being sent and also if the final result page is to be bookmarked?

[Weedpacket]

There's the [man]http_build_query[/man] function for this.

[mikilugano]

All right Weedpacket, but my host php version is 4, therefore the http_build_query function doesn't may be my solution!

[bradgrafelman]

Okay.. so replace this:

foreach ($_GET as $variable => $value) {
  $conditions[] = "$variable=$value";
}
$urlquery = implode('&', $conditions);
$url = $_SERVER['PHP_SELF'] . '?' . $urlquery; 

with this:

$url = $_SERVER['PHP_SELF'] . '?' . $_SERVER['QUERY_STRING'];

and you avoid problems such as a severely broken query string that you could/(probably would) have faced.