newb problems

evulskitz

ok first off... i'm not exactly a newbie.... i've been on and off php programing since v3.... but for reeealy simple stuff....

recently i took on a project that i want to incorperate alot of php into it (nothing spectacular)

heres my problem.

i have 4 pages
index.php - (main display page w/ script)
indexa.html - (pg2 w main display pages data)
indexb.html - (pg3 with its own data)
indexc.html - (pg4 with more data of its own)

i want visitors to be able to click the links located in/on the main template of the page to send my index.php?$unf=indexb.php
page index.php is supposed to, on first load load index.php with no ?$unf in url loads page indexa.html. so when link a b or c are clicked index.php reloads itsself displaying the content that $unf= defined....

from what i can see, this script should work... but nothing is displayed on the index.php page when i click my links

#script that is on index.php
#
<div class="wrap">
<div>//all links here</div><br />
<div align="center">
<?php
$unfunf = $_GET[$unf];

function mypage($syk;,$index;)
{
$syk = $index;
$index = 'indexa.html;
if ($syk='$index;')
{
echo '<?php include("$index;"); ?>';
}
else
{ 
echo '<?php include("$unfunf;"); ?>');
} 
}
?>
</div></div>

i'm sure somewhere someplace someones asked and fixed this many times, but i've spent like 2 days trying to figure this out... and so far i've found no way to do it, by "just reading"

any help with this would be greaaatly appreciated

Joseph07

First of all, your script is wrong. Secondly, I'm not too sure what you want to achieve here.

If you simply wants the user to click on the user and navigate to the pages, just use <a href="">bla</a>

function does not include a ;

It should be

function mypage($syk, $index) {

Next you did not call your function, how would you expect it to work?

The rest are also wrong, please specify what you want to achieve.

foyer

there is an error in your syntax on line 11

$index = 'indexa.html';

[edit]

and 12

if ($syk == $index)

and check lines 14 & 18

evulskitz

wops...

my intention is to use page index.php as the one page people access...
page 1, b, and c contain the content

index has the links with <a href="index.php?$unf=index(abor c).html">link</a>

showing the not calling the function was my mistake...

i didnt get all the code when i copied from my editor...

<div class="wrap"> 
<div>//all links here</div><br /> 
<div align="center"> 
<?php 
 //sets $unfunf to equal whatever$unf was defined as in the link clicked
$unfunf = $_GET[$unf];

// sets myPage as function with $syk, and $index as its variables
function myPage($syk;,$index;) 
{ 
$syk = $index; //tells php $syk is the same as $index
$index = indexa.html; //is supposed to tell php $index is indexa.html

//says that if $syk equals indexa.html then echo $index include, else echo $unfunf

if ($syk=$index;) 
{ 
echo '<?php include("$index;"); ?>'; 
} 
else 
{ 
echo '<?php include("$unfunf;"); ?>'); 
} 
} 
//calls entore function
myPage()
?> 
</div></div>

i want the page to load indexa.html into index.php when the user firsts visits the page, but when they click the link to open page 2, i want it to basicaly refresh index.php with indexb.html content

when i click my link to pass $unf=indexb.html back to index.php it should reload index.php with indexb.phps info...

from what i can see, it should work... i get no errors on page. all i get is a blank page when i load the index.php page, even when i put index.php?$unf=indexb.html in my address bar....

sry if its an agrivating question, but the one thing i havent done is worked with $get &post
and i'm probably doing this the hard way

any help would be appreciated

foyer

$unfunf = $_GET[$unf];

this is wrong. $unf is a undefined variable. your URL is wrong too.. remove the dollar sign.

$_GET[unf];

that will work.

function myPage($syk,$index) no ; necessary

$syk = $index; this seems pointless..

$index = 'indexa.html';

if ($syk == $index)

echo '<?php include($index); ?>';

echo '<?php include($unfunf); ?>';

You will need to make these changes...

crazy_fool

Why are you using

echo '<?php include($index); ?>';

Your code should look something like this

if ($syk=$index;)
{
include("$index");
}
else
{
include("$unfunf;");
}
}

foyer

hah, yeah true.. I wasn't even paying attention to the logic just the syntax..

crazy_fool

lol yeh. Well that is why it was showing just a blank page 🙂

Joseph07

What you can do is this.

// THIS IS index.php
// HTML CODES

echo "<a href=\"index.php?page=indexa\">Page 2 | </a>";
echo "<a href=\"index.php?page=indexb\">Page 3 | </a>";
echo "<a href=\"index.php?page=indexb\">Page 4</a>";

// Using switch method to get the page
switch ( $_GET['page'] ) {
 // To load page 2
 case 'indexa':
   include 'indexa.html';
 // To load page 3
 case 'indexb';
   include 'indexb.html';
 // To load page 4
 case 'indexc';
   include 'indexc.html';
 // Default page to load
 default:
   include 'index.php';
}

// HTML codes

This above has not been tested and might contain syntax error. But it should give you an idea how it works.

I used switch case method instead of if..else statement. You can change it to if..else method if you want.

evulskitz

woops i forgot about switch/case....

er, ok
am i assuming correct when i say this:

case/switch is kinda a looped if/else?

its basicaly saying:
it loads default; and includes the data normaly shown when the page is first entered

if $page=indexa.html then include it,
if $page=indexb.html then include it.
when there is no $page definition found when $_GET is executed, it runs default again?

echo "<a href=\"index.php\">Home | </a>"; 
echo "<a href=\"index.php?page=indexb\">Page2 </a>|"; 
echo "<a href=\"index.php?page=indexc\">Page 3 </a>|"; 
echo "<a href=\"index.php?page=indexd\">Page 4 </a>|";

in this case, "home" will load indexa.html content when no $_GET data is available...

this will work right?
...............

this is pretty much my last step to finishing this website heh
already have my forms, and my comment submission scripts done and working fine...
i have never tried to use 1 page for static and load everything into that 1 page like this.... wasn't exactly sure how to go about doing it, but i got ahead of myself, i should have made sure the page switching worked first, i assumed i was calling $_GET in the right place... and checking it with an IF in the right place...

hense why i posted in the newb section 🙂

thnx for the help

evulskitz

well, it works, sort of...

its loading the pages atleast now

<div align="center"> 
<div align="center"><? 
echo "<a href=\"indexa.php?page=indexa\">Home | </a>"; 
echo "<a href=\"indexa.php?page=indexb\">Page2 </a>|"; 
echo "<a href=\"indexa.php?page=indexc\">Page 3 </a>|"; 
echo "<a href=\"indexa.php?page=indexd\">Page 4 </a>|";
?>
 </div>
 <br />  

<div align="center"> 
<?php 
	switch ( $_GET['page'] ) { 
// To load page 2 
	case 'indexa': 
   include 'indexa.html'; 
// To load page 3 
	case 'indexb'; 
   include 'indexb.html'; 
// To load page 4 
	case 'indexc'; 
   include 'indexc.html'; 
// Default page to load 
	default: 
   include 'indexa.html'; 
   }
?> 
</div>
</div>

when i load index.php into my browser, it shows my indexa content like i want
but when i click link 2, 3, and 4 things weird go on

link 2: loads pages 2 and 3 and the default
link 3 loads page 3 and the default
and page 4 loads the default...

is this supposed to happen?

{edit: oh and when i click on home it loads all 4 links into the page....}

i just want to load index.php, have it display indexa by default, when user clicks a link it swaps my include to the appropriate data sent viak the link (index.php?page=indexa/b/c) and display the included data in the spot i have the include in. not load all sqeuential includes after the link thats clicked...

evulskitz

d'oh, mind you there is no indexd.html in the directory

using the above codeing on indexa.php, here is whats going on....

http://nffsolutions.org/testserv/test/indexa.php

Joseph07

I'm sorry for my stupid mistake. You should add in a break; after all the case except for default:

<div align="center">
<div align="center"><?
echo "<a href=\"indexa.php?page=indexa\">Home | </a>";
echo "<a href=\"indexa.php?page=indexb\">Page2 </a>|";
echo "<a href=\"indexa.php?page=indexc\">Page 3 </a>|";
echo "<a href=\"indexa.php?page=indexd\">Page 4 </a>|";
?>
</div>
<br />  

<div align="center">
<?php
    switch ( $_GET['page'] ) {
// To load page 2
    case 'indexa':
   include 'indexa.html';
   break;
// To load page 3
    case 'indexb';
   include 'indexb.html';
   break;
// To load page 4
    case 'indexc';
   include 'indexc.html';
   break;
// Default page to load
    default:
   include 'indexa.html';
   }
?>
</div>
</div>

laserlight

I'm sorry for my stupid mistake. You should add in a break; after all the case except for default:

It's okay, I read through your code and did not notice it either :p

I might suggest an alternative to a switch structure in this case, namely to use an array:

<a href="indexa.php?page=indexa">Home</a> |
<a href="indexa.php?page=indexb">Page 2</a> |
<a href="indexa.php?page=indexc">Page 3</a> |
<a href="indexa.php?page=indexd">Page 4</a> |

<?php
$pages = array('indexa', 'indexb', 'indexc', 'indexd');
if (isset($_GET['page']) && in_array($_GET['page'], $pages)) {
    // Load the page selected.
    include $_GET['page'] . '.html';
} else {
    // Load the default page.
    include 'indexa.html';
}
?>

A variant of this method can be used when $GET['page'] may not necessarily be used in the actual name of the file to include:

<?php
$pages = array('indexa' => 'indexa.html',
               'indexb' => 'indexb.html',
               'indexc' => 'indexc.html',
               'indexd' => 'indexd.html');
if (isset($_GET['page']) && array_key_exists($_GET['page'], $pages)) {
    // Load the page selected.
    include $pages[$_GET['page']];
} else {
    // Load the default page.
    include 'indexa.html';
}
?>

Joseph07

I think it's fine too. Shall leave the ultimate decision to the user.

evulskitz

hah, i finaly get ahold of my php mentor... (been on vacation since thanksgiving... must be nice) anyway...
i showed him the code, and THIS

<?php 
switch ( $_GET['page'] ) {  

//solutions	  

	case 'solut';
   	include 'inc/solut.html'; 
break;
// management  

    case 'manage'; 
   	include 'inc/manage.html'; 
break;
// contact
    case 'contact'; 
   	include 'inc/contact.html'; 
break;
 	case 'about'; 
  	include 'inc/about.html'; 
break;
    default;
	include 'inc/indexa.html';
break;
   } 
?>

works exactly how i wanted
...

no one mentioned break;
:-p

evulskitz

OMG
lol
within 5 minutes everyone comes up with the break; idea
....

thanks guys

which, of these would work the best?
or do they all do the same thing, just different ways

Joseph07

It's just a different way to doing the same things.

I'm more comfortable with switch thus, using it.

laserlight

which, of these would work the best?
or do they all do the same thing, just different ways

I find it easier to see the mapping using an array, especially since associative arrays in PHP really are maps. On the other hand, there is the negligible overhead of having to initialise the array, and the fall through (i.e., no break) of a switch can come in handy if you want to specify more than one option to map to a file. With an array this means duplication.

What you should note is that my example checks that $_GET['page'] exists by using isset, but Joseph07's does not. So if you want to use a switch, remember to check with [man]isset[/man] or [man]empty[/man] before using the incoming variable in the switch.

Joseph07

Correct, you should add in some checks.

I don't suppose I should do the whole scripts out right. LOL