[RESOLVED] How to get value from string in db?

tito

Hello,

I have an id field in database that has a string
some rows read

12 50 25 31

some others

14 51 25 45

others

18 32 21 44

and in that example the first 2 have a common value of 25

I have a $_REQUEST['id'] of 25

I'd like to make a WHERE query to retrieve the rows that contain that value of 25

Please how to do that?

Thank you.

tito

hummm... I appear to have solved that using

like %$id%'

can someone please confirm that this is proper?

laserlight

More like: like '%$id%'

On the other hand, it is likely that your database schema is not appropriate to begin with. You should not have such multi-valued fields.

tito

Thanks. So you think I should serialize them?

laserlight

No, I think you should use another table for them. Of course, whether that really is the correct decision depends on the larger picture of what data you are dealing with, and with the given information it is hard to say.

Piranha

As laserlight says the best thing you can do is to use a correct database design. Read up on database normalization to understand why and how you should design the database.

There are workarounds to the problems with a database design that is not normalized. But they are harder to develop, and it will take longer. In addition to that they require more resources to handle the database request and take longer time to run. You will be best of to redesign the database to at least normal form 3, in the long run you will gain both time and effort.

tito

oh no, the maximum such data that will be in there is 4 or 5. I must put it in that table or do multiple queries all over. I have a function in that table to retrieve all fields in there in an array, such as username, email etc ... and if the query $id matches '%$id' then I am already there.

I can also do a $getuser($user) anywhere and have all those values.
For example before updating table I do a $getuser($user) then $getuser[fieldname]. This way in some instance I could get away without a query by doing an explode and in_array($id, $getuser[fieldname])

laserlight

I must put it in that table or do multiple queries all over.

You are mistaken, because there is something called a join.

tito

how do you do a join with a vbulletin function fetch_userinfo($userid), without altering the function???

laserlight

how do you do a join with a vbulletin function fetch_userinfo($userid)?

You don't join PHP functions, obviously.. What has vbulletin got to do with this? You did not mention it earlier when I pointed out that more information was needed to determine the correct decision.

tito

Please explain. One minute you tell me to do a join, another you tell me you don't!

laserlight

One minute you tell me to do a join, another you tell me you don't!

One minute I tell you to join database tables, the next minute I tell you not to join PHP functions. I don't see a problem with that 😉

tito

Ok, then, I see you edited the post... then now you understand why it must be in that table and no join can be done, unless you want to queries all over to retrieve values.

laserlight

then now you understand why it must be in that table and no join can be done, unless you want to queries all over to retrieve values.

Actually, I don't. You simply have not provided enough information.

I am guessing that you are limited by an external (vbulletin) API, thus if you want to use that API, a join is not possible. On the other hand, it appears you have control over the database schema, so a join should be possible by extending the API to include your own functions.

tito

Thanks but no thanks. I am avoiding altering vbulletin so I am not doomed to make the same changes over and over at every upgrade.

But anyway, thanks for your time, and happy new year.

laserlight

I am avoiding altering vbulletin so I am not doomed to make the same changes over and over at every upgrade.

hmm... but arent you making a bigger change to vbulletin by changing the database schema?

But anyway, thanks for your time, and happy new year.

Happy new year too!

tito

laserlight wrote:
hmm... but arent you making a bigger change to vbulletin by changing the database schema?

no sir. I gather you are not familiar with vbulletin. You can alter database as you like.
Their code is a++. This is why there are thousands of hacks available for them.

laserlight

I gather you are not familiar with vbulletin.

Indeed, I have never had opportunity to work with the vbulletin code base.

You can alter database as you like.

I daresay that is an exaggeration, but nevermind 🙂

Their code is a++. This is why there are thousands of hacks available for them.

Aye, so why write a hack when you can add to their excellent code base? If their code is as good as you say it is, extending the API should be easy.

tito

you do hacks so you extend the functionality. I recommend that you take a look at www.vbulletin.org which is like a hack database.

They provide you with a wide array of hooks so you don't have to edit the files. But hooks are not everywhere, and certainly not at the desired functions. I have a site which started with 12 columns in a table and have grown to close to 40 columns. Have upgraded many times, never a problem, and that site is very fast with 25,000 users.

BTW, this forum here uses vbulletin too.

laserlight

you do hacks so you extend the functionality. I recommend that you take a look at www.vbulletin.org which is like a hack database.

I think you mistake my meaning of "hack" here. I mean "quick and ugly fix", not "feature extension". So you can write a vbulletin hack that is (paradoxically) not a hack, but rather a well designed feature extension, or a "modification" to use vbulletin jargon.