[RESOLVED] For Loop Makin' Me Loopy

[Skor]

I haven't done many for loops, but this one's making me a little nutty. What I'm trying to do is increment the field names, starting at 1, up to the number of rows that are returned from the query. I've gotten to return either two rows (which is correct), the the $i variable stays at 1 for both entries. Or, I've gotten four rows to return (which is wrong) and the $i variable, goes 1-2 1-2. Not what I want either. I suspect(or hope) that I've made a simple error and just need a more experienced set of eyes. Thanks in advance.

$result = mysql_query($query) or die('Query not successfully processed: ' . mysql_error());
$num_rows = mysql_num_rows($result);
//echo "Number of rows: $num_rows";

// get each row
while($row = mysql_fetch_assoc($result)) {


$cat = $row["cat_code"];
$pid = $row["pid"];
$name = $row["name"];
$price = $row["price"];			
$units = $row["units"];	
    $qty = $row["qty"];	
$itemname = $name.'('.$cat.$pid.')';

echo "<tr valign=\"top\">";
[COLOR="Red"]
for($i=1; $i <= $num_rows; $i++)  --is this where the problem is?[/COLOR]
{
echo "<td>$name<input name=\"product$i\" type=\"hidden\" value=\"$itemname\"></td>";
echo "<td> $$price<input name=\"price$i\" type=\"hidden\" value=\"$price\"></td>";
echo "<td><select name=\"qty$i\">
<option value=\"0\" selected=\"selected\">Select quantity</option>
<option value=\"1\">1</option>
<option value=\"2\">2</option>
<option value=\"3\">3</option>
</select>";
echo "<input name=\"scode$i\" type=\"hidden\" value=\"$pid\">
<input name=\"units$i\" type=\"hidden\" value=\"$units\"></td></tr>";
}
 }

[NogDog]

The problem is the for loop within the while loop, causing the for loop to go through all its iterations each time through the while loop. Here's one fairly simple change that should do the trick:

$result = mysql_query($query) or die('Query not successfully processed: ' . mysql_error());
$num_rows = mysql_num_rows($result);
//echo "Number of rows: $num_rows";

// get each row
$i = 1; // counter for field names
while($row = mysql_fetch_assoc($result)) {
   $cat = $row["cat_code"];
   $pid = $row["pid"];
   $name = $row["name"];
   $price = $row["price"];			
   $units = $row["units"];	
   $qty = $row["qty"];	
   $itemname = $name.'('.$cat.$pid.')';
   echo "<tr valign=\"top\">";
   echo "<td>$name<input name=\"product$i\" type=\"hidden\" value=\"$itemname\"></td>";
   echo "<td> $$price<input name=\"price$i\" type=\"hidden\" value=\"$price\"></td>";
   echo "<td><select name=\"qty$i\">
   <option value=\"0\" selected=\"selected\">Select quantity</option>
   <option value=\"1\">1</option>
   <option value=\"2\">2</option>
   <option value=\"3\">3</option>
   </select>";
   echo "<input name=\"scode$i\" type=\"hidden\" value=\"$pid\">
   <input name=\"units$i\" type=\"hidden\" value=\"$units\"></td></tr>";
   $i++; // increment the counter
}

[Skor]

That worked perfectly, thanks. I appreciate the explanation as well.

I would like to ask one more question. For the quantity drop down, I'd like to generate/populate that dynamically as well.

<option value=\"0\" selected=\"selected\">Select quantity</option>
   <option value=\"1\">1</option>
   <option value=\"2\">2</option>
   <option value=\"3\">3</option>
   </select>";

how would I iterate through the $qty variable and only generate the number of option choices for the quantity(in the example 3). Would that be within the while loop as well, or would I need to do a for loop for that one?

[NogDog]

Now that would be a good place for a for loop.

for($num = 0; $num <= 3; $num++)
{
   echo "<option value='$num'";
   if($num == 0) { echo " selected='selected'"; }
   echo ">$num</option>\n";
}

[Horizon88]

If I understand what you're asking, you'll want a for loop, since in that case, you'd want to run it all the way through on each iteration of the while loop.

Edit: Well, at least you're not one of those moderators 😛

[Skor]

Rather than using a finite number, I need to pull in a database value($qty). Unfortunately I'm getting a unexpected T_STRING, expecting ',' or ';' error which I'm usually able to figure out, but haven't thus far.

for($num = 0; $num <= $qty; $num++)
{
   echo "<option value=\"$num\""; --this is the line with the suspect error:confused: 
   if($num == 0) { echo " selected=\"selected\">Select quantity";
}
   echo ">$num</option>\n";
}   

echo "</select>";

[Skor]

A missing double-quote. I'm good to go, thanks sooo much.