php form insert blanks to mysql

[Wales]

I can't figure out why when the fields on the form is blank and I click register it registers blank fields to mysql.

<?php
if ( isset ($_POST['register'])) {

$problem = FALSE;
//Is it empty?
	if (empty ($_POST['username'])) {
		$problem = TRUE;
		echo 'Please enter a username.';
	}
	if (empty ($_POST['password'])) {
		$problem = TRUE;
		echo 'Please enter a password.';
	}
	if (empty ($_POST['cpassword'])) {
		$problem = TRUE;
		echo 'Confirm password is empty.';
	}
	if	($_POST['password'] != $_POST['cpassword']) {
		$problem = TRUE;
		echo 'Your passwords do not match.';
	}
	if (empty ($_POST['email'])) {
		$problem = TRUE;
		echo 'Please enter an email.';
	}

$ip = getenv('REMOTE_ADDR');
$username = trim(mysql_real_escape_string($_POST['username']));
$password = sha1(trim(mysql_real_escape_string($_POST['password'])));
$email = trim(mysql_real_escape_string($_POST['email']));

$insert = "INSERT INTO members (ip, username, password, email, date_entered) VALUES ('$ip', '$username', '$password', '$email', NOW())";
if (@mysql_query ($insert)) {
	echo 'Thanks for registering.';
} else {
	echo 'There was a problem registering. Please try again.';
}
mysql_close();


}
?>
<form method="post" action="register.php">

<label>Username</label><br/><input name="username" maxlength="20"  /><br/>

<label>Password</label><br/><input name="password" type="password" maxlength="20" /><br/>

<label>Confirm Password</label><br/><input name="cpassword" type="password" maxlength="20" /><br/>

<label>Email</label><br/><input name="email" maxlength="50" /><br/>

<input type="submit" name="register" value="Register" />

[NogDog]

As far as I can see, all you do when a field is not filled out is set the $problem variable to true and output a message, but there is no conditional logic later to check the value of $problem to decide whether or not to process the input data.

[alanzhao]

look carefully see what I've changed

<?php
if ( isset ($_POST['register'])) {

$problem = FALSE;
//Is it empty?
    if (empty ($_POST['username'])) {
        $problem = TRUE;
        echo 'Please enter a username.';
    }
    else if (empty ($_POST['password'])) {
        $problem = TRUE;
        echo 'Please enter a password.';
    }
   else  if (empty ($_POST['cpassword'])) {
        $problem = TRUE;
        echo 'Confirm password is empty.';
    }
  else   if    ($_POST['password'] != $_POST['cpassword']) {
        $problem = TRUE;
        echo 'Your passwords do not match.';
    }
  else  if (empty ($_POST['email'])) {
        $problem = TRUE;
        echo 'Please enter an email.';
    }

if ($product == false) {
[INDENT]
$ip = getenv('REMOTE_ADDR');
$username = trim(mysql_real_escape_string($_POST['username']));
$password = sha1(trim(mysql_real_escape_string($_POST['password'])));
$email = trim(mysql_real_escape_string($_POST['email']));

$insert = "INSERT INTO members (ip, username, password, email, date_entered) VALUES ('$ip', '$username', '$password', '$email', NOW())";
if (@mysql_query ($insert)) {
    echo 'Thanks for registering.';
} else {
    echo 'There was a problem registering. Please try again.';
}
mysql_close();[/INDENT]
}


}
?>
<form method="post" action="register.php">

<label>Username</label><br/><input name="username" maxlength="20"  /><br/>

<label>Password</label><br/><input name="password" type="password" maxlength="20" /><br/>

<label>Confirm Password</label><br/><input name="cpassword" type="password" maxlength="20" /><br/>

<label>Email</label><br/><input name="email" maxlength="50" /><br/>

<input type="submit" name="register" value="Register" />

[NogDog]

alanzhao wrote:

look carefully see what I've changed

if ($product == false) {

That should be...

if($problem == false) {

[Wales]

So all I have to do is enclose this block

$ip = getenv('REMOTE_ADDR');
$username = trim(mysql_real_escape_string($_POST['username']));
$password = sha1(trim(mysql_real_escape_string($_POST['password'])));
$email = trim(mysql_real_escape_string($_POST['email']));

$insert = "INSERT INTO members (ip, username, password, email, date_entered) VALUES ('$ip', '$username', '$password', '$email', NOW())";
if (@mysql_query ($insert)) {
    echo 'Thanks for registering.';
} else {
    echo 'There was a problem registering. Please try again.';
}
mysql_close();}

with

if ($problem == false) {}

Is it correct if I set $problem = false or does it actually have to be $problem == false? So in the //Is it empty? section should by $problem be $problem == true instead of $problem = true?

Thanks for the help it worked.

How can I use

    if (empty ($_POST['username'])) { 
        $problem = TRUE; 
        echo 'Please enter a username.'; 
    } 

and echo out 'Please enter a username' next to

<label>Username</label><br/><input name="username" maxlength="20"  />

It automatically echos when I go to the page if I try this:

<label>Username</label><br/><input name="username" maxlength="20"  />
  <?php  if (empty ($_POST['username'])) { 
        $problem = TRUE; 
        echo 'Please enter a username.'; 
    } 
?>