Knowledge Asked.

tsarma

if(isset($_POST['name']) && strlen($_POST['name'])) {
// do somthing.
} else {
// reject it.
}

So, I saw above line in PHP BOOK. Is the 1st condition here 'isset($_POST['name'])' not redundent as i think?
thanks

laserlight

Is the 1st condition here 'isset($_POST['name'])' not redundent as i think?

Yes. You should check if incoming variables exist with [man]isset[/man], [man]empty[/man], or possibly [man]array_key_exists/man before using them.

tsarma

wow thanks for the prompt reply,
Yes i have to check if incoming variables exit with isset, empty and etc... but as in my code, given that 2nd condition 'strlen($POST['name'])' which i think indirectly checks if the variable is set. I am assumming the 1st condition is redundent.
or in other words 'if( strlen($POST['name']))' alone doesn't do the same job.
thanks

wilku

using strlen on undefined variable would generate Notice. You first check if it's defined and if so, if it is not empty. Normally notices doesn't show, but if you want to produce strictly clean code, you should avoid notices.

laserlight

but as in my code, given that 2nd condition 'strlen($POST['name'])' which i think indirectly checks if the variable is set. I am assumming the 1st condition is redundent.
or in other words 'if( strlen($POST['name']))' alone doesn't do the same job.

Yes, it is redundant in that sense. However, passing $_POST['name'] to strlen() is considered using it, so the check should still be done.

tsarma

That explains, Thanks