Database issues on certain pages.

god0fgod

All my scripts have worked before before I tried PHP5. When it didn't work I switched back to PHP4. I am getting database issues with PHP4 now when I didn't before. It only occurs on certain pages. Example:

Page works - http://www.godofgod.co.uk

Code:

mysql_connect("localhost","user","pass");
@mysql_select_db(database) or die( "There has been an error in your request. Please try again! Error: Unable to select database.");

//Just a snippet of everything below for videos.

$query = "SELECT title, id, url, description FROM videos ORDER BY id DESC";
$result2 = mysql_query($query);
$row1 = mysql_fetch_array($result2);
$title2 = $row1['title'];
$ida = $row1['id'];
$url = $row1['url'];
$extract = strip_tags($row1['description']);

//[...]

mysql_close();

Page doesn't work - http://www.godofgod.co.uk/articles/view_article.php?id=27

Code:

mysql_connect("localhost","user","pass");
@mysql_select_db(database) or die( "There has been an error in your request. Please try again! Error: Unable to select database.");
$query="SELECT * FROM articles WHERE id=$id";
$result = mysql_query($query);

if(!$result){
die('Couldn\'t read database.');
};

$row = mysql_fetch_array($result);

$title = $row['title'];
$date = $row['date'];
$body1 = $row['body'];

//[...]

@mysql_select_db(database) or die( "There has been an error in your request. Please try again! Error: Unable to select database.");
$query = "UPDATE articles SET views = $views WHERE id = $id";
$result = mysql_query($query);

$query = "SELECT id FROM users WHERE username = '$username'";
$result = mysql_query($query);

$row = mysql_fetch_array($result);
$id_user = $row['id'];


mysql_close();

Can I do anything about this? I'm trying to get my webhost to look at it yet they are being really slow at the moment. It's been like this since the beginning of January.

Thanks for any help given.

rulian

I dont see you setting the $id variable before the sql,
the first page that works has no variable in it's sql

retrieve the $GET variable and assing it to $id;
in PHP 5 you use $GET["id"], i think in 4 you had to use a different method, not sure,

I suggest you read up on sql injections to protect your database as well

your page dies at the $results if statement, which means your sql isnt going through, to help you troubleshoot,
die(mysql_error()) indead of die('Couldn\'t read database.');

god0fgod

Thanks for the reply. The PHP version should be set to 4. It might have got stuck to PHP 5 somehow. I made the new code:

$id2 = $_GET["id"];

$id = mysql_escape_string($id2);

echo $id;

It echos the id fine but still doesn't like it. I get the new error:

There has been an error in your request. Please try again! Error: Unable to select database.

From this line obviously:

@mysql_select_db(database) or die( "There has been an error in your request. Please try again! Error: Unable to select database.");

Okay, this is odd. The PHP version is 4.4.7. All details on this page - http://www.godofgod.co.uk/articles/view_article.php

god0fgod

rulian wrote:
your page dies at the $results if statement, which means your sql isnt going through, to help you troubleshoot,
die(mysql_error()) indead of die('Couldn\'t read database.');

Yes I tried this before and it said it was unable to connect. The exact error:

Can't connect to MySQL server on 'mysqldb' (111)

If there is no way to fix this via changing the code please say so. I need something to convince my webhost that this isn't a scripting problem and is a database problem.

rulian

check your connection settings, its good practise to have a single file with the db connectivity, so each page can share the settings.
you could simply have it right on one page and not the other.

god0fgod

Do you see a problem with the script above. And like I've said, the scripts worked fine before on PHP4.

rulian

your connection is failing:
mysql_connect("localhost","user","pass");
you obviously didnt use your real username / passwords

make sure those are right on that page, or better, have universal connection file
and share the seetings

file mysql.php:
<?PHP
$CONN = mysql_connect("localhost","user","pass");
if ($CONN) mysql_select_db("mydb");
else die(mysql_error());
?>

in your files now use:
require("mysql.php')";

god0fgod

Perhaps I should but still the connection is absolutely fine and has worked before how it is now, exactly.

Perhaps a universal connection file will work. If it doesn't the whole website will be down. I'll try it.

Thanks.

Pinpointed the issue -
Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)

Hopefully my webhost will know what to do with that file. I wont resolve this yet in case anything else happens.