[RESOLVED] 3 include file instances only one working?

[ozzie01]

Hi,

Any help appreciated. (please keep it simple).

I've set up a banner rotation script.

The script didn't allow for different banner sizes, so I installed the same script into the following directories using different databases for each banner size.

EG - 125x125 banners, 120x600 banners & 468x60 banners.

The include code I use to action the script and display the banners is:

<?php include('468x60/viewbanner.php');?>

<?php include('125x125/viewbanner.php');?>

<?php include('120x600/viewbanner.php');?>

I also need to call the banners from different URL's so I use this:

<?php readfile('http://domain-where-script-is.com/468x60/viewbanner.php');?>

<?php readfile('http://domain-where-script-is.com/125x125/viewbanner.php');?>

<?php readfile('http://domain-where-script-is.com/120x600/viewbanner.php');?>

My Problems is:

Calling two or more instances of the script on any page (internal or external) only displays the first included banner.

EG - If I want to display a 468x60 banner and a 120x600 banner, it only shows the first banner.

I've used includes before and have used up to 5 or 6 different includes on one page and have never had this issue before.

Anyway idea as to why this maybe causing an issue now?

Cheers

[daveyc]

Hi

Could you post the code of all three php files so we can all help you more quickly.

Remember to wrap it in the PHP tags.

Davey

[ozzie01]

Hi,

The connect.php file is the database connection info. All banner directories have this in them but have been changed to to point to each banner folder:

<?php
define ('DB_USER', 'removed);
define ('DB_PASSWORD', 'removed');
define ('DB_HOST', 'localhost');
$dbc = mysql_connect (DB_HOST, DB_USER, DB_PASSWORD);
mysql_select_db('adbutterfly');

define(adpath,'http://www.domain-where-script-is.com/120x600/');
?>

Here is the viewbanner.php all 3 instances of this are the same.

<?php 
include("connect.php");

function get_user_ip() {
	$ipParts = explode(".", $_SERVER['REMOTE_ADDR']);
	if ($ipParts[0] == "165" && $ipParts[1] == "21") {    

		if (getenv("HTTP_CLIENT_IP")) {
			$ip = getenv("HTTP_CLIENT_IP");
		}
		elseif (getenv("HTTP_X_FORWARDED_FOR")) {
			$ip = getenv("HTTP_X_FORWARDED_FOR");
		}
		elseif (getenv("REMOTE_ADDR")) {
			$ip = getenv("REMOTE_ADDR");
		}
	}
	else {
		return $_SERVER['REMOTE_ADDR'];
	}
	return $ip;
}

$get_banner = @mysql_query("SELECT * FROM banners ORDER BY RAND()");

$isgood = false;

while($each_banner = @mysql_fetch_array($get_banner)) {
	$isgood = true;
	$doquery = @mysql_query("SELECT * FROM banners WHERE `id`='$each_banner[0]'");
	$thero = @mysql_fetch_row($seeresult);

if($thero[5] == 'OFF') {
	break;
}

$newrow = @mysql_fetch_row(@mysql_query("SELECT * FROM stats WHERE `id`='$each_banner[0]'"));
$hits1 = $newrow[6];
$views1 = $newrow[8];
$todayis = date('m') . '/' . date('d') . '/' . date('Y');

if($isgood == true) {
	$breakit = explode(',',$thero[5]);
	$part1 = $breakit[0];
	$part2 = $breakit[1];
	if($part1 == 'V') {
		if($part2 > $views1) {
			$isgood = false;
		}
	}
	else {
		if($part1 == 'H') {
			if($part2 > $hits1) {
				$isgood = false;
			}
		} 
		else {
			if($part1 == 'D') {
				$off = false;
				$rowd = explode('/',$part2);
				$month = $rowd[0];
				$day = $rowd[1];
				$year = $rowd[2];
				$myday = date('d');
				$mymonth = date('m');
				$myyear = date('Y');

				if($myyear == $year) {
					if($mymonth == $month) {
						if($myday == $day) {
							$off = true;
						}
					}
				}

				if($off == false && $myyear > $year) {
					$off = true;
				}

				if($off == false && $mymonth > $month && $myyear >= $year) {
					$off = true;
				}

				if($off == false && $myday > $day && $mymonth >= $month && $myyear >= $year) {
					$off = true;
				}

				if($off == false) {
					$isgood = true;
				}
			}
		}
	}
}
if($isgood == true) {break;}
}

if($isgood == false) {
	echo "No banners to display";
	exit();
}

$user_ip = get_user_ip();
$get_ip = @mysql_query("SELECT * FROM ips WHERE `viewip`='$user_ip'");

if(@mysql_num_rows($get_ip) <= 0) {
	$unique = true;
	$add_ip = @mysql_query("INSERT INTO ips (`viewip`) VALUES ('$user_ip')");
}
else {
	$unique = false;
}

$banner_stat = @mysql_fetch_array(@mysql_query("SELECT * FROM stats WHERE id='$each_banner[0]'"));
$width = $banner_stat[3];
$length = $banner_stat[4];
$views = $banner_stat[7];
$uni_views = $banner_stat[8];
$views++;

if($unique == true) {
	$uni_views++;
}

$update_stat = @mysql_query("UPDATE stats SET `views`='$views',`uni_views`='$uni_views' WHERE id='$each_banner[0]'");

$id = $each_banner[0];
$openmode = $each_banner[7];

if($myrow[2] == 'NONE') {
	$mouseover = '';
}
else {
	$mouseover = $each_banner[2];
}

$location = $each_banner[3];
$urlto = $each_banner[4];

if($banner_stat[width] == 'NA' || $banner_stat[length] == 'NA') {
	$dosize = NULL;
}
else {
	$dosize = 'width="' . $width . '" height="' . $length . '"';
}

$link = 'href="'.adpath.'catchadd.php?id='.$id.'" target="_blank"';
?>
<a <? echo $link;?> ><img src="<? echo $location;?>" alt="<? echo $mouseover;?>" <? echo $dosize;?> border="0"></a>

Also catchadd.php is included in the above code:

<?php
function get_user_ip(){       

	$ipParts = explode(".", $_SERVER['REMOTE_ADDR']);
	if ($ipParts[0] == "165" && $ipParts[1] == "21") {    

    	if (getenv("HTTP_CLIENT_IP")) {
        	$ip = getenv("HTTP_CLIENT_IP");
        } elseif (getenv("HTTP_X_FORWARDED_FOR")) {
            $ip = getenv("HTTP_X_FORWARDED_FOR");
        } elseif (getenv("REMOTE_ADDR")) {
            $ip = getenv("REMOTE_ADDR");
        }
    } else {
       return $_SERVER['REMOTE_ADDR'];
   	}
   	return $ip;
}

include("connect.php");

$id = $_GET['id'];

$banner = @mysql_query("SELECT * FROM banners WHERE `id`='$id'");

if(@mysql_num_rows($banner) <= 0 ){
	header("Location: add.php");
	exit();
}
$banner_info = @mysql_fetch_array($banner);
$addressto = "Location: " . $banner_info[4];

$user_ip = get_user_ip();
$check_count = @mysql_query("SELECT * FROM ips WHERE `visitip`='$user_ip'");
$count = @mysql_num_rows($check_count);

if($count == 0){
	$unique = true;
	$insert_ip = @mysql_query("INSERT INTO ips (`visitip`) VALUES ('$user_ip')");
} else {
	$unique = false;
}
$banner_stat = @mysql_fetch_array(@mysql_query("SELECT * FROM stats WHERE `id`='$id'"));

$hits = $banner_stat[5];
$uni_hits = $banner_stat[6];
$hits++;


if($unique == true){
	$uni_hits++;
}

$update_banner = @mysql_query("UPDATE stats SET `hits`='$hits' , `uni_hits`='$uni_hits' WHERE id='$id'");

header($addressto);
exit();
?>

Have to add in another post I ran out of character allowed.

[ozzie01]

COLOR="Blue"]And for some reason it also calls add.php[/COLOR], though this files is used to add banners in the admin area so I have no idea why it's calling it? But have included anyway:

<?php
include("connect.php");

function is_valid_date($date) {
	list($month,$day,$year) = explode("/",$date);
	if($month > 12 || $month < 01 || strlen($month) != 2 || !is_numeric($month)) {return false;}
	if($day > 31 || $day < 1|| strlen($day) != 2 || !is_numeric($day)) {return false;}
	if(strlen($year) != 4 || !is_numeric($year)) {return false;}
	return true;
}
if($_POST['submitid'] == 1) {
	//Form validation
	if(strlen($_POST['name']) < 3){$message = 'Please enter a name for the banner';}
	if($_POST['locationtype'] == 'http' && strlen($_POST['httploc']) < 3 && $message == NULL){$message = 'Please enter location URL';}
	if($_POST['locationtype'] == 'upload' && $_FILES['filename']['name'] == NULL && $message == NULL){$message = 'Please enter a filename';}
	if(strlen($_POST['urlto']) < 3 && $message == NULL){$message = 'Please enter a URL location';}
	if($_POST['stopit'] == 'hits' && !is_numeric($_POST['hits'])  && $message == NULL){ $message = 'Invalid Hit amount to stop on';}
	if($_POST['stopit'] == 'views' && !is_numeric($_POST['views']) && $message == NULL){ $message = 'Invalid Views amount to stop on';}
	if($_POST['stopit'] == 'date' && is_valid_date($_POST['id1']) == false && $message == NULL){ $message = 'Invalid date to stop on';}
	if($_POST['size'] == 'change' && !is_numeric($_POST['width']) && !is_numeric($_POST['height']) && $message == NULL){$message = 'Invalid width/height';}

if($message == NULL) {
	$name = $_POST['name'];
	$mouse_over = $_POST['mouseover'];
	$urlto = $_POST['urlto'];

	if($_POST['locationtype'] == 'upload') {
		$filename = $_FILES['filename']['name'];
		$currentdir = "images";
		$expload = explode(".",$filename);
		$ext = $expload[1];
		if(is_file('images/' . $_FILES['filename']['name'])) {
			$filename = substr (md5(uniqid(rand(),1)), 3, 5) . '.' .  $ext;
		}

		move_uploaded_file($_FILES['filename']['tmp_name'],$currentdir.'/'. $filename);
		$location = adpath.'images/' . $filename;

	}
	else {
		$location = $_POST['httploc'];
	}

	if($_POST['stopit'] == 'ignore') {
		$stopit = 'OFF';
	}
	if($_POST['stopit'] == 'hits') {
		$stopit = 'H,' . $_POST['hits'];
	}
	if($_POST['stopit'] == 'views') {
		$stopit = 'V,' . $_POST['views'];
	}
	if($_POST['stopit'] == 'date') {
		$stopit = 'D,' . $_POST['id1'];
	}

	if($_POST['size'] == 'leave') {
		$size = 'NORMAL';
	}

	if($_POST['openin'] == 'new'){
		$openin = '_blank';
	}
	else {
		$openin = '_parent';
	}

	$insert_banner  = @mysql_query("INSERT INTO banners (`name`,`mouseover`,`location`,`urlto`,`stopit`,`openin`) VALUES ('$name','$mouse_over','$location','$urlto','$stopit','$openin')");

	if($insert_banner) {
		$made = date('m') . '/' . date('d') . '/' . date('Y');
		if($size == 'NORMAL') {
			$width = 'NA';
			$height = 'NA';
		}
		else {
			$width = $_POST['width'];
			$height = $_POST['height'];
		}
		$hits = 0;
		$uni_hits = 0;
		$views = 0;
		$uni_views = 0;
		$get_id = @mysql_fetch_array(@mysql_query("SELECT * FROM `banners` ORDER BY `id` DESC"));

		$insert_stat = @mysql_query("INSERT INTO stats (`id`,`made`,`file_location`,`width`,`length`,`hits`,`uni_hits`,`views`,`uni_views`) VALUES ('$get_id[0]','$made','$location','$width','$height','$hits','$uni_hits','$views','$uni_views')");
	}
	if($insert_stat) {
		$message = 'Banner '.$name.' has been successfully added. ID: '.$get_id[0];
	}
	else {
		$message = 'Database error';
	}
}
}

include("header.php");
?>

<p id="section">add a banner</p>
<form name="addurl" method="post" action="<? echo $_SERVER['PHP_SELF'];?>" enctype="multipart/form-data">

<fieldset>
	<legend>General</legend>
	<br />
	<strong>Banner title:</strong><br /><input name="name" type="text" id="name" value="<?php echo $_POST['name'];?>" size="60" /><br />
	<strong>Banner tooltip:</strong><br /><input name="mouseover" type="text" id="mouseover" value="<?php echo $_POST['mouseover'];?>" size="60" /><br />
	<strong>Banner link:</strong><br /><?php if($_POST['urlto'] == NULL) {$_POST['urlto'] = 'http://';}?><input name="urlto" type="text" id="urlto" value="<?php echo $_POST['urlto'];?>" size="60" /> (Enter <strong>EMPTY</strong> to disable linking)<br />
	<strong>Banner link target:</strong><br />
	<?php if($_POST['openin'] == 'new' || $_POST['openin'] == NULL) {$sel = 'checked';} else {$sel=NULL;}?><input name="openin" type="radio" value="new" <?=$sel;?> /> New window 
	<?php if($_POST['openin'] == 'same') {$sel = 'checked';} else {$sel=NULL;}?><input name="openin" type="radio" value="same" <?=$sel;?> /> Same window<br />
</fieldset>
<br />
<fieldset>
	<legend>Location</legend>
	<br />
	<?php if($_POST['locationtype'] == 'http' || $_POST['locationtype'] == NULL) {$sel = 'checked';} else {$sel=NULL;}?><input name="locationtype" type="radio" value="http" <?=$sel;?> /> URL location or <?php if($_POST['locationtype'] == 'upload') {$sel = 'checked';} else {$sel=NULL;}?><input type="radio" name="locationtype" value="upload" <?=$sel;?> /> Upload a file<br />
	<strong>URL location:</strong><br /><input name="httploc" type="text" id="httploc" value="<?php echo $_POST['httploc'];?>" size="60" /><br />
	<strong>File location:</strong><br /><input name="filename" type="file" id="filename" size="60" /><br />
</fieldset>
<br />
<fieldset>
	<legend>Duration</legend>
	<br />
	<?php if($_POST['stopit'] == 'ignore' || $_POST['stopit'] == NULL) {$sel = 'checked';} else {$sel=NULL;}?><input name="stopit" type="radio" value="ignore" <?=$sel;?> /> Forever<br />
	<?php if($_POST['stopit'] == 'hits') {$sel = 'checked';} else {$sel=NULL;}?><input name="stopit" type="radio"  value="hits" <?=$sel;?> /> After <input name="hits" type="text" id="hits2" value="<?php echo $_POST['hits'];?>" size="3" /> hits<br />
	<?php if($_POST['stopit'] == 'views') {$sel = 'checked';} else {$sel=NULL;}?><input name="stopit" type="radio"  value="views" <?=$sel;?> /> After <input name="views" type="text" id="views" value="<?php echo $_POST['views'];?>" size="3" /> views<br />
	<?php if($_POST['stopit'] == 'date') {$sel = 'checked';} else {$sel=NULL;}?><input name="stopit" type="radio" value="date" <?=$sel;?> /> On this date: <input name="id1" type="textarea" value="<?php echo $_POST['id1'];?>" size="7" /> <input type="button" onClick="c1.popup('id1');" style="background:url(images/cal.gif); width: 22px;"/>
</fieldset>
<br />
<fieldset>
	<legend>Misc</legend>
	<br />
	<strong>Resize banner:</strong><br />
	<?php if($_POST['size'] == 'leave' || $_POST['size'] == NULL) {$sel = 'checked';} else {$sel=NULL;}?><input name="size" type="radio" value="leave" <?=$sel;?> /> Original size<br />
	<?php if($_POST['size'] == 'change' ){$sel = 'checked';}else{$sel=NULL;}?><input name="size" type="radio"  value="change" <?=$sel;?> /> Resize to: Width: <input name="width" type="text" id="width" value="<?php echo $_POST['width'];?>" size="4" /> Height: <input name="height" type="text" id="height" value="<?php echo $_POST['height'];?>" size="4" /><br />
</fieldset>
<br />
<input type="submit" name="Submit" value="Add Banner" />
<input name="submitid" type="hidden" id="submitid" value="1" />
</form>
<?php include("footer.php");?>

Cheers

[daveyc]

Ozzie,

Do you get any errors displayed at all? Or is it just returning a blank?

Dave

[ozzie01]

Hi daveyc,

No errors are displayed.

What I did was set-up an external page and called all the banners using:

<?php readfile('http://Domain-where-script-is.com/120x600/viewbanner.php');?>

<?php readfile('http://Domain-where-script-is.com/468x60/viewbanner.php');?>

<?php readfile('http://Domain-where-script-is.com/125x125/viewbanner.php');?>

http://www.morningtonpeninsulaguide.com.au/allbanners-test_me.php

I then uploaded the same test page to the server where the script code(s) resides.
Change the php codes to include files:

<?php include('468x60/viewbanner.php');?>

<?php include('125x125/viewbanner.php');?>

<?php include('120x600/viewbanner.php');?> 

but it doesn't pull up all the banners, only the first banner include file, all the rest are blank?

I'm totally lost now.

Cheers

[ozzie01]

Hi,

I've established that calling the script(s) externally works. For these I've used readfile().

However when I use the include() on the domain where the scripts reside, it will only show the first banner.

I've excluded the header info and <body> tags but this is the test code:

<table width="750" border="0">
  <tr>
    <td>
	120x600 banner<br>
	<?php include('120x600/viewbanner.php');?> 
	</td>
  </tr>
  <tr>
    <td>
	125x125 banner<br>
	<?php include('125x125/viewbanner1.php');?> 
	</td>
  </tr>
  <tr>
    <td>
	468x60 banner<br>
	<?php include('468x60/viewbanner.php');?> 
	</td>
  </tr>
</table>

</body>
</html>

This however is what is being compiled:

<table width="750" border="0">
  <tr>
    <td>
	120x600 banner<br>
	<a href="http://www.Domian-Where-Script-Is.com/120x600/catchadd.php?id=16" target="_blank" ><img src="http://affiliate.intertops.com/processing/impressions.asp?btag=a_366b_405" alt=""  border="0"></a>


</td>
  </tr>
  <tr>
    <td>
	125x125 banner<br>

The first banner is being display correctly...But as you can see the compiled code is being chopped?

I've been reading where it claims the include() will only function if it's only pulling up one instance of the script.

If the same page is being called in another include it wont work...

So my question is how do I get around this problem by calling up 2 or more instances of viewbanner.php in the same page?

Cheers

[ozzie01]

Hi,

I decide to test the code on my server, as I know I've got php debugging.

The is what it spat out when I tried to uses 3 versions of the above include():

Fatal error: Cannot redeclare get_user_ip() (previously declared in /home/morningt/public_html/rotation/viewbanner.php:5) in /home/morningt/public_html/rotation/viewbanner.php on line 21

This is what it is referring to:

code snippet resides in top of viewbanner.php directly preceding the db include()

function get_user_ip() {
	$ipParts = explode(".", $_SERVER['REMOTE_ADDR']);
	if ($ipParts[0] == "165" && $ipParts[1] == "21") {    

		if (getenv("HTTP_CLIENT_IP")) {
			$ip = getenv("HTTP_CLIENT_IP");
		}
		elseif (getenv("HTTP_X_FORWARDED_FOR")) {
			$ip = getenv("HTTP_X_FORWARDED_FOR");
		}
		elseif (getenv("REMOTE_ADDR")) {
			$ip = getenv("REMOTE_ADDR");
		}
	}
	else {
		return $_SERVER['REMOTE_ADDR'];
	}
	return $ip;
}

So now my question is how do I get around this by prevent the viewbanner.php asking for the get_user_ip() again as it's already been declared?

At a guess it would need an else or if statement (?) knowing how to do it, well I don't!

So if anyone can help or tell me what I need to do it would be very much appreciated.

Cheers

[daveyc]

Well, what you could do, rather than including the function in each file, make a seperate php (let's say function_get_ip.php) and just include that at the top of the page you're wanting to display your advertisements on.

But, dont forget to take it out of your viewbanner.php file.

Hope this helps..

Davey

[ozzie01]

Thanks Daveyc,

That makes sense...TY for your help I'm going to do that right now...

Again thanks Mate for all your help 😃

[daveyc]

No problem at all 🙂

Hope it works okay, and don't forget to mark your thread as resolved (If it is)

All the best,

Dave

[ozzie01]

Hi Dave,

I followed everything and did it...

But it worked one minute and then broke the next... I think this stupid script is just full of bugs so I'm kicking it to the curb.

Nice script if you only want to rotate one banner size or rotate header images but totally useless out of the box to run multiple banner ads.

Thanks for the help sorry I put you to all this trouble and now tossing it aside.

Cheer

D