Trying to teach myself PHP

DGJC

I have the script below that works if you were to go to http://www.umcswtx.org/random.php

For the life of me, I cannot figure out how to put it in an html page.

I want random images and cutlines on refresh on this page

http://www.umcwtx.org

url correction
http://www.umcswtx.org

As usual, it will be something small that I need to do, but I can't find it.

Please , if anyone can direct me..

Appreciate it.

<?php
$path = './Images/';

$files=array();
if ($handle=opendir("$path")) {
while(false !== ($file = readdir($handle))) {

if ($file != "." && $file != "..") {
substr($file,-3)=='gif';
substr($file,-3)=='jpg';
substr($file,-3)=='jpeg';
substr($file,-3)=='png';
$files[count($files)] = $file;
}
}
}
closedir($handle);

$random=rand(0,count($files)-1);
if(substr($files[$random],-3)=='gif') header("Content-type: image/gif");
elseif(substr($files[$random],-3)=='jpg') header("Content-type: image/jpeg");
elseif(substr($files[$random],-3)=='jpeg') header("Content-type: image/jpeg");
elseif(substr($files[$random],-3)=='png') header("Content-type: image/png");
readfile("$path/$files[$random]");
?>

DGJC

url correction
http://www.umcswtx.org

rulian

hmm.. this thing:
substr($file,-3)=='gif';
substr($file,-3)=='jpg';
substr($file,-3)=='jpeg';
substr($file,-3)=='png';
wont do anything since there is no call to action
in fact it shoudl produce a sytax error

you can elimiate alot of that code since you do the same checks a few times


$Library="my/Images/Dir/"; 
$Allowed=array("jpg","jpeg","gif","png"); 

$open=fopen($Library); 
while(($file=readdir($open)) !== false) 
{
/// get Extension
$Ext=substr($file, strrpos($file, "."), strlen($file))
if (array_search($Ext, $Allowed) !== false) $Images[]=$file; 
}
fclose($open); 
// get rand
$Download=array_rand($Images, 1); 
// get extenstion
$DExt=substr($Download[0], strrpos($Download[0], "."), strlen($Download[0])); 
// set header
header("Content-type: images/".$DExt); 
// download
readfile($Library.$Download[0]);

darko886

and the "html" page has to be .php not .html

DGJC

Sorry, I am really new to this and now really lost.

Look at this http://www.umcswtx.org/index.php

darko886

As far as I know, all u need to do is plug it in wherever u wanted it in ur html file and just change the extension to .php and it will work fine

DGJC

if you click http://ww.umcswtx.org/index.php i get all the crazy code where I plugged it into the html file.. hit refresh a few time to see. I just don't get it. Everywhere I read about this says it is easy.

laserlight

Basically, you have a warning:

Warning: Cannot modify header information - headers already sent by (output started at /hsphere/local/home/conroyd/umcswtx.org/index.php:8) in /hsphere/local/home/conroyd/umcswtx.org/index.php on line 189

You need to fix that, but your current code snippet does not look like it is causing the problem.

Basically, before a header() call, there should not be any clientside output. No blank lines, no HTML code, no echos and prints.

DGJC

Thanks Laser,
I have tried to fix that by reading several articles. I have the book "PHP for the WWW by Larry Ullman visual quickstart guide". It talks about that error message and taking out spaces as well as output buffering. I have tried it and nothing seems to fix the problem..... I am totally lost and frustrated. I so much want to learn this to broaden my horizons. What would you do to fix this. I am very visual so if I could see it, I may be able to make sense of it.

Thanks for your time
Dan

laserlight

I have tried it and nothing seems to fix the problem..... I am totally lost and frustrated. I so much want to learn this to broaden my horizons. What would you do to fix this. I am very visual so if I could see it, I may be able to make sense of it.

I would examine the code before line 189 and also the code in the file included. The problem is that at this point you know what is wrong and how to solve it in theory, but you lack the practical experience of identifying the location of the problem in your own code.

I suggest coming up with the smallest and simplest script that demonstrates the error. In other words, backup your project, then keep removing code until there is no error. At that point, you know that what you removed caused the error.

DGJC

I don't get it. when i put it out there alone is works. when i put it together with html it doesn't. this is the first time I ever had to do code. everything i do is visual, dreamweaver and the code is written in the back ground.
(like you don't know this already)

Anyway, i don't know where to begin.

You are a teacher aren't you. You want me to find the answer and I want you to give me the answer.

laserlight

when i put it out there alone is works. when i put it together with html it doesn't.

That is a strong hint that your HTML code is placed before your header() call.

You are a teacher aren't you. You want me to find the answer and I want you to give me the answer.

It is more exciting that way, isn't it? 🙂

DGJC

It is more rewarding, that's for sure.

I just don't know what the f i'm doing.
For instance, "your HTML code is placed before your header() call"
I have no idea what that means.

I looked at the code and don't see anything that says header()

Lost and can't find my way back HELP ME somebody HELP ME!!!!!!! LOL

laserlight

First try out this example script:

<?php
header('Location: http://www.example.com');
exit;
?>

If all goes well you should be redirected to example.com.

Next, try this script:

Hello world!
<?php
header('Location: http://www.example.com');
exit;
?>

You should get an error like the one you currently have. The idea is that "Hello world!" is a string of text in the client side (or HTML) code, and it is sent to the browser before the header() call, which is incorrect.

DGJC

i put the script just above the head of the html and this is what I get now

http://www.umcswtx.org/index.php

I want to put the effect in the html webpage

Told you I am lost

benracer

I no this is not going to help with reading the images from a folder but if possible storing the urls in an array and using the array rand function to get the urls for the img tag.

DGJC

Does the actual php script go into the html page or does a line of code referring to the php file go int the html page. If some one would get me thru this stumbling block, I think it would all come together and make sense.

Thanks in advance

laserlight

Does the actual php script go into the html page or does a line of code referring to the php file go int the html page.

The PHP script is interpreted and produces the HTML (and other client side) code.

DGJC

So
Will you tell me what is wrong with what I am doing.

http://www.umcswtx.org/random.php

gives me the effect i want.

I put that script into

http://www.umcswtx.org/index.php

and it doesn't.

laserlight

If you have it that way, you can just use HTML:

<img src="random.php" alt="Random Image />