[RESOLVED] Query was empty

jinky32

hi guys. i'm having problem with this code (again)

$insert = "INSERT INTO movie (movie_id, movie_name, movie_type, " .
           "movie_year, movie_leadActor, movie_director) " .
           "VALUES (1, 'Bruce Almighty', 5, 2003, 1, 2), " .
                  "(2, 'Office Space', 5, 1999, 5, 6), " .
                  "(3, 'Grand Canyon', 2, 1991, 4, 31)"; 
$results=mysql_query($insert)
	or die(mysql_error());

// insert data into "movieType" table
$insert ="INSERT INTO movieType (movieType_id, movieType_label) " .
	"VALUES (1, 'Sci Fi'), " .
	"(2, 'Drama'), " .
	"(3, 'Adventure'), " .
	"(4, 'War') " .
	"(5, 'Comedy'), " .
	"(6, 'Horror'), " .
	"(7, 'Action'), " .
	"(8, 'Kids'), ";
$results=mysql_query($type)
	or die(mysql_error());

//insert data into "people" table
$people = "INSERT INTO people (people_id, people_fullName, " .
	"people_isActor, people_isDirector) " .
	"VALUES (1, 'Jim Carey', 1, 0), " .
	"(2, 'Tom Shadyac', 0, 1), " .
	"(3, 'Lawrence Kasdan', 0, 1), " .
	"(4, 'Kevin Kline', 1, 0), " .
	"(5, 'Ron Livingston', 1, 0), " .
	"(6, 'Mike Judge', 0, 1)";
$results=mysql_query($people)
	or die(mysq_error());

echo "data inserted successfully";
?>

i open the file in my browser and it just shows 'query was empty'.

I've commented out all of the $results=mysql_query sections and then the date is inserted ok. i went back an uncommented-out the $results sections and it seems as though it's the middle one
$results=mysql_query($type)
or die(mysql_error());

causing the problems (i started from the bottom and worked up, so it may be that the top one causes issues too!).

can anyone help?

jib0

The problem is at this line:

$results=mysql_query($type) 
    or die(mysql_error());

Since $type is undefined, it tolds you that 'query was empty'. Your query is in the $insert variable...

You should always develop your PHP programs with the "error_reporting = E_ALL" set in your php.ini file. It will display that the variable $type is uninitialized and prevents this kind of mistakes.

REY619

Yeah as jib0 said, change $insert in this code to $type: -

$insert ="INSERT INTO movieType (movieType_id, movieType_label) " .
    "VALUES (1, 'Sci Fi'), " .
    "(2, 'Drama'), " .
    "(3, 'Adventure'), " .
    "(4, 'War') " .
    "(5, 'Comedy'), " .
    "(6, 'Horror'), " .
    "(7, 'Action'), " .
    "(8, 'Kids'), ";
$results=mysql_query($type)
    or die(mysql_error());

Also in this code: -

$people = "INSERT INTO people (people_id, people_fullName, " .
    "people_isActor, people_isDirector) " .
    "VALUES (1, 'Jim Carey', 1, 0), " .
    "(2, 'Tom Shadyac', 0, 1), " .
    "(3, 'Lawrence Kasdan', 0, 1), " .
    "(4, 'Kevin Kline', 1, 0), " .
    "(5, 'Ron Livingston', 1, 0), " .
    "(6, 'Mike Judge', 0, 1)";
$results=mysql_query($people)
    or die(mysq_error());

Note mysq_error(), It might be a typo...... 🙂

jinky32

thanks guys - that's perfect. I'm following the tutorials in this book - it's really bugging me, there are quite a few errors like this and loads of typos. would you recommend anything better?

having made the changes i'm getting an error 'Duplicate entry '1' for key 1'. the code im using to create the table is this:

//create "movie" table
$movie= "CREATE TABLE movie (
	movie_id int(11) NOT NULL auto_increment,
	movie_name varchar(255) NOT NULL,
	movie_type tinyint(2) NOT NULL default 0,
	movie_year int(4) NOT NULL default 0,
	movie_leadActor int(11) NOT NULL default 0,
	movie_director int(11) NOT NULL default 0,
	PRIMARY KEY (movie_id),
	KEY movie_type (movie_type, movie_year)
)";
$results = mysql_query($movie)
	or die (mysql_error());

//create "movietype" table
$movietype="CREATE TABLE movieType (
	movieType_id int(11) NOT NULL auto_increment,
	movieType_label varchar(100) NOT NULL,
	PRIMARY KEY (movieType_id)
)";
$results = mysql_query($movietype)
	or die (mysql_error());

//create " people" table
$people="CREATE TABLE people (
	people_id int(11) NOT NULL auto_increment,
	people_fullName varchar(255) NOT NULL,
	people_isActor tinyint(1) NOT NULL default 0,
	people_isDirector tinyint(1) NOT NULL default 0,
	PRIMARY KEY (people_id)
)";
$results = mysql_query($people)
	or die(mysql_error());

echo "movie database successfully created!";
?>

and the code in the previous post inserts data into it. am i right in thinking that the duplicate entry is referring to this code from the previous post:

$insert = "INSERT INTO movie (movie_id, movie_name, movie_type, " .
           "movie_year, movie_leadActor, movie_director) " .
           "VALUES (1, 'Bruce Almighty', 5, 2003, 1, 2), " .
                  "(2, 'Office Space', 5, 1999, 5, 6), " .
                  "(3, 'Grand Canyon', 2, 1991, 4, 31)";

it's for some reason not liking a 5 appearing after the first two film names?

thanks in advance for any help with this. i have to go out for a whole day now - back tomorrow morn. if i haven't posted if u reply its cos of that - not cos im not grateful!!

jinky32

just to say that i've solved the duplicate issue. the problem was that movie_id (and the other *_ids in the other INSERTs) didn't need to be included because they are autoincremented.