looping dilemma - I think? - PHPBuilder Forums

looping dilemma - I think?

urbandragon

Hi all

I am new to PHP and have got myself in a bit of a bind with the loop statement. At least I think so.

I am using an ms access database table and trying to create a small pagination system. The structure is below.

I believe the problem is here…

<?
// This is the Next and Previous code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo "<b>" .$i. "</b> | ";
}

else{
echo '<a href = '.$PHP_SELF.' ?pageid= '.$i.' > <b> ' .$i.' </b> </a> | ';
}

}
?>

because I get nothing but a blank page except this when I load the page.

" .$i. " | "; } else{ echo ' ' .$i.' | '; } } ?> tag). while($row=odbc_fetch_assoc($result)){ ?>

I am a newbie with PHP and understand it a bit. If someone could check this and explain what is wrong and have an idea on how to correct it, it would be much appreciated.

It took me a fair amount of time to get this far and I would really like to have this solved.

Thanks

<body>
<?
// Connect database
odbc_connect('TVSERIES', 'root', '');

$pagesize=5; // Set number of records to view on a page.

// get a single column (id) from table.
$result=odbc_query("SELECT ID FROM stargatesg1;");
// Count the total of number of records and set it to $totalrecord.
$totalrecord=odbc_num_rows($result);

// How many pages will be created?
$totalpage=(int)($totalrecord/$pagesize);
if(($totalrecord%$pagesize)!=0){
$totalpage+=1;
}

If not, $pageid set to 1 and $start set at 0 (first record in table) /
if(isset($pageid)){
$start=$pagesize($pageid-1);
}
else{
$pageid=1;
$start=0;
}

// Select records from table with the limit statement and place them in $result.
$result=odbc_query("SELECT ID, series, season, episodeName FROM stagatesg1 ORDER BY season ASC limit $start, $pagesize;");
?>

<?
// This is the Next and Previous loop code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo "<b>" .$i. "</b> | ";
}

else{
echo '<a href = '.$PHP_SELF.' ?pageid= '.$i.' > <b> ' .$i.' </b> </a> | ';
}

}
?>
<table border="1">
<tr>
<td>Series</td>
<td>Season</td>
<td>Episode</td>
</tr>
<?
// Show records made by the while loop on table rows.
while($row=odbc_fetch_assoc($result)){
?>
<tr>
<td><? echo $row['series']; ?></td>
<td><? echo $row['season']; ?></td>
<td><? echo $row['episodeName']; ?></td>
</tr>
<?
// End while loop.
}
// Close the connection.
odbc_close();
?>
</table>
</body>
</html>
</body>
</html>

NogDog

Welcome to the forum.

You can help us to help you by editing your post and placing [php ]...[ /php] (without the spaces I used here) around your code samples. This does many nice formatting things which make it much easier to read your code.

urbandragon

Hi all

I am new to PHP and have got myself in a bit of a bind with the loop statement. At least I think so.

I am using an ms access database table and trying to create a small pagination system. The structure is below.

I believe the problem is here…

 
<?
// This is the Next and Previous code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo "<b>" .$i. "</b> | ";
}

else{
echo '<a href = '.$PHP_SELF.' ?pageid= '.$i.' > <b> ' .$i.' </b> </a> | ';
}

}
?>

because I get nothing but a blank page except this when I load the page.

" .$i. " | "; } else{ echo ' ' .$i.' | '; } } ?> tag). while($row=odbc_fetch_assoc($result)){ ?>

I am a newbie with PHP and understand it a bit. If someone could check this and explain what is wrong and have an idea on how to correct it, it would be much appreciated.

It took me a fair amount of time to get this far and I would really like to have this solved.

Thanks

<body>

<?
// Connect database
odbc_connect('TVSERIES', 'root', '');


$pagesize=5; // Set number of records to view on a page.

// get a single column (id) from table.
$result=odbc_query("SELECT ID FROM stargatesg1;");
// Count the total of number of records and set it to $totalrecord.
$totalrecord=odbc_num_rows($result);

// How many pages will be created?
$totalpage=(int)($totalrecord/$pagesize);
if(($totalrecord%$pagesize)!=0){
$totalpage+=1;
}

If not, $pageid set to 1 and $start set at 0 (first record in table) */
if(isset($pageid)){
$start=$pagesize*($pageid-1);
}
else{
$pageid=1;
$start=0;
}

// Select records from table with the limit statement and place them in $result.
$result=odbc_query("SELECT ID, series, season, episodeName FROM stagatesg1 ORDER BY season ASC limit $start, $pagesize;");
?>


<?
// This is the Next and Previous loop code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo "<b>" .$i. "</b> | ";
}

else{
echo '<a href = '.$PHP_SELF.' ?pageid= '.$i.' > <b> ' .$i.' </b> </a> | ';
}

}
?>

<table border="1">
<tr>
<td>Series</td>
<td>Season</td>
<td>Episode</td>
</tr>

<?
// Show records made by the while loop on table rows.
while($row=odbc_fetch_assoc($result)){
?>

<tr>
<td><? echo $row['series']; ?></td>
<td><? echo $row['season']; ?></td>
<td><? echo $row['episodeName']; ?></td>
</tr>
<?
// End while loop.
}
// Close the connection.
odbc_close();
?>

</table>
</body>
</html>
</body>
</html>

ragedigital

$PHP_SELF is out of date, use $_SERVER['PHP_SELF'] instead.

<?
// This is the Next and Previous code.
for ($i = 1; $i <= $totalpage; $i++)
    {
    if ( $i == $pageid )
        echo "<b>" .$i. "</b> |";
    else
        echo '<a href='.$_SERVER['PHP_SELF'].'?pageid='.$i.'> <b> '.$i.' </b> </a> |';
    }
?>

ragedigital

You should use 'ceil" here to get the right page count:

Instead of:

// How many pages will be created?
$totalpage=(int)($totalrecord/$pagesize);

use:

// How many pages will be created?
$totalpageceil($totalrecord/$pagesize);

I think the reason you're getting a blank screen is this syntax error:

If not, $pageid set to 1 and $start set at 0 (first record in table) */

You didn't comment out the beginning:

//If not, $pageid set to 1 and $start set at 0 (first record in table)

urbandragon

Thanks

I took a second look again and yes I missed the comment out but the problem seems to still be…


<?
// This is the Next and Previous code.
for ($i = 1; $i <= $totalpage; $i++)
    {
    if ( $i == $pageid )
        echo "<b>" .$i. "</b> |";
    else
        echo '<a href='.$_SERVER['PHP_SELF'].'?pageid='.$i.'> <b> '.$i.' </b> </a> |';
    }
?>

It brings up the image of the table with no content and this on the loaded page

" .$i. " | "; } else{ echo ' ' .$i.' | '; } } ?>

totalpagecell didn't make a difference from what I could tell.

ragedigital

urbandragon wrote:
Thanks

totalpagecell didn't make a difference from what I could tell.

That didn't copy over correctly. Sometimes I get weird stuff from this PHP vbscript...

It should be:

// How many pages will be created?
$totalpage = ceil($totalrecord/$pagesize);

ragedigital

urbandragon wrote:
echo '<a href='.$_SERVER['PHP_SELF'].'?pageid='.$i.'> <b> '.$i.' </b> </a> |'; 
It brings up the image of the table with no content and this on the loaded page

" .$i. " | "; } else{ echo ' ' .$i.' | '; } } ?>

With the quotes there, it might be throwing it off. You can try:

echo "<a href='".$_SERVER['PHP_SELF']."?pageid=".$i."'><b> ".$i." </b></a> |";

urbandragon

I did the corrections and still no progress 🙁

<?
// This is the Next and Previous loop code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo '<b>' .$i. '</b> | ';
}

else{
echo "<a href=' " .$_SERVER['PHP_SELF']. " ?pageid= ".$i." '> <b> ".$i." </b> </a> |"; 
}

}
?>

garblar

the problem seems to me that you have extra spaces in the url, try this

// This is the Next and Previous loop code.
for ( $i = 1; $i <= $totalpage; $i++ ){
	if ( $i == $pageid ){
		echo '<b>'.$i.'</b> | ';
	}
	else{
		echo "<a href='".$_SERVER['PHP_SELF']."?pageid=".$i."'><b>".$i."</b></a> | ";
	}
}

ragedigital

urbandragon wrote:

I did the corrections and still no progress 🙁

<?
// This is the Next and Previous loop code.
for ( $i = 1; $i <= $totalpage; $i++ ){
if ( $i == $pageid ){
echo '<b>' .$i. '</b> | ';
}

else{
echo "<a href=' " .$_SERVER['PHP_SELF']. " ?pageid= ".$i." '> <b> ".$i." </b> </a> |"; 
}

}
?>

Does your code have all of those spaces in the line or is this forum doing that to you?

Should be:

// This is the Next and Previous loop code.
for ($i = 1; $i <= $totalpage; $i++)
    {
    if($i == $pageid)
        echo "<b>".$i."</b> |";
    else
        echo "<a href='".$_SERVER['PHP_SELF']."?pageid=".$i."'><b>".$i."</b></a>|";
    }

EDIT: Garblar beat me to it. I don't see any other issues than that.

urbandragon

Yep been there done that!

I am wondering however if I have somehow combined PHP4 and 5 code together.

I am using <? instead of <?php, When I use <?php nothing comes up when the page is loaded.

The limit command has thrown me as well. I am telling the code I want 22 rows to display and then later I tell the code to limit without a number. If I put a number with limit, nothing happens.

When the page is loaded I get these results

".$i." |"; else echo "".$i."|"; } } ?> '; echo ''; echo ''; echo ''; } ?>
Number Series Season Episode
'.$row['ID']' '.$row['series'].' '.$row['season'].' '.$row['episodeName'].'

which is why I think there is something wrong with the if else loop, yet I am not sure because

the overall I want is:

call the database up
call the table up
tell the code I want 22 rows displayed per page
when all is said and done close the database.

I'll keep plugin away at it cause I want to learn and beat it real bad now 🙂

garblar

can you post the newest code you have for this script

laserlight

I am using <? instead of <?php, When I use <?php nothing comes up when the page is loaded.

That is strange. The opposite is more likely to happen since short_open_tags may not be enabled (and in my opinion, should not be). Try this test script to confirm:

<?php echo 'Hello world!'; ?>

urbandragon

This is what I am working with.

<?
// Connect database
odbc_connect('TVSERIES', 'root', '');

$pagesize=22; // Set number of records to view on a page.

// get a single column (id) from table.
$result=odbc_query($odbc,"SELECT ID FROM stargatesg1") or die (odbc_errormsg());
// Count the total of number of records and set it to $totalrecord.
$totalrecord=odbc_num_rows($result);

// How many pages will be created?
$totalpage = ceil($totalrecord/$pagesize);
if(($totalrecord%$pagesize)!=0){
$totalpage+=1;
}

//If not, $pageid set to 1 and $start set at 0 (first record in table)
if(isset($pageid)){
$start=$pagesize*($pageid-1);
}
else{
$pageid=1;
$start=0;
}

// Select records from table with the limit statement and place them in $result.
$result=odbc_query($odbc,"SELECT ID,series,season,episodeName FROM stagatesg1 ORDER BY season ASC limit $start, $pagesize");
?>

<?
// This is the Next and Previous loop code.
for ($i=1;$i<=$totalpage;$i++)
    {
    if($i==$pageid)
        echo"<b>".$i."</b> |";
    else
        echo"<a href='".$_SERVER['PHP_SELF']."?pageid=".$i."'><b>".$i."</b></a>|";
    } 

}
?>
<table border="1">
<tr>
<td>Number</td>
<td>Series</td>
<td>Season</td>
<td>Episode</td>
</tr>
<?
// Show records made by the while loop on table rows.
while($row=odbc_fetch_assoc($result)){

{
echo '<tr><td>'.$row['ID']'</td>';
echo '<td>'.$row['series'].'</td>';
echo '<td>'.$row['season'].'</td>';
echo '<td>'.$row['episodeName'].'</td></tr>';
}
?>
<?
odbc_close($odbc);
?>
</table>

urbandragon

laserlight wrote:
That is strange. The opposite is more likely to happen since short_open_tags may not be enabled (and in my opinion, should not be). Try this test script to confirm:
<?php echo 'Hello world!'; ?>

this works fine
<?php echo 'Hello world!'; ?>

how does one enable <?

laserlight

how does one enable <?

You should not. It will cause conflicts with XML since <?xml would be interpreted as PHP.

garblar

give this a try

<?PHP
// Connect database
odbc_connect('TVSERIES', 'root', '');

$pagesize=22; // Set number of records to view on a page.

// get a single column (id) from table.
$result=odbc_query($odbc,"SELECT ID FROM stargatesg1") or die (odbc_errormsg());
// Count the total of number of records and set it to $totalrecord.
$totalrecord=odbc_num_rows($result);

// How many pages will be created?
$totalpage = ceil($totalrecord/$pagesize);

//If not, $pageid set to 1 and $start set at 0 (first record in table)
if(isset($_GET['pageid'])){
$start=$pagesize*($_GET['pageid']-1);
}
else{
$_GET['pageid']=1;
$start=0;
}

// Select records from table with the limit statement and place them in $result.
$result=odbc_query($odbc,"SELECT ID,series,season,episodeName FROM stagatesg1 ORDER BY season ASC limit $start, $pagesize");
?>

<?
// This is the Next and Previous loop code.
for ($i=1;$i<=$totalpage;$i++){
	if($i==$_GET['pageid'])
		echo"<b>".$i."</b> |";
	else
		echo"<a href='".$_SERVER['PHP_SELF']."?pageid=".$i."'><b>".$i."</b></a> |";
	}

}
?>
<table border="1">
<tr>
<td>Number</td>
<td>Series</td>
<td>Season</td>
<td>Episode</td>
</tr>
<?
// Show records made by the while loop on table rows.
while($row=odbc_fetch_assoc($result)){
?>
<tr>
<td><?PHP echo $row['ID']; ?></td>
<td><?PHP echo $row['series']; ?></td>
<td><?PHP echo $row['season']; ?></td>
<td><?PHP echo $row['episodeName']; ?></td>
<?PHP
}
odbc_close($odbc);
?>
</table>

ionathas

From what I know, odbc_fetch_assoc is not a built-in function... you should use something like odbc_fetch_row or make your own function:

function odbc_fetch_assoc($result)
{
	if (odbc_fetch_row($result))
	{
		$result_array = array();

	for($x = 1; $x <= odbc_num_fields($result); $x++)
	{
		$name 				= odbc_field_name($result, $x);
		$value 				= odbc_result($result, $name);
		$result_array[$name]  = $value;
	}

	return $result_array;
}
else
{
	return false;
}
}