[RESOLVED] function not working right!

spiritssight

Hello all,

I am writing a function to do one of the things that is going to be used a number of times through out the site, and it works except when i don't put one of the argurments into the function, I do have a default value set for it. so the question is what am I doing wrong? Another problem with this is that if I put a / in the url so it would show up as yoursite.com/?sq ... it keeps adding another / when hitting any of the four links (please note right now I don't have the / in the code.

Any help will be grateful!

<?php

$sq = "test"; // var from url
$tr = 172; // total rows found from the search
$pn = $_GET['pn']; // page number that is being displayed
// $rpp = 20; // tells how many results to show on one page

function page_bar($sq, $tr, $rpp = '20', $pn)
{
$fp = 1; // first page
$lp = ceil($tr/$rpp); // last page

$page_nav_bar = ''; // var thats used to hold what will be displayed for the page nav bar

if($pn > $fp)
{
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$sq&pn=$fp\">First</a> ";
$page_nav_bar .= ' | ';
$pp = $pn - 1;
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$sq&pn=$pp\">Prev</a> ";
}

$page_nav_bar .= " Page $pn of $lp ";

if($pn < $lp)
{
$np = $pn + 1;
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$sq&pn=$np\">Next</a>";
$page_nav_bar .= ' | ';
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$sq&pn=$lp\">Last</a>";
}
return "$page_nav_bar";
}

echo "<center>" . page_bar($sq, $tr,$pn) . "</center>";

?>

Sincerely,
Christopher

laserlight

Read the PHP manual concerning function arguments. You will find that once you specify a default argument, all the parameters to the right of the parameter that provides a default argument should also provide their own default arguments.

So you have a choice: either provide $pn with a default argument, or re-arrange the parameters such that $pn is to the left of $rpp.

Oh, and it may be a good idea to use names that are more descriptive than $sq, $tr, $rpp, and $pn. You also need to indent your code properly to reflect scope.

spiritssight

oo are you talking about the if() statements, oops I over looked that. and also thanks for the link, when I read the man I did not see that one, I see a lot of stuff through.

Thanks laserlight

Sincerely,
Christopher

laserlight

oo are you talking about the if() statements, oops I over looked that.

No, I am talking about default arguments; in particular, failing to specify default arguments after a parameter has specified a default argument. That is the current problem.

spiritssight

Hello laserlight,

I now have that part fixed, thanks, I just was able to get back to a computer to state this :-)

Sincerely,
Christopher

spiritssight

Here is the working code:

<?php

// $searchquery = "test"; // var from url
// $totalrecords = 172; // total rows found from the search
// $pagenumber = $_GET['pn']; // page number that is being displayed

function page_bar($searchquery, $totalrecords, $pagenumber = '1', $recordsperpage = '20')
{
$firstpage = 1; // first page
$lastpage = ceil($totalrecords/$recordsperpage); // last page

$page_nav_bar = ''; // var thats used to hold what will be displayed for the page nav bar

if($pagenumber > $firstpage)
{
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$searchquery&pn=$firstpage\">First</a> ";
$page_nav_bar .= ' | ';
$prevpage = $pagenumber - 1;
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$searchquery&pn=$prevpage\">Prev</a> ";
}

$page_nav_bar .= " Page $pagenumber of $lastpage ";

if($pagenumber < $lastpage)
{
$nextpage = $pagenumber + 1;
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$searchquery&pn=$nextpage\">Next</a>";
$page_nav_bar .= ' | ';
$page_nav_bar .= "<a href=\"http://" . $_SERVER['SERVER_NAME'] . $_SERVER['PHP_SELF'] ."?sq=$searchquery&pn=$lastpage\">Last</a>";
}

$page_nav_bar .="
		<form name=\"goto_page\" action=\"". $_SERVER['PHP_SELF']."\" method=\"GET\">
		<input type=\"hidden\" name=\"sq\" value=\"$searchquery\" />
		 Goto page: <input type=\"text\" name=\"pn\" size=\"1\" maxlength=\"2\" />
			<input type=\"submit\" name=\"go\" value=\"Go\" />
		</form>";

return "$page_nav_bar";
}

// echo "<center>" . page_bar($searchquery, $totalrecords, $pagenumber) . "</center>";

?>

If there is any advice to make this better and more usable please pass along the ideas.

Sincerely,
Christopher