[RESOLVED] Need some help...probably a simple problem.

octacon

hey i'm completely new and would like some expert advice. though my problem is probably relatively a simple one I can't seem to get this calculator working. I was hoping to get some help or at least advice on what i am doing wrong here. I've pasted the code I have below. I have been trying to get it work the past couple hours...sigh...i hope someone here can at least point me in the right direction. Thanks.

<html>

<head>
<meta http-equiv="Content-Language" content="en-ca">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>Simple Calculator</title>
</head>

<body>

<form method="POST" action="LabO2.php">
<p align="center"><b>Number 1: </b><input type="text" name="number1" size="10"></p>
<p align="center"><b>Number 2: </b> <input type="text" name="number2" size="10"></p>
<p align="center"><b>Result: </b> <?php echo "$result"; ?>

<p align="center">
<input type="submit" value="+" name="func"> 
<input type="submit" value="-" name="func">
<input type="submit" value="*" name="func">
<input type="submit" value="/" name="func">
<p align="center"><input type="reset" value="Clear"></p>

</form>

<?php

if($func == "+"){
$result = $POST['number1'] + $POST['number2'];
}
if($func == "-"){
$result = $POST['number1'] - $POST['number2'];
}
if($func == "*"){
$result = $POST['number1'] * $POST['number2'];
}
if($func == "/"){
$result = $POST['number1'] / $POST['number2'];
}

?>

</body>

</html>

tsinka

Hi,

there are three main problems:

you need to use $_POST instead of $POST to access posted data
Use $_POST['func'] instead of $func in the php code
currently, you first print out the result and do the calculation stuff afterwards, which seems to be a bad idea.

Move the php block to the beginning of the script.

Edit:

I forgot to mention that you should check if the form has been submitted at all (by checking if $_POST['func'] is set) and add some validation code.

octacon

Thanks for the advice I made some of the changes you recommended but still no results. I'm not sure what you mean to check if its being submitted at all can you clarify what to do. I'm not too concerned about validation just yet. I need to get the result showing first. Here is what I have now:

<html>

<head>
<meta http-equiv="Content-Language" content="en-ca">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>Simple Calculator</title>
</head>

<body>

<?php

if($_POST['func'] == "+"){
$result = $_POST['number1'] + $_POST['number2'];
}
if($_POST['func'] == "-"){
$result = $_POST['number1'] - $_POST['number2'];
}
if($_POST['func'] == "*"){
$result = $_POST['number1'] * $_POST['number2'];
}
if($_POST['func'] == "/"){
$result = $_POST['number1'] / $_POST['number2'];
}

?>

<form method="POST" action="LabO2.php">
<p align="center"><b>Number 1: </b><input type="text" name="number1" size="10"></p>
<p align="center"><b>Number 2: </b> <input type="text" name="number2" size="10"></p>
<p align="center"><b>Result: </b> <?php echo "$result"; ?>

<p align="center">
<input type="submit" value="+" name="func"> 
<input type="submit" value="-" name="func">
<input type="submit" value="*" name="func">
<input type="submit" value="/" name="func">
<p align="center"><input type="reset" value="Clear"></p>

</form>

</body>

</html>

tsinka

Ok,

I tested your code and it works on my server ... I can't see any error ... just to make sure, add a line that prints whatever text to make sure that web server uses the right script (sounds stupid, but that's one step in solving the problem). Please check the target of the form if it points to the script or use $_SERVER['PHP_SELF'] as the target of the form.

To avoid warnings you can add some code to check if the form has been submitted at all:

<?php

if (isset($_POST['func'])) {
  if($_POST['func'] == "+"){
    $result = $_POST['number1'] + $_POST['number2'];
  }

  if ($_POST['func'] == "-"){
    $result = $_POST['number1'] - $_POST['number2'];
  }

  if($_POST['func'] == "*"){
    $result = $_POST['number1'] * $_POST['number2'];
  }

  if($_POST['func'] == "/"){
    $result = $_POST['number1'] / $_POST['number2'];
  }
}
?>

Thomas

octacon

I can't believe this but I was testing it not using my server so obviously it wasn't working. I goofed up big time 😃. Thanks for your help its does work now that I've tested it properly. Last question how would I print the results in a textbox rather then just displaying where it is?

tsinka

<textarea>echo stuff here</textarea>

octacon

Okay nevermind I got it to work. Thanks for all your help problem solved! 🙂

tsinka

Don't forget to mark the thread resolved 🙂