Create a Database with two tables

[impactdesignpro]

I am trying to create a database which contains two tables. The script is not working. Can someone look over this script and show me what I am doing wrong?

<?php
//Get data from setup.php form
$localhost=$_POST['localhost'];
$user_name=$_POST['user_name'];
$password=$_POST['password'];
$username=$_POST['username'];
$userpass=$_POST['userpass'];
$level="1";
// Connect
$con = mysql_connect("$localhost","$user_name","$password");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }
// Create database
if (mysql_query("CREATE DATABASE audio",$con))
  {
  echo "Audio Database has been created<br>Remove files: setup.php and configdb.php from your directory";
  }
else
  {
  echo "Error creating database: " . mysql_error();
  }
// Create first table called music
mysql_select_db("audio", $con);
$sql ="CREATE TABLE `music` (
`id` int(4) NOT NULL auto_increment,
`month` varchar(4) NOT NULL default '',
`day` varchar(4) NOT NULL default '',
`year` varchar(4) NOT NULL default '',
`title` varchar(90) NOT NULL default '',
`group` varchar(30) NOT NULL default '',
`file` varchar(60) NOT NULL default '',
PRIMARY KEY (`id`))";
mysql_query($sql,$con);
mysql_select_db("audio", $con);

// Create second table called admin
$sql ="CREATE TABLE `admin` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`userpass` varchar(65) NOT NULL default '',
`level` int(4) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2";

mysql_query("INSERT INTO `admin` VALUES ('id', '$username', '$userpass', '$level')") ; 
mysql_close($con);
?>

[rulian]

I"m not trying to be mean but first and foremore:

$localhost=$_POST['localhost'];
$user_name=$_POST['user_name'];
$password=$_POST['password'];
$username=$_POST['username'];
$userpass=$_POST['userpass'];
$level="1";
// Connect
$con = mysql_connect("$localhost","$user_name","$password");

is an incredible security problem

I can tell you are trying to make some form of db installer
it's better to simply spit out a sql file from your master db and enter the variables after you've passed them through basic filters like mysql_real_escape_string.

With that said, what errors is it reporting on install?
Also, i would recommend you echo out yoru success line after everything is all done not just after the database is created

[impactdesignpro]

By all means your not being mean...
I am learning php as I go, so forgive me if I seem ignorant or if this is a foolish question.

Lets say I change the code from:

//Get data from setup.php form
$localhost=$_POST['localhost'];
$user_name=$_POST['user_name'];
$password=$_POST['password'];
$username=$_POST['username'];
$userpass=$_POST['userpass'];
$level="1";

to manually inserting the values:
new code:

//Get data from setup.php form
$localhost="localhost"; 
$user_name="mydatabaseusername";
$password="mydatabasepassword";
$username=$_POST['username']; // this I can leave becuase it does nothing but inserts a value into one of my fields
$userpass=$_POST['userpass']; // this I can leave becuase it does nothing but inserts a value into one of my fields
$level="1";

// Connect
$con = mysql_connect("$localhost","$user_name","$password");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }
// Create database
if (mysql_query("CREATE DATABASE audio",$con))
  {
  echo "Audio Database has been created<br>Remove files: setup.php and configdb.php from your directory";
  }
else
  {
  echo "Error creating database: " . mysql_error();
  }
// Create first table called music
mysql_select_db("audio", $con);
$sql ="CREATE TABLE `music` (
`id` int(4) NOT NULL auto_increment,
`month` varchar(4) NOT NULL default '',
`day` varchar(4) NOT NULL default '',
`year` varchar(4) NOT NULL default '',
`title` varchar(90) NOT NULL default '',
`group` varchar(30) NOT NULL default '',
`file` varchar(60) NOT NULL default '',
PRIMARY KEY (`id`))";
mysql_query($sql,$con);
mysql_select_db("audio", $con);

// Create second table called admin
$sql ="CREATE TABLE `admin` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`userpass` varchar(65) NOT NULL default '',
`level` int(4) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2";

mysql_query("INSERT INTO `admin` VALUES ('id', '$username', '$userpass', '$level')") ; 
mysql_close($con);
?>

I'm don't know what do with the if statement - Where it should go at the end and how it should be written to include the whole process.

[jeremyphphaven]

Where is it dieing?

When you go to create the first database and call mysql_query($sql,$con);

Call it this way instead -

mysql_query($sql,$con) or die('Died creating first db<br />SQL-'.$sql.'<br />MYSQL ERROR -'.mysql_error());

Do the same method for the second one and see if its dieing when you're creating the db's... if so, it's a problem with your SQL statement more than likely.

[impactdesignpro]

I need to start this thread over...

I am looking for the code to create 2 tables on one database.
the problem I am having currently is that it is creating the first table - but the second table I get the error: can't create the table -database doesn't exist (not in those exact words but you get the point)

Thanks jeremyphphaven for the die command - it wasn't until i put that in did I notice what problem I was having.

[jeremyphphaven]

Hello again.

You're never executing the creation of the second table...

Here is what you have

// Create second table called admin
$sql ="CREATE TABLE `admin` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`userpass` varchar(65) NOT NULL default '',
`level` int(4) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2";

mysql_query("INSERT INTO `admin` VALUES ('id', '$username', '$userpass', '$level')") ; 
mysql_close($con);

Here is what is missing

// Create second table called admin
$sql ="CREATE TABLE `admin` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`userpass` varchar(65) NOT NULL default '',
`level` int(4) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2";

// START WHAT IS MISSING \\
mysql_query($sql) or die(mysql_error());
// END WHAT IS MISSING \\

mysql_query("INSERT INTO `admin` VALUES ('id', '$username', '$userpass', '$level')") ; 
mysql_close($con);

Also, once you've selected a DB, you do not need to reselect it with every query if you're using the same one.

Try that!