[RESOLVED] please look at this simple class

[rutin]

hi there,

i am using class that i found somewhere on the net.
it doesnt return the results the way it should.
could any1 look at it, and spot the error.

and, of course improve it. that will be great.

thank you,

rutin,

p.s.
if needed i could post a sample function that makes the problem.

<?php
// Check for MySQL Support, class starts
if (!function_exists('mysql_connect')) die('Sorry, your server does not have support for MySQL');
class mysql {
    var $host = '';
    var $user = '';
    var $pass = '';
    var $database = '';
    var $linkid;
    var $result;
    var $record = array();
    var $rows;

function config($host, $user, $pass, $database)
{
    $this->host = $host;
    $this->user = $user;
    $this->pass = $pass;
    $this->database = $database;
    return true;
}

function connect()
{
    $this->linkid = mysql_connect($this->host, $this->user, $this->pass) or $this->error(mysql_error());
    return $this->linkid;
}

function selectdatabase()
{
    mysql_select_db($this->database) or $this->error(mysql_error());
    return true;
}

function query($sql)
{
    $this->result = mysql_query($sql) or $this->error(mysql_error());
    return $this->result;
}

function fetcharray($result)
{
    $this->record = mysql_fetch_array($result);
    $this->clean;
    return $this->record ;
}

function fetchassoc()
{
    $this->record = mysql_fetch_assoc($this->result);
    $this->clean;
    return $this->record;
}

function fetchrow()
{
    $this->record = mysql_fetch_row($this->result);
    $this->clean;
    return $this->record;
}

function clean()
{
    foreach($this->record as $key => $val) {
        $this->record[$key] = stripslashes($val);
    }
    return $this->record;
}

function totalrows($result)
{
    $this->rows = mysql_num_rows($this->result);
    return $this->rows;
}

function close()
{
    mysql_close($this->linkid);
    return true;
}

function free($result)
{
    mysql_free_result($result);
}

function error($text)
{
    echo '<div align="center">';
    echo '<h2>mysql error</h2>';
    echo '<hr width="40%">';
    echo $text;
    echo '</div>';
    exit;
}

function mysql()
{
    $this->connect();
    $this->selectdatabase();
}
} //end class
$database = new mysql();

?>

[laserlight]

i am using class that i found somewhere on the net.

Where's the copyright notice and license, or at the very least attribution (e.g., to the PHP manual)?

it doesnt return the results the way it should.

How does it not work?

[scross]

one thing I noticed was that the constructor (ie. when you first make the class) tries to connect to the database, before you have a chance to call the config() function to set all the connection values. Maybe you should swap them around or let the programmer pass the username, password etc. into the constructor.

[rutin]

hi there,

thank you for your quick reply.

its snipet of the code that i found on the net.
there was not any comments at the top.

copyright or anything...

as for how it works, here is something that does not return right results.

// ***********************
// TEXT
// **********************
function mid($id)
{

     $select ="SELECT * FROM text where categoryid='$id'"; 
     $result = $this->database->query($select);
     $num_rows = $this->database->totalrows($result);
    if ($num_rows > '0') {
        while ($row = $this->database->fetcharray($result)) {
             print_r($row[title]);

            // there are three rows here, categoryid=1,categoryid=2,categoryid=3
           // they are not been printed to the screen, ony one 1

        }
    } 
}
// ***********************
// CATEGORY
// **********************
function top()
{   

    $select ="SELECT * from  categories";
    $result = $this->database->query($select);
    $num_rows = $this->database->totalrows($result);
    if ($num_rows > '0') {
      while($row = $this->database->fetcharray($result)){ 
            // print_r($row['categoryid']);
            $this->mid($row['categoryid']);
           // there are three rows here, categoryid=1,categoryid=2,categoryid=3
        }
    } 
}

Thanks,
R.

[rutin]

scross wrote:

one thing I noticed was that the constructor (ie. when you first make the class) tries to connect to the database, before you have a chance to call the config() function to set all the connection values. Maybe you should swap them around or let the programmer pass the username, password etc. into the constructor.

This was very nice, thanks... Lets put it.

[laserlight]

Well, instead of using some random PHP 4 class that you found online, why not use the MySQLi extension or the more flexible PDO extension? They both provide the kind of object based interface that you are looking for.