download script not working for videos?! and other random files.

[v3nt]

hello there - been using this script for a while but just realised it seem to be doing something funny to them when they are downloaded.

<? 	include("conf.php");
	header('Content-type: '.mime_content_type($server_path."/clientfolders/".$pth.$dw));
	header('Content-Disposition: attachment; filename='.$dw);
	readfile($server_path."/clientfolders/".$pth.$dw);		
?>

images work fine but for some reason videos, pngs and text files don't always work!!! Is there something wrong with my code or is this known issue? Many thanks,

D.

PS. download file page is here;
http://78.136.37.132/clientfolders/dologin.php?usr=crabbe&passF=qwerty

[jim_keller]

Are you sure the mime type for those files is getting properly detected? I would print the output of the mime_content_type() call to find out.

Also, according to the docs, mime_content_type() is deprecated in favor of the FileInfo extension: http://www.php.net/manual/en/ref.fileinfo.php . If the MIME detection is the problem, consider switching to fileinfo.

[jim_keller]

Also, adding some additional headers may help. The following is what I use for MP3 downloads:

<?php

//$mp3_filename and $full_path are brought in here from the DB

$mp3_download_name = preg_replace('/^[0-9]+\-/', '', $mp3_filename);
$transfer_len = filesize($full_path);

header("Pragma: public");
header("Expires: 0");
header("Cache-Control: must-revalidate, post-check=0, pre-check=0, max-age=60");
header("Cache-Control: public");
header("Content-Description: File Transfer");
header("Content-Type: audio/mpeg");
header("Content-Disposition: attachment; filename={$mp3_download_name};" );
header("Content-Transfer-Encoding: binary");
header("Content-Length: ".$transfer_len);

?>

[v3nt]

hello jim - thnaks for your responses!

they've helped out a little but movies, PSDs, mp3s (and other app files) dont work once downloaded?!?

my new code is;

 $file = $server_path."/clientfolders/".$pth.$dw;
 $ext = substr($file, strrpos($file, '.') + 1, strlen($file));

switch(strtolower($ext)) {
	case "pdf": $ctype="application/pdf"; break; 
	 case "exe": $ctype="application/octet-stream"; break; 
	 case "zip": $ctype="application/x-zip-compressed"; break; 
	 case "doc": $ctype="application/msword"; break; 
	 case "xls": $ctype="application/vnd.ms-excel"; break; 
	 case "ppt": $ctype="application/vnd.ms-powerpoint"; break; 
	 case "gif": $ctype="image/gif"; break; 
	 case "png": $ctype="image/png"; break; 
	 case "jpeg": 
	 case "jpg": $ctype="image/jpg"; break; 
	 case "mp3": $ctype="audio/mpeg"; break; 
	 case "wav": $ctype="audio/x-wav"; break; 
	 case "mpeg": 
	 case "mpg": 
	 case "mpe": $ctype="video/mpeg"; break; 
	 case "mov": $ctype="video/quicktime"; break; 
	 case "avi": $ctype="video/x-msvideo"; break; 

 //The following are for extensions that shouldn't be downloaded (sensitive stuff, like php files) 
 case "php": 
 case "htm": 
 case "html": 
 case "txt": die("<b>Cannot be used for ". $file_extension ." files!</b>"); break; 

 default: $ctype="application/force-download"; 
}

header('Content-type: '.$ctype);
header('Content-Disposition: attachment; filename='.$ctype."-".$dw);
header("Content-Length: ".filesize($server_path."/clientfolders/".$pth.$dw);
readfile($server_path."/clientfolders/".$pth.$dw);	

and the switch seems to be pretty accurate. I've added $ctype to the beginning of the file so you can see what filetype it thinks it is.

the download list is here and the first content-type is via a mime_content_type request and the second is via the switch method(the one i'm using on the actual download script)

any pointers much appreciated! D.

http://78.136.37.132/clientfolders/dologin.php?usr=crabbe&passF=qwerty