[RESOLVED] drop down selected from db not working

trendMM

Hi,

I have a field in my database that on the user end is shown with in your standard drop down menu. On the edit side of the user side I usually have it so it shows the drop down one again but sets the corresponding option to the the value/option stored in the database. Usually it works no problem, but for some reason it's just sitting at the first option in the array. Here's my code:

$myarray = array(
		1 => "New",
		2 => "Used"
		);

	function create_dropdown($array, $selected_id){
		$dropdown = "";

		foreach($array as $key=>$value){
		$selected = "";

		if($key == $selected_id){
			$selected = "selected";
			}

		$dropdown .="<option $selected value=\"".$key."\">".$value."</option>";
		}

		return $dropdown;
		}

	$dropdown = "<select name=\"type\" class=\"fields\">";
	$dropdown .= create_dropdown($myarray, $type);
	$dropdown .= " </select>";

I don't know what exactly the issue is. Towards the end of the code you'll see the variable "type" which is the variable being pulled from the database. I've posted it within to my page to make sure it was pulling in the correct code and it is. If stored to the database as "Used" the variable of type still shows Used by the drop down stays at "New". Any ideas?

Any help would be greatly appreciated!

Arenlor

Try this:

// ...
            if($key == $selected_id){ 
                $selected = 'selected="selected"'; 
                }
//...

trendMM

Thanks for your quick reply, but I saw what I was doing wrong.

$myarray = array(
		1 => "New",
		2 => "Used",
		);

Had to be switched to:

$myarray = array(
		New => "New",
		Used => "Used",
		);

I had just grabbed the snipplet from another drop down menu like this I had before where all the values were numbered, where as this one isn't. I found this out by looking at another drop down I had done in the past that was setup like this.

Problem is I'm now receiving this error:

Parse error: syntax error, unexpected T_DOUBLE_ARROW, expecting T_STRING or T_VARIABLE or '$' in /home/bmwmrcom/public_html/admin/bikes.php on line 148

Which is pointing directly to the line I fixed. Any ideas?

trendMM

Simple enough, I'll just switch the values to numbers. Avoid all this mess. Thanks for your help!

Weedpacket

FYI: the reason you got the syntax error is apparent from the syntax highlighting in the code you posted: new is a keyword.

So what you should have written is:

$myarray = array(
    'New' => 'New',
    'Used' => 'Used'
    );

But of course you can see that the repetition in that is redundant and unnecessary duplication.