[RESOLVED] stupid question about function use!

spiritssight

Hi,

I have a form, and I also have a function that I am using to decide if a var is to show or not show based on if its set

isset_var( $var ) right now I just have this at the top of the first form.

function isset_var($var)
	{
		if(isset($var))
		{
		return( $var );
		}
		else
		{
		$var = '';
		return( $var );
		}
	}

general_form.php I am only going to show two input as its not need for me to show all of them

<!-- <label for="e_id">Entity Identification: </label> -->
<input type="hidden" value=" '. $e_id .' " id="e_id" name="e_id" />

<label for="p_fin">Parent Fedral Identification Number: </label>
<input type="text" value="' . $p_fin .'" id="p_fin" name="p_fin" size="9" maxlength="9" />

how do I put me function into the this, I am using echo ' ': to display the form?

Sincerely,
Christopher

NogDog

<?php
echo '<input type="hidden" value="' . isset_var($e_id) . '" ide="e_id" name="e_id" />';

spiritssight

Thanks NogDog, I got to say that was a stupid question to ask as that is what I did but I did not put some fake text in the var $var that was set by else so I was unable to see if it did put something there, I was just see a error so I assumbed it was that it was not used right with then a echo, but as I not have that working and as you can see the issue was not at all to do with displaying but finding a way so that the error would not show if a var was not set.

Thanks :-)
Christopher

Weedpacket

The problem is that if $e_id isn't set then calling isset_var($e_id) would result in an uninitialised variable notice if you don't suppress it with an '@'.

That said, the function could be simplified/shortened depending on how you look at it:

 function isset_var($var)
{ return isset($var) ? $var : ''; }

Which might in PHP6 be reducible to

 function isset_var($var)
{ return $var ?: ''; }

spritssight wrote:
Thanks NogDog, I got to say that was a stupid question to ask as that is what I did but I did not put some fake text in the var $var that was set by else so I was unable to see if it did put something there, I was just see a error so I assumbed it was that it was not used right with then a echo, but as I not have that working and as you can see the issue was not at all to do with displaying but finding a way so that the error would not show if a var was not set.

Too much coffee?