If Else Statement

[tamtam]

Hi all,

I m having a bit of trouble displaying my report. It appears as if it only uses 2 sql statement (i.e. the one stated in blue), while the rest are ignored. I hope someone can point me to my mistake.

Below is the if else statement i use:-

[COLOR="Blue"]if ( $request->getRequestMethod() == REQUEST_POST )
    	{		
		if($request->getParam("table_m")==1)
			{
			$table_select="table_A";
			}
		else
			{
			$table_select="table_B";
			}
		if ($request->getParam("brand") != NULL && $request->getParam("groups") != NULL && $request->getParam("engine_no") != NULL)
			{
			$sql = "SELECT * FROM ".$table_select." WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "') AND brand='".$request->getParam("brand")."' AND groups='".$request->getParam("groups")."' AND engine_no='".$request->getParam("engine_no")."'";
			}
		elseif ($request->getParam("brand") != NULL && $request->getParam("groups") != NULL)
			{
			$sql = "SELECT * FROM ".$table_select." WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "') AND brand='".$request->getParam("brand")."' AND groups='".$request->getParam("groups")."'";
			}[/COLOR]
		elseif ($request->getParam("brand") != NULL)
			{
			$sql = "SELECT * FROM ".$table_select." WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "') AND brand='".$request->getParam("brand")."'";
			}
		elseif ($request->getParam("groups") != NULL)
			{
			$sql = "SELECT * FROM ".$table_select." WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "') AND groups='".$request->getParam("groups")."'";
			}
		else
			{
			$sql = "SELECT * FROM ".$table_select." WHERE stat<>'1' AND (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "')";
		   	//$sql = "SELECT * FROM ".$table_select." WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "') AND brand='".$request->getParam("brand")."'";
			}

Thank you 🙂

(Added

 tags around code -- NogDog)[/i]

[laserlight]

Well, are you sure that your tests were comprehensive enough to cover the possible paths of logic that lead to the "ignored" code in question?

[tamtam]

I ve tested a few times by commenting and uncommenting the sql statement with the same result that it only able to query 2 SQL statement.

[jkurrle]

You are missing a closing paren for the original if() statement, but I assume it's correct in your original code...

[jkurrle]

I have rewritten your statement a little bit. Let's insert this code instead, and see what executes:

if ( $request->getRequestMethod() == REQUEST_POST )
  {		
  if ($request->getParam("brand") != NULL )
    {
    if($request->getParam("groups") != NULL)
      {
      if($request->getParam("engine_no") != NULL)
        {
        $sql = "SELECT * FROM ".$table_select." 
          WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' 
          AND inv_date >= '" . $request->getParam("inv_date"). "') 
          AND brand='".$request->getParam("brand")."' 
          AND groups='".$request->getParam("groups")."' 
          AND engine_no='".$request->getParam("engine_no")."'";
        } // END if($request->getParam("engine_no") != NULL)
      else // $request->getParam("engine_no") == NULL
        {
        $sql = "SELECT * FROM ".$table_select." 
          WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' 
          AND inv_date >= '" . $request->getParam("inv_date"). "') 
          AND brand='".$request->getParam("brand")."' 
          AND groups='".$request->getParam("groups")."'";
        }
      } // END if($request->getParam("groups") != NULL)
    else // $request->getParam("groups") == NULL
      {
      $sql = "SELECT * FROM ".$table_select." 
        WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' 
        AND inv_date >= '" . $request->getParam("inv_date"). "') 
        AND brand='".$request->getParam("brand")."'";
      }
    } // END if ($request->getParam("brand") != NULL ) 
  elseif ($request->getParam("groups") != NULL)
    {
    $sql = "SELECT * FROM ".$table_select." 
      WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' 
      AND inv_date >= '" . $request->getParam("inv_date"). "') 
      AND groups='".$request->getParam("groups")."'";
    } // END $request->getParam("groups") != NULL
  else
    {
    $sql = "SELECT * FROM ".$table_select." 
      WHERE stat<>'1' 
      AND (inv_date <= '" . $request->getParam("inv_date2"). "' 
      AND inv_date >= '" . $request->getParam("inv_date"). "')";
    } // END else
  } // END if($request->getRequestMethod() == REQUEST_POST)

[Weedpacket]

A lot of the SQL code is duplicated as well.

if ( $request->getRequestMethod() == REQUEST_POST )
{        

	$sql = "SELECT * FROM $table_select
	WHERE (inv_date <= '" . $request->getParam("inv_date2"). "' AND inv_date >= '" . $request->getParam("inv_date"). "')";
	if ($request->getParam("brand") != null )
	{
		$sql .= " AND brand='".$request->getParam("brand")."'";
		if($request->getParam("groups") != null)
		{
			$sql .= " AND groups='".$request->getParam("groups")."'";
			if($request->getParam("engine_no") != null)
			{
				$sql .= " AND engine_no='".$request->getParam("engine_no")."'";
			}
		}
	}
	elseif ($request->getParam("groups") != null)
	{
		$sql .= " AND groups='".$request->getParam("groups")."'";
	}
	else
	{
		$sql .= " AND stat<>'1'";
	}
}

Which bits of the code get run in which situations?

if ($request->getParam("brand") != null )
{
	// brand!=null

if($request->getParam("groups") != null)
{
	//brand!=null && groups!=null

	if($request->getParam("engine_no") != null)
	{
		//brand!=null && groups!=null && engine_no!=null
	}
}
}
elseif ($request->getParam("groups") != null)
{
	// brand==null && groups!=null
}
else
{
	// brand==null && groups==null
}

[jkurrle]

Oooh! I like that! Didn't take the time to think of all the repetiveness in the SQL statements. I just didn't like that chain of elseif() statements...