Help with input form variables in a loop

africantiger

Could someone help me with the following problem:

I am displaying the contents of my database in a table using a do ... while loop. Most of the cells are displayed as an editable form. Because the data is being outputted via a loop I can't figure out how to capture the contents of the loop variables.
example:

<html>

<body>

<?php



$db = mysql_connect("localhost", "user","pass");

mysql_select_db("citrus_fundraiser",$db);

echo "<table border=1>\n";

// show customer list

   $result = mysql_query("SELECT * FROM customers",$db);
   $result2 = mysql_query("SELECT * FROM prices",$db);

mysql_fetch_array($result2)) {
    if ($myrow = mysql_fetch_array($result)) {
        $myrow2 = mysql_fetch_array($result2);
   echo "<tr><td><b>Customer</b></td><td><b>Telephone</b></td><td><b>Oranges</b></td><td><b>Grapefruits</b></td><td><b>Tangerines</b></td><td><b>Variety</b></td><td><b>\$Order</b></td><td><b>\$Paid</b></td><td><b>\$Owing</b></td><td><b>Picked Up</b></td><td><b>Comments</b></td><br>\n";

  do {
    //Set customer name
    $cn = sprintf("%s %s",$myrow["firstname"],$myrow["lastname"]);
    $phone = $myrow["phone"];
    $ordered = ($myrow["citrus1"]*$myrow2["citrus1_price"])+($myrow["citrus2"]*$myrow2["citrus2_price"])+($myrow["citrus3"]*$myrow2["citrus3_price"])+($myrow["citrus4"]*$myrow2["citrus4_price"]);
    $owing = $ordered - $myrow["paid"];
    $total_order = $myrow["citrus1"] + $myrow["citrus2"] + $myrow["citrus3"] + $myrow["citrus4"];
        printf("<tr bgcolor='red'><td><input type=\"text\" name=\"cn[]\" value=\"%s\"></td>", $cn);
    printf("<td><input type =\"text\" size =\"12\" name=\"phone[]\" value=\"%s\"></td>", $myrow["phone"]);
    printf("<td><input type =\"text\" size =\"6\" name=\"citrus1[]\" value=%u></td>", $myrow["citrus1"]);
    printf("<td><input type =\"text\" size =\"11\" name=\"citrus2[]\" value=%u></td>", $myrow["citrus2"]);
    printf("<td><input type =\"text\" size =\"10\" name=\"citrus3[]\" value=%u></td>", $myrow["citrus3"]);
    printf("<td><input type =\"text\" size =\"7\" name=\"citrus4[]\" value=%u></td>", $myrow["citrus4"]);
    printf("<td>%01.2f</td>", $ordered);
    printf("<td><input type =\"text\" size=\"5\" name=\"paid[]\" value=%01.2f></td>", $myrow["paid"]);
    printf("<td>%01.2f</td>", $owing);
    printf("<td><input type =\"text\" size=\"9\" name=\"pickedup[]\" value=\"%u\"></td>", $myrow["pickedup"]);
    printf("<td><input type =\"text\" size=\"25\" name=\"comments[]\" value=\"%s\"></td></tr><br>\n", $myrow["comments"]);
  } while ($myrow = mysql_fetch_array($result));

}



?>



</body>



</html>

I tried making the variables in the input form arrays by adding [] to the name (i.e. paid[]) but that did not help.

Any and all help will be much appreciated.

Thanks,

africantiger...

sneakyimp

A do-while loop is not really the best way to deal with database data. A while loop works great. Also, you are not correctly handling your two different queries. You should either have two different loops or you should have one combined query and one loop.

africantiger

sneakyimp wrote:
A do-while loop is not really the best way to deal with database data. A while loop works great. Also, you are not correctly handling your two different queries. You should either have two different loops or you should have one combined query and one loop.

I am getting the data out of the database O.K. I am currently struggling with getting data from the $_POST variable. I have the following code:

    printf("<td><input type =\"text\" size =\"12\" name=\"phone[]\" value=\"%s\"></td>", $myrow["phone"]);

Note that phone is an array, I have a few combinations of $_POST['phone'] but I have not found the combination that will be the values of phone[].

sneakyimp

I'm not sure what you're after exactly but it sounds like you can retrieve data from your database satisfactorily and you are displaying it in a form. The problem is when the form gets submitted you don't know where to find your data.

That could be because there are no <FORM></FORM> tags on your page. There is also no closing TABLE tag nor a submit button.

If that's not what you mean then you should take another stab at describing what your problem is because I'm not really sure at all.

africantiger

sneakyimp wrote:
I'm not sure what you're after exactly but it sounds like you can retrieve data from your database satisfactorily and you are displaying it in a form. The problem is when the form gets submitted you don't know where to find your data.

That could be because there are no <FORM></FORM> tags on your page. There is also no closing TABLE tag nor a submit button.

If that's not what you mean then you should take another stab at describing what your problem is because I'm not really sure at all.

Your assessment is correct. Once the form is submitted I cannot get the data. I do have a form with submit and also a closing table tag.

<html>

<body>

<?php

$db = mysql_connect("localhost", "root","pass1");

mysql_select_db("citrus_fundraiser",$db);

echo "<table border=1>\n";

  //If you have received a submission.
  if ($_POST['mysubmit'] == "Submit"){
        $phone = $_POST['phone_a'];
        echo "First phone number = ".$phone[0]."<br>";
        echo "Third phone number = ".$phone[2]."<br>";
}


// show customer list

$result = mysql_query("SELECT FROM customers",$db);
$result2 = mysql_query("SELECT FROM prices",$db);

if ($myrow = mysql_fetch_array($result)) {
    $myrow2 = mysql_fetch_array($result2);
  // display list if there are records to display

echo "<tr><td><b>Customer</b></td><td><b>Telephone</b></td><td><b>Oranges</b></td><td><b>Grapefruits</b></td><td><b>Tangerines</b></td><td><b>Variety</b></td><td><b>\$Order</b></td><td><b>\$Paid</b></td><td><b>\$Owing</b></td><td><b>Picked Up</b></td><td><b>Comments</b></td><br>\n";
$i = 0;
do {
//Set customer name
$cn[$i] = sprintf("%s %s",$myrow["firstname"],$myrow["lastname"]);
$phone[$i] = $myrow["phone"];
$ordered[$i] = ($myrow["citrus1"]$myrow2["citrus1_price"])+($myrow["citrus2"]$myrow2["citrus2_price"])+($myrow["citrus3"]$myrow2["citrus3_price"])+($myrow["citrus4"]$myrow2["citrus4_price"]);
$paid[$i] = $myrow["paid"];
$owing[$i] = $ordered - $myrow["paid"];
$citrus1[$i] = $myrow["citrus1"];
$citrus2[$i] = $myrow["citrus2"];
$citrus3[$i] = $myrow["citrus3"];
$citrus4[$i] = $myrow["citrus4"];
$pickedup[$i] = $myrow["pickedup"];
$comments[$i] = $myrow["comments"];
$total_order[$i] = $citrus1[$i] + $citrus2[$i] + $citrus3[$i] + $citrus4[$i];
printf("<tr bgcolor='red'><td><input type=\"text\" name=\"cn_a[]\" value=\"%s\"></td>", $cn[$i]);
printf("<td><input type =\"text\" size =\"12\" name=\"phone_a[]\" value=\"%s\"></td>", $phone[$i]);
printf("<td><input type =\"text\" size =\"6\" name=\"citrus1_a[]\" value=%u></td>", $citrus1[$i]);
printf("<td><input type =\"text\" size =\"11\" name=\"citrus2_a[]\" value=%u></td>", $citrus2[$i]);
printf("<td><input type =\"text\" size =\"10\" name=\"citrus3_a[]\" value=%u></td>", $citrus3[$i]);
printf("<td><input type =\"text\" size =\"7\" name=\"citrus4_a[]\" value=%u></td>", $citrus4[$i]);
printf("<td>%01.2f</td>", $ordered[$i]);
printf("<td><input type =\"text\" size=\"5\" name=\"paid_a[]\" value=%01.2f></td>", $paid[$i]);
printf("<td>%01.2f</td>", $owing[$i]);
printf("<td><input type =\"text\" size=\"9\" name=\"pickedup_a[]\" value=\"%u\"></td>", $pickedup[$i]);
printf("<td><input type =\"text\" size=\"25\" name=\"comments_a[]\" value=\"%s\"></td></tr><br>\n", $comments[$i]);
$i++;

  } while ($myrow = mysql_fetch_array($result));

}

echo "</table>\n";

?>
<form action="cf2.php3" method="POST">
<input type="submit" name="mysubmit" value="Submit">
</form>

</body>

</html>

africantiger

I was missing the <form></form> element around the table containing the <input> tags.

africantiger

This has been resolved with the suggestions from SneakyImp.