[RESOLVED] Simple Looping Problem

[scriderpsd]

I have (what seems like it should be) a simple looping problem.

I'm pulling three rows out of a database to create 3 featured boxes on my site. Each of the three boxes has should have a different <div> element applied it it (featuredLeft, featuredCenter, featuredRight). I'm using a while loop to populate my three tables but I can't figure out how to cycle through the three <div> elements within that while loop.

Here is what I have so far. The while loop works but all three tables have "featuredRight" as the <div> id.

$query_featured   = "SELECT * FROM cards where featured = 'Y' LIMIT 3";
$result_featured  = mysql_query($query_featured, $conn) or die('Error, this query failed');

$choose_style = array ('featuredLeft', 'featuredCenter', 'featuredRight');




while($featured_row = mysql_fetch_array($result_featured)) {

for ($i = 0; $i < 3; $i++) {
	$featured_style = $choose_style[$i];
}

			echo '<div id="'.$featured_style.'">' . PHP_EOL;
         echo '<table width="225" height="126" cellpadding="0" cellspacing="1" bgcolor="BBCD7D" align="center">' . PHP_EOL;				
                echo '<tr>' . PHP_EOL;
                 echo '<td><div align="center"><a href="http://valuecreditcard.at/ukoffer?CTY=1&CID=2303"><img src="'.$featured_row[feat_img_link].'"></a>' . PHP_EOL;
                      echo '&nbsp;</div>' . PHP_EOL;
                   echo '</td>' . PHP_EOL;
                echo '</tr>' . PHP_EOL;
                echo '<tr>' . PHP_EOL;
                  echo '<td><div align="center"><font size="1" face="Verdana, Arial, Helvetica, sans-serif">0% 
                      interest on Purchases and Balance Transfers for 6 months. 
                      16.9% APR variable typical.</font></div>' . PHP_EOL;
                   echo '</td>' . PHP_EOL;
             		 echo '</tr>' . PHP_EOL;       
         	echo '</TABLE>' . PHP_EOL;
       echo '</div>' . PHP_EOL;

}

As always, any help is much appreciated.

Scott

[Kudose]

scriderpsd wrote:

The while loop works but all three tables have "featuredRight" as the <div> id.

Cause you are setting $featured_style 3 times without using it, then using it's last known value for all of your MySQL loops.

for ($i = 0; $i < 3; $i++) {
        $featured_style = $choose_style[$i];
    }

[scriderpsd]

Okay, so I got that part but how do I iterate through and use $featured_style each time? Do I need to change the position of my for loop...like putting it around the while loop?

[jeremyphphaven]

you can still do an iteration ($i=0) before the while loop and then add $i++; right before the end...

example

$i=0;
while ($row = mysql_fetch_array($result))
{
     // DO SOMETHING \\
     $choose_style[$i];
     // ADD ONE
     $i++;
}

[laserlight]

Basically, follow jeremyphphaven's advice and use $choose_style[$i] instead of $featured_style, getting rid of the inner for loop.

You could change the while loop into a for loop too:

for ($i = 0; $row = mysql_fetch_array($result); $i++)

As an added precaution I might write:

for ($i = 0; ($row = mysql_fetch_array($result)) && $i < count($choose_style); $i++)

to ensure that I never get an array out of bounds error when I access $choose_style.