array in an if statement

[g5604]

Hi,

This is one of my first go`s at php. I am trying to build an xml file from a directory. Everything is working great apart from i need to have multiple extensions ".jpg",".swf", ."gif" to filter the files with. I know a need an array, but i am not sure how to go about it,

Also i wonder if anyone can tell me if there is any security/compatibility measure i need to take and if my code could be improved :-)

here is my code:

<?php

$imageDir = 'gallery/';
$extension = '.swf';

 if ($folder = opendir($imageDir)) {

  $filenames=array();

   while (false !== ($file = readdir($folder))) {
        if (stristr($file, $extension)) array_push($filenames, $file);
   }

   $output = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
   $output .= "<folder>";
   foreach ($filenames as $source) {
        $imageName = str_replace("_"," ",$source);
        $imageName = str_replace($extension,"",$imageName);
        $output .= "\t<image src=\"$imageDir$source\">$imageName</image>\n";
   }
   $output .= "</folder>";

   closedir($folder);

   $fp = fopen("gallery.xml", "w");
   fwrite($fp, $output);
   fclose($fp);

  }
?>

thanks,
G

[bpat1434]

Make extensions an array... then use [man]in_array/man to see if an extension is inside the array. Something like:

$extensions = array('.jpg', '.jpeg', '.gif', '.swf');

// Inside the loop, you then need to get the extension:
$dot = strrchr($filename, '.');
$ext = substr($filename, $dot);

if(in_array($ext, $extensions))
{
    // Do whatever
}

[g5604]

HI bpat1434,

thanks for your help.

I understand the principle, but i am not entirely sure how to fit it in with my code.

where does the var $filename come from and which loop does it need to go inside, the while or the for?

sorry for such stupid questions :-(

would this be correct:

  while (false !== ($file = readdir($folder))) {

$dot = strrchr($filename, '.');
$ext = substr($filename, $dot);

if(in_array($ext, $extensions))
{
 array_push($filenames, $file);
} 
  }

[bpat1434]

Sorry, when I said $filename, I meant $file.

Other than that, it would be proper.

[g5604]

great, makes more sense now :-)

here is my code now, but its only outputting <?xml version="1.0" encoding="utf-8"?><folder></folder> in the xml file, not the image tag, any ideas why? i think it might have something to do with the second line in the for loop?

thanks for your help with this.

<?php

$imageDir = 'gallery/';
$extensions = array('.jpg', '.jpeg', '.gif', '.swf');

if ($folder = opendir($imageDir)) {

   $filenames=array();

 while (false !== ($file = readdir($folder))) {
	$dot = strrchr($file, '.');
	$ext = substr($file, $dot);

    if(in_array($ext, $extensions)){
		array_push($filenames, $file);

	} 

   }

   $output = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
   $output .= "<folder>";
   foreach ($filenames as $source) {
        $imageName = str_replace("_"," ",$source);
        $imageName = str_replace($extensions,"",$imageName);
        $output .= "\t<image src=\"$imageDir$source\">$imageName</image>\n";
   }
   $output .= "</folder>";

   closedir($folder);

   $fp = fopen("gallery.xml", "w");
   fwrite($fp, $output);
   fclose($fp);

       }
?>

[bpat1434]

Sorry. The output from strrchr is the actual extension. So instead of

$dot = strrchr($file, '.');

change it to this:

$ext = strrchr($file, '.');

And you can remove this line:

$ext = substr($file, $dot);

[g5604]

thanks, :-)

i actually worked that out a for myself a few mins ago.

many thanks for you help with this.

[Jack_McSlay]

I think extensions are a bad way to determine a file's content. I would suggest using mime_content_type() instead, not to mention your current script apparently will fail to recognize uppercase extensions.

Id suggest replacing

         $dot = strrchr($file, '.');
        $ext = substr($file, $dot);

    if(in_array($ext, $extensions)){
        array_push($filenames, $file);

    }

with

   $mime = mime_content_type($file);

   if (in_array ($mime,$mimetypes) ){
            array_push($filenames, $file);

    }

obviously, replace your $extensions array with a $mimetypes.
this page has a list of image mimes (not all of them obviously, only the ones supported by getimageinfo() ), check the 2nd column of the table

http://www.php.net/image_type_to_mime_type

[g5604]

thanks! good tip :-)