Comma separated list into Unordered List

clubbedougan

Hi,

I have a column in my db that stores data like so 'bla,bla' now I would like this to echo out as '<ul><li>bla</li><li>bla</li></ul>'.

I have the following code, but this stores it on the one <li></li> rather than starting a new, when it reaches a comma.

echo '<ul>';

$r = mysql_query("SELECT interest FROM listings WHERE hc = '$hc' ORDER BY interest ASC"); 

if (mysql_num_rows($r) > 0) {
		while ($menu_row = mysql_fetch_array($r, MYSQL_NUM)) {
    	echo '<li>' . $menu_row[0]. '</li>';
	}
}

echo '</ul></p>';

That code doesn't consider the comma, which I would need it do, to add another line to the list.

So I need it to end up like <li>test1</li><li>test2</li> etc.

Right now it's just <li>test1,test2</li>

Any help would be fan-brilliant-astic!

Clarkey_Boy

Try the following:


echo "<ul>"; 
$r = mysql_query("SELECT interest FROM listings WHERE hc = '".$hc."' ORDER BY interest ASC");

for($i = 0; $i < mysql_num_rows($r); $i++) {
     echo "<li>".$mysql_result($r, $i, <column-name>)."</li>";
}

echo "</ul></p>";

Dont forget to replace "<column-name>" with the name of the column you want to take the data from. Also, is there supposed to be a </p> in the last line? Only there is no <p> in the code you posted.

Clarkey

laserlight

I have a column in my db that stores data like so 'bla,bla'

That is typically the result of bad database design. You should avoid multi-valued fields.

Have you considered using another table since you have a one to many relationship?

clubbedougan

Thanks for the replies.

I seem to be getting a Parse error on this line:

echo "<li>".$mysql_result($r, $i, <interest>)."</li>";

Unexpected '<'. Any ideas?

Would it make more sense to have a separate table storing interests?

laserlight

Unexpected '<'. Any ideas?

<interest> should be replaced by 'interest'.

Would it make more sense to have a separate table storing interests?

From what I understand of your data, yes.

Clarkey_Boy

clubbedougan wrote:
Thanks for the replies.

I seem to be getting a Parse error on this line:

echo "<li>".$mysql_result($r, $i, <interest>)."</li>";

Unexpected '<'. Any ideas?

Would it make more sense to have a separate table storing interests?

I meant that you replace the full string <column-name> with the name of the column, including the < and >. (Dont forget the double quotes around the column name, unless the column name is stored in a variable).

Clarkey

laserlight

I looked at your solution more carefully, Clarkey Boy, and I think you misunderstand the problem. The problem is that the data is stored in comma delimited form ('bla,bla'). Your solution does not address this as it merely recommends mysql_result() over mysql_fetch_array() where only one column is selected. [man]explode[/man() could address this, but it would be a hack compared to a re-design of the database.