[RESOLVED] If Statement not working

[needinghelpasap]

Hi,

I am building a custom order form for products. I have included drop down boxes, I have therefore used a page to bring all this information forward to work out price. I am attempting to use an If statement as seen below. Do you know why this wouldn't work? Always jumps to the else statement.

<?php
if ($package == '7oz Bag')
{
echo "Price";
}
else if($package == 'Gift Bag (1.7 oz)')
{
echo "Price2";
}
else
{
echo "Cant find package - $package";
}
?>

[roscor]

take a look at this thread, it may give you some hints?

[dougal85]

do

var_dump($package)

so you can see whats in $package. The obvious answer is $package never contains 'Gift Bag (1.7 oz)' or '7oz Bag'

[rsmith]

Well first off I notice that you switch between double quotes and single quotes. Not a good thing to do.Secondly as dougal85 suggested, I don't think $package is ever getting set.

<?php

 if(isset(!empty($package)){
      if($package === "7oz Bag"){
           echo "Price";
      }elseif($package === "Gift Bag (1.7 oz)"){
           echo "Price2";
      }else{
           echo "Cant find package - ".$package;
      }
 }
?>

[needinghelpasap]

Thanks rsmith and dougal85, my code now looks like this:

   <?php
	var_dump($package)
	if(isset(!empty($package))
	{
      if($package === "7oz Bag")
	  {
           echo "Price";
      }
	  elseif($package === "Gift Bag (1.7 oz)")
	  {
           echo "Price2";
      }
	  else
	  {
           echo "Cant find package - ".$package;
      }
 	}
     ?>

But now throws the following error:

Parse error: parse error, unexpected T_IF in C:\wamp\www\messagepayment.php on line 283

This is the line on 283:
if(isset(!empty($package))

Any ideas?

[laserlight]

Please indent your code and post it within php bbcode tags:

<?php
var_dump($package)
if(isset(!empty($package))
{
    if($package === "7oz Bag")
    {
        echo "Price";
    }
    elseif($package === "Gift Bag (1.7 oz)")
    {
        echo "Price2";
    }
    else
    {
        echo "Cant find package - ".$package;
    }
}
?>

The first problem is that you forgot a terminating semi-colon. It should be:

var_dump($package);

The next problem is that this does not make sense and has a syntax error:

if(isset(!empty($package))

You probably want to write:

if(!empty($package))

But wait, then you should shift the var_dump() to:

if(!empty($package))
{
    var_dump($package);

since it is possible that $package does not exist at a point when you are trying to use var_dump() on it.

[needinghelpasap]

I am now experiencing this problem:
Parse error: parse error, unexpected '!', expecting T_VARIABLE or '$' in C:\wamp\www\messagepayment.php on line 283

line 283 is: if(isset(!empty($package))

[laserlight]

Well, that's just what I said. You cannot use isset and empty together in that way. Just remove the isset.

[needinghelpasap]

Code now looks like this:

        <?php
	  if(!empty($package))
                  {
    	          var_dump($package); 		
          	          if($package == "7oz Bag")
                          {
                                    echo "Price";
          	          }
                          elseif($package == "Gift Bag (1.7 oz)")
	          {
                                    echo "Price2";
          	          }
	          else
	         {
                                    echo "Cant find package - ".$package;
          	         }
     	   }

It now loads the page but where the message should appear it reads:
string(1) " " Cant find package -

Sorry I am a bit new to all this.

Thanks

[dougal85]

needinghelpasap wrote:

It now loads the page but where the message should appear it reads:
string(1) " " Cant find package -

string(1) " " - that is the output from var_dump - basically its a string, one character long and it only contains a space. So it is never being set with anything useful. The actual content of the string is contained between the double quotes in the result from var_dump()

Then the else if your if outputs "Cant find package - " note nothing at the end because $package because it doesn't contain more than a space.

You need to check the code you have before this? Where does $package come from?

[laserlight]

It now loads the page but where the message should appear it reads:

$package comes from a form. If the form was sent via the post method, then you should use $POST['package'] instead of $package. If the form was sent via the get method, use $GET['package']. If you are not concerned either way, use $_REQUEST['package'].

As such, with indentation, I would expect something like this:

<?php
if (!empty($_POST['package']))
{
    var_dump($_POST['package']); // debugging
    if ($_POST['package'] == "7oz Bag")
    {
        echo "Price";
    }
    elseif ($_POST['package'] == "Gift Bag (1.7 oz)")
    {
        echo "Price2";
    }
    else
    {
        echo "Cant find package - " . htmlspecialchars($_POST['package']);
    }
}
?>

[Kudose]

edit Got beat by two posts ...

[needinghelpasap]

Thank you very much it worked 🙂 you have made me one happy person!!