[RESOLVED] How do I stop a php script from executing?

impactdesignpro

I am creating a page which will allow me upload data and an mp3 file but I need some help. If the file type does not match the condition, I need the script to stop execution and not add the data to the db and the file to the directory. Everything works fine other than the checking of file type and stopping the script.

Here is what I have right now:

// check file type
if (!($file=="audio/mp3")):
    echo "You may only upload mp3 files.<br>";
endif;

This does not work. When I upload a file that is not a mp3 file - I get the error message "You may only upload mp3 files." but the script still executes and the file is uploaded.

When I upload an mp3 file - I get the error message "You may only upload mp3 files." and the script continues doing what it is suppose to do.

Any help on this will be greatly appreciated. Thanks

Horizon88

use exit() or die()

www.php.net/exit
www.php.net/die

impactdesignpro

Thanks... the die statement works but I still have a problem. I don't know if I have the right mime type... The problem that I am having now is that it dies even if the file is an mp3 file

the code I have is:

// Checks file type
if (!($file=="audio/mp3")) {
die ("<b>ERROR!!! You may only upload mp3 files. Please try again<br>");
$ok=0;
}

where it say's (!($file=="audio/mp3")) is that right? or should it be- media/mp3...?

Again thanks!!!!

Horizon88

where is $file coming from? What does that variable hold?

impactdesignpro

I get the information from a form
$file=($_FILES['file']['name']);

The name of the file is saved in the db and the file is uploaded to a folder.

below is what the code looks like...

include("includes/config.inc.php");
include("includes/connect.inc.php");

//This is the directory where the mp3 files will be saved 
$target = "../mp3/"; 
$target = $target . basename( $_FILES['file']['name']); 

//This gets all the other information from the form 
$month=$_POST['month'];
$day=$_POST['day'];
$year=$_POST['year'];
$title=$_POST['title'];  

$speaker=$_POST['speaker'];  

$file=($_FILES['file']['name']); 
// Checks file type
if (!($file=="audio/mp3")) {
die ("<b>ERROR!!! You may only upload mp3 files. Please try again<br>");
$ok=0;
}

NogDog

Assuming $file is "<something>.mp3", you could just check for the ".mp3" portion:

if(substr($file, -3) != ".mp3") {

PS: Note that this does not guarantee what type of file it actually is, just what the file suffix is.

impactdesignpro

nope... if(substr($file, -3) != ".mp3") { does not work... still not letting me upload mp3 files.

// Checks file type
if(substr($file, -3) != ".mp3") {
die ("<b>ERROR!!! You may only upload mp3 files. Please try again<br>");
$ok=0;
}

Horizon88

that's because you're pulling back 3 characters with substr() and checking for four characters, if I'm not mistaken.

But also, there should be a MIME type field passed with the uploaded image you can check.

edit: Please do a:

echo '<pre>'; print_r($_FILES); echo '</pre>';

There ought to be a mimetype field in there, but I can't think of what it's called offhand, and I can't look it up at the moment.

impactdesignpro

where do i insert the code:
echo '<pre>'; print_r($_FILES); echo '</pre>';
???

Horizon88

Anywhere after $_FILES has been populated with information.

impactdesignpro

here is what I get when I debug it...

Array ( [file] => Array ( [name] => my.mp3 [type] => audio/mpeg [tmp_name] => /tmp/phpZDVOQu [error] => 0 [size] => 271829 ) )

Weedpacket

Looky:

impactdesignpro wrote:
[type] => audio/mpeg

PS: Note that this does not guarantee what type of file it actually is, just what the client that uploaded it claims it is.

Horizon88

Thanks, Weedpacket. As he pointed out, impact, the $_FILES['type'] field is the mime-type of the uploaded file, but it can be spoofed - safest bets are to check the mime type, then check the extension as well, and make sure your server is set up to serve the extensions properly.

So something like:

if ($_FILES['type'] == 'audio/mpeg' && strtolower(substr($file, -3)) == 'mp3') {
   // upload
}
else {
   // error
}

Would probably be your best bet, unless you wanted to get into some server-side way of validating that the file is indeed a match for that MIME type, which I wouldn't know how to do.

impactdesignpro

Thanks Horizon88 and Weedpacket for all your help. Actually I tried something different and it worked... the code is:

$target = "../mp3/"; 
$target = $target . basename( $_FILES['file']['name']); 
$ok=1;
if(!($file_type=="audio/mpeg"))
{ 
echo "ERROR!!! Make sure that you are uploading an mp3 file<br>"; 
$ok=0; 
} 
//Here we check that $ok was not set to 0 by an error 
if ($ok==0) 
{ 
Echo "Sorry your file was not uploaded"; 
} 
//If everything is ok upload it 
else
{ 
if(move_uploaded_file($_FILES['file']['tmp_name'], $target)) 
{ 
echo "<font color='#000000'>The file ". basename( $_FILES['file']['name']). " has been uploaded"; 
}
else {
die ();}

Again thanks for taking the time to help me. I appreciate that

Horizon88

All that does is checks to make sure it isn't audio/mpeg. I could upload images or executables into that, I'm pretty sure. But okay.

impactdesignpro

Here's how it works:
Within the if statment I have:

if(!($file_type=="audio/mpeg"))
{ 
echo "ERROR!!! Make sure that you are uploading an mp3 file<br>"; 
$ok=0; 
}

because I have the exclaimation point - that means the "if" stament is carried out if the condition is false.
So if I tried to upload a file other than an mpeg file it will carry out the condition - the condition is:

echo "ERROR!!! Make sure that you are uploading an mp3 file<br>"; 
$ok=0;

down further I have my die () command

Horizon88

Gotcha, I missed the exclamation because I usually do != instead of !... ==.